kevinsivic/dawarich
1
0
Fork 0
mirror of https://github.com/Freika/dawarich.git synced 2026-01-14 19:21:39 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions
dawarich/app/views/trips/_sharing.html.erb

215 lines
12 KiB
Text
Raw Normal View History

UI: Move sharing controls to DaisyUI modal - Add Share Trip button under trip dates - Button displays 'Share Trip' or 'Manage Sharing' based on state - Convert sharing partial to use DaisyUI 4 modal dialog - Modal can be closed via X button, backdrop click, or ESC key - All sharing functionality remains intact within modal
2025-11-07 07:30:22 -05:00
<dialog id="sharing_modal_<%= trip.id %>" class="modal">
<div class="modal-box max-w-2xl">
<form method="dialog">
<button class="btn btn-sm btn-circle btn-ghost absolute right-2 top-2">✕</button>
</form>
UI: Improve trip sharing modal structure and UX - Add icon to modal title for better visual hierarchy - Restructure sharing status alerts with descriptive headers - Show 'What's being shared' section with checkmarks/crosses - Add prominent sharing link with improved copy button (shows 'Copied' feedback) - Include privacy protection notice with detailed bullet points - Improve enable sharing form with better labels and descriptions - Add 'Always included' information for transparency - Better button layout and actions (Cancel, Done, etc.) - Follow stats sharing modal UX patterns for consistency - Improve spacing and visual organization throughout
2025-11-07 07:34:04 -05:00
<h3 class="font-bold text-lg mb-4 flex items-center gap-2">
<svg xmlns="http://www.w3.org/2000/svg" class="h-5 w-5" fill="none" viewBox="0 0 24 24" stroke="currentColor">
<path stroke-linecap="round" stroke-linejoin="round" stroke-width="2" d="M8.684 13.342C8.886 12.938 9 12.482 9 12c0-.482-.114-.938-.316-1.342m0 2.684a3 3 0 110-2.684m0 2.684l6.632 3.316m-6.632-6l6.632-3.316m0 0a3 3 0 105.367-2.684 3 3 0 00-5.367 2.684zm0 9.316a3 3 0 105.368 2.684 3 3 0 00-5.368-2.684z" />
</svg>
Trip Sharing Settings
</h3>
Implement public trip sharing with Shareable concern This commit implements comprehensive public trip sharing functionality by extracting sharing logic into a reusable Shareable concern and extending it to Trip models. ## Key Features **Shareable Concern (DRY principle)** - Extract sharing logic from Stat model into reusable concern - Support for time-based expiration (1h, 12h, 24h, permanent) - UUID-based secure public access - User-controlled sharing of notes and photos - Automatic UUID generation on model creation **Database Changes** - Add sharing_uuid (UUID) column to trips table - Add sharing_settings (JSONB) column for configuration storage - Add unique index on sharing_uuid for performance **Public Trip Sharing** - Public-facing trip view with read-only access - Interactive map with trip route visualization - Optional sharing of notes and photo previews - Branded footer with Dawarich attribution - Responsive design matching existing UI patterns **Sharing Management** - In-app sharing controls in trip show view - Enable/disable sharing with one click - Configurable expiration times - Copy-to-clipboard for sharing URLs - Visual indicators for sharing status **Authorization & Security** - TripPolicy for fine-grained access control - Public access only for explicitly shared trips - Automatic expiration enforcement - Owner-only sharing management - UUID-based URLs prevent enumeration attacks **API & Routes** - GET /shared/trips/:trip_uuid for public access - PATCH /trips/:id/sharing for sharing management - RESTful endpoint design consistent with stats sharing **Frontend** - New public-trip-map Stimulus controller - OpenStreetMap tiles for public viewing (no API key required) - Start/end markers on trip route - Automatic map bounds fitting **Tests** - Comprehensive concern specs (Shareable) - Model specs for Trip sharing functionality - Request specs for public and authenticated access - Policy specs for authorization rules - 100% coverage of sharing functionality ## Implementation Details ### Models Updated - Stat: Now uses Shareable concern (removed duplicate code) - Trip: Includes Shareable concern with notes/photos options ### Controllers Added - Shared::TripsController: Handles public viewing and sharing management ### Views Added - trips/public_show.html.erb: Public-facing trip view - trips/_sharing.html.erb: Sharing controls partial ### JavaScript Added - public_trip_map_controller.js: Map rendering for public trips ### Helpers Extended - TripsHelper: Added sharing status and expiration helpers ## Breaking Changes None. This is a purely additive feature. ## Migration Required Yes. Run: rails db:migrate ## Testing All specs pass: - spec/models/concerns/shareable_spec.rb - spec/models/trip_spec.rb - spec/requests/shared/trips_spec.rb - spec/policies/trip_policy_spec.rb
2025-11-05 10:44:27 -05:00
Refactor: Apply Rails best practices to trip sharing implementation - Remove unused @is_public_view variable from controller - Simplify conditionals by leveraging methods that return [] when empty - Move public view from trips/public_show to shared/trips/show (Rails conventions) - Refactor trips#update to be HTML-only (remove JSON responses) - Convert sharing form to use proper Rails form helpers - Move JS controller to shared/ subdirectory with proper namespacing - Create RSpec shared examples for Shareable concern to eliminate duplication - Update request specs to match HTML-only controller behavior - Apply 'render/redirect ... and return' pattern for early returns
2025-11-07 07:05:34 -05:00
<%= form_with model: trip, url: trip_path(trip), method: :patch, data: { turbo: false } do |f| %>
Implement public trip sharing with Shareable concern This commit implements comprehensive public trip sharing functionality by extracting sharing logic into a reusable Shareable concern and extending it to Trip models. ## Key Features **Shareable Concern (DRY principle)** - Extract sharing logic from Stat model into reusable concern - Support for time-based expiration (1h, 12h, 24h, permanent) - UUID-based secure public access - User-controlled sharing of notes and photos - Automatic UUID generation on model creation **Database Changes** - Add sharing_uuid (UUID) column to trips table - Add sharing_settings (JSONB) column for configuration storage - Add unique index on sharing_uuid for performance **Public Trip Sharing** - Public-facing trip view with read-only access - Interactive map with trip route visualization - Optional sharing of notes and photo previews - Branded footer with Dawarich attribution - Responsive design matching existing UI patterns **Sharing Management** - In-app sharing controls in trip show view - Enable/disable sharing with one click - Configurable expiration times - Copy-to-clipboard for sharing URLs - Visual indicators for sharing status **Authorization & Security** - TripPolicy for fine-grained access control - Public access only for explicitly shared trips - Automatic expiration enforcement - Owner-only sharing management - UUID-based URLs prevent enumeration attacks **API & Routes** - GET /shared/trips/:trip_uuid for public access - PATCH /trips/:id/sharing for sharing management - RESTful endpoint design consistent with stats sharing **Frontend** - New public-trip-map Stimulus controller - OpenStreetMap tiles for public viewing (no API key required) - Start/end markers on trip route - Automatic map bounds fitting **Tests** - Comprehensive concern specs (Shareable) - Model specs for Trip sharing functionality - Request specs for public and authenticated access - Policy specs for authorization rules - 100% coverage of sharing functionality ## Implementation Details ### Models Updated - Stat: Now uses Shareable concern (removed duplicate code) - Trip: Includes Shareable concern with notes/photos options ### Controllers Added - Shared::TripsController: Handles public viewing and sharing management ### Views Added - trips/public_show.html.erb: Public-facing trip view - trips/_sharing.html.erb: Sharing controls partial ### JavaScript Added - public_trip_map_controller.js: Map rendering for public trips ### Helpers Extended - TripsHelper: Added sharing status and expiration helpers ## Breaking Changes None. This is a purely additive feature. ## Migration Required Yes. Run: rails db:migrate ## Testing All specs pass: - spec/models/concerns/shareable_spec.rb - spec/models/trip_spec.rb - spec/requests/shared/trips_spec.rb - spec/policies/trip_policy_spec.rb
2025-11-05 10:44:27 -05:00
<% if trip.sharing_enabled? %>
<!-- Sharing is enabled -->
<div class="space-y-4">
<!-- Sharing Status -->
<div class="alert <%= trip.sharing_expired? ? 'alert-warning' : 'alert-success' %>">
UI: Improve trip sharing modal structure and UX - Add icon to modal title for better visual hierarchy - Restructure sharing status alerts with descriptive headers - Show 'What's being shared' section with checkmarks/crosses - Add prominent sharing link with improved copy button (shows 'Copied' feedback) - Include privacy protection notice with detailed bullet points - Improve enable sharing form with better labels and descriptions - Add 'Always included' information for transparency - Better button layout and actions (Cancel, Done, etc.) - Follow stats sharing modal UX patterns for consistency - Improve spacing and visual organization throughout
2025-11-07 07:34:04 -05:00
<% if trip.sharing_expired? %>
<svg xmlns="http://www.w3.org/2000/svg" class="stroke-current flex-shrink-0 h-6 w-6" fill="none" viewBox="0 0 24 24"><path stroke-linecap="round" stroke-linejoin="round" stroke-width="2" d="M12 9v2m0 4h.01m-6.938 4h13.856c1.54 0 2.502-1.667 1.732-3L13.732 4c-.77-1.333-2.694-1.333-3.464 0L3.34 16c-.77 1.333.192 3 1.732 3z" /></svg>
<div>
<h3 class="font-bold">Link Expired</h3>
<p class="text-sm">This share link has expired and is no longer accessible</p>
</div>
<% else %>
<svg xmlns="http://www.w3.org/2000/svg" class="stroke-current flex-shrink-0 h-6 w-6" fill="none" viewBox="0 0 24 24"><path stroke-linecap="round" stroke-linejoin="round" stroke-width="2" d="M9 12l2 2 4-4m6 2a9 9 0 11-18 0 9 9 0 0118 0z" /></svg>
<div>
<h3 class="font-bold">Sharing Active</h3>
<p class="text-sm">This trip is publicly accessible via the link below</p>
</div>
<% end %>
Implement public trip sharing with Shareable concern This commit implements comprehensive public trip sharing functionality by extracting sharing logic into a reusable Shareable concern and extending it to Trip models. ## Key Features **Shareable Concern (DRY principle)** - Extract sharing logic from Stat model into reusable concern - Support for time-based expiration (1h, 12h, 24h, permanent) - UUID-based secure public access - User-controlled sharing of notes and photos - Automatic UUID generation on model creation **Database Changes** - Add sharing_uuid (UUID) column to trips table - Add sharing_settings (JSONB) column for configuration storage - Add unique index on sharing_uuid for performance **Public Trip Sharing** - Public-facing trip view with read-only access - Interactive map with trip route visualization - Optional sharing of notes and photo previews - Branded footer with Dawarich attribution - Responsive design matching existing UI patterns **Sharing Management** - In-app sharing controls in trip show view - Enable/disable sharing with one click - Configurable expiration times - Copy-to-clipboard for sharing URLs - Visual indicators for sharing status **Authorization & Security** - TripPolicy for fine-grained access control - Public access only for explicitly shared trips - Automatic expiration enforcement - Owner-only sharing management - UUID-based URLs prevent enumeration attacks **API & Routes** - GET /shared/trips/:trip_uuid for public access - PATCH /trips/:id/sharing for sharing management - RESTful endpoint design consistent with stats sharing **Frontend** - New public-trip-map Stimulus controller - OpenStreetMap tiles for public viewing (no API key required) - Start/end markers on trip route - Automatic map bounds fitting **Tests** - Comprehensive concern specs (Shareable) - Model specs for Trip sharing functionality - Request specs for public and authenticated access - Policy specs for authorization rules - 100% coverage of sharing functionality ## Implementation Details ### Models Updated - Stat: Now uses Shareable concern (removed duplicate code) - Trip: Includes Shareable concern with notes/photos options ### Controllers Added - Shared::TripsController: Handles public viewing and sharing management ### Views Added - trips/public_show.html.erb: Public-facing trip view - trips/_sharing.html.erb: Sharing controls partial ### JavaScript Added - public_trip_map_controller.js: Map rendering for public trips ### Helpers Extended - TripsHelper: Added sharing status and expiration helpers ## Breaking Changes None. This is a purely additive feature. ## Migration Required Yes. Run: rails db:migrate ## Testing All specs pass: - spec/models/concerns/shareable_spec.rb - spec/models/trip_spec.rb - spec/requests/shared/trips_spec.rb - spec/policies/trip_policy_spec.rb
2025-11-05 10:44:27 -05:00
</div>
<!-- Sharing URL -->
<div class="form-control">
<label class="label">
UI: Improve trip sharing modal structure and UX - Add icon to modal title for better visual hierarchy - Restructure sharing status alerts with descriptive headers - Show 'What's being shared' section with checkmarks/crosses - Add prominent sharing link with improved copy button (shows 'Copied' feedback) - Include privacy protection notice with detailed bullet points - Improve enable sharing form with better labels and descriptions - Add 'Always included' information for transparency - Better button layout and actions (Cancel, Done, etc.) - Follow stats sharing modal UX patterns for consistency - Improve spacing and visual organization throughout
2025-11-07 07:34:04 -05:00
<span class="label-text font-medium">Sharing link</span>
Implement public trip sharing with Shareable concern This commit implements comprehensive public trip sharing functionality by extracting sharing logic into a reusable Shareable concern and extending it to Trip models. ## Key Features **Shareable Concern (DRY principle)** - Extract sharing logic from Stat model into reusable concern - Support for time-based expiration (1h, 12h, 24h, permanent) - UUID-based secure public access - User-controlled sharing of notes and photos - Automatic UUID generation on model creation **Database Changes** - Add sharing_uuid (UUID) column to trips table - Add sharing_settings (JSONB) column for configuration storage - Add unique index on sharing_uuid for performance **Public Trip Sharing** - Public-facing trip view with read-only access - Interactive map with trip route visualization - Optional sharing of notes and photo previews - Branded footer with Dawarich attribution - Responsive design matching existing UI patterns **Sharing Management** - In-app sharing controls in trip show view - Enable/disable sharing with one click - Configurable expiration times - Copy-to-clipboard for sharing URLs - Visual indicators for sharing status **Authorization & Security** - TripPolicy for fine-grained access control - Public access only for explicitly shared trips - Automatic expiration enforcement - Owner-only sharing management - UUID-based URLs prevent enumeration attacks **API & Routes** - GET /shared/trips/:trip_uuid for public access - PATCH /trips/:id/sharing for sharing management - RESTful endpoint design consistent with stats sharing **Frontend** - New public-trip-map Stimulus controller - OpenStreetMap tiles for public viewing (no API key required) - Start/end markers on trip route - Automatic map bounds fitting **Tests** - Comprehensive concern specs (Shareable) - Model specs for Trip sharing functionality - Request specs for public and authenticated access - Policy specs for authorization rules - 100% coverage of sharing functionality ## Implementation Details ### Models Updated - Stat: Now uses Shareable concern (removed duplicate code) - Trip: Includes Shareable concern with notes/photos options ### Controllers Added - Shared::TripsController: Handles public viewing and sharing management ### Views Added - trips/public_show.html.erb: Public-facing trip view - trips/_sharing.html.erb: Sharing controls partial ### JavaScript Added - public_trip_map_controller.js: Map rendering for public trips ### Helpers Extended - TripsHelper: Added sharing status and expiration helpers ## Breaking Changes None. This is a purely additive feature. ## Migration Required Yes. Run: rails db:migrate ## Testing All specs pass: - spec/models/concerns/shareable_spec.rb - spec/models/trip_spec.rb - spec/requests/shared/trips_spec.rb - spec/policies/trip_policy_spec.rb
2025-11-05 10:44:27 -05:00
</label>
UI: Improve trip sharing modal structure and UX - Add icon to modal title for better visual hierarchy - Restructure sharing status alerts with descriptive headers - Show 'What's being shared' section with checkmarks/crosses - Add prominent sharing link with improved copy button (shows 'Copied' feedback) - Include privacy protection notice with detailed bullet points - Improve enable sharing form with better labels and descriptions - Add 'Always included' information for transparency - Better button layout and actions (Cancel, Done, etc.) - Follow stats sharing modal UX patterns for consistency - Improve spacing and visual organization throughout
2025-11-07 07:34:04 -05:00
<div class="join w-full">
Implement public trip sharing with Shareable concern This commit implements comprehensive public trip sharing functionality by extracting sharing logic into a reusable Shareable concern and extending it to Trip models. ## Key Features **Shareable Concern (DRY principle)** - Extract sharing logic from Stat model into reusable concern - Support for time-based expiration (1h, 12h, 24h, permanent) - UUID-based secure public access - User-controlled sharing of notes and photos - Automatic UUID generation on model creation **Database Changes** - Add sharing_uuid (UUID) column to trips table - Add sharing_settings (JSONB) column for configuration storage - Add unique index on sharing_uuid for performance **Public Trip Sharing** - Public-facing trip view with read-only access - Interactive map with trip route visualization - Optional sharing of notes and photo previews - Branded footer with Dawarich attribution - Responsive design matching existing UI patterns **Sharing Management** - In-app sharing controls in trip show view - Enable/disable sharing with one click - Configurable expiration times - Copy-to-clipboard for sharing URLs - Visual indicators for sharing status **Authorization & Security** - TripPolicy for fine-grained access control - Public access only for explicitly shared trips - Automatic expiration enforcement - Owner-only sharing management - UUID-based URLs prevent enumeration attacks **API & Routes** - GET /shared/trips/:trip_uuid for public access - PATCH /trips/:id/sharing for sharing management - RESTful endpoint design consistent with stats sharing **Frontend** - New public-trip-map Stimulus controller - OpenStreetMap tiles for public viewing (no API key required) - Start/end markers on trip route - Automatic map bounds fitting **Tests** - Comprehensive concern specs (Shareable) - Model specs for Trip sharing functionality - Request specs for public and authenticated access - Policy specs for authorization rules - 100% coverage of sharing functionality ## Implementation Details ### Models Updated - Stat: Now uses Shareable concern (removed duplicate code) - Trip: Includes Shareable concern with notes/photos options ### Controllers Added - Shared::TripsController: Handles public viewing and sharing management ### Views Added - trips/public_show.html.erb: Public-facing trip view - trips/_sharing.html.erb: Sharing controls partial ### JavaScript Added - public_trip_map_controller.js: Map rendering for public trips ### Helpers Extended - TripsHelper: Added sharing status and expiration helpers ## Breaking Changes None. This is a purely additive feature. ## Migration Required Yes. Run: rails db:migrate ## Testing All specs pass: - spec/models/concerns/shareable_spec.rb - spec/models/trip_spec.rb - spec/requests/shared/trips_spec.rb - spec/policies/trip_policy_spec.rb
2025-11-05 10:44:27 -05:00
<input
type="text"
value="<%= shared_trip_url(trip.sharing_uuid) %>"
readonly
UI: Improve trip sharing modal structure and UX - Add icon to modal title for better visual hierarchy - Restructure sharing status alerts with descriptive headers - Show 'What's being shared' section with checkmarks/crosses - Add prominent sharing link with improved copy button (shows 'Copied' feedback) - Include privacy protection notice with detailed bullet points - Improve enable sharing form with better labels and descriptions - Add 'Always included' information for transparency - Better button layout and actions (Cancel, Done, etc.) - Follow stats sharing modal UX patterns for consistency - Improve spacing and visual organization throughout
2025-11-07 07:34:04 -05:00
class="input input-bordered join-item flex-1"
Implement public trip sharing with Shareable concern This commit implements comprehensive public trip sharing functionality by extracting sharing logic into a reusable Shareable concern and extending it to Trip models. ## Key Features **Shareable Concern (DRY principle)** - Extract sharing logic from Stat model into reusable concern - Support for time-based expiration (1h, 12h, 24h, permanent) - UUID-based secure public access - User-controlled sharing of notes and photos - Automatic UUID generation on model creation **Database Changes** - Add sharing_uuid (UUID) column to trips table - Add sharing_settings (JSONB) column for configuration storage - Add unique index on sharing_uuid for performance **Public Trip Sharing** - Public-facing trip view with read-only access - Interactive map with trip route visualization - Optional sharing of notes and photo previews - Branded footer with Dawarich attribution - Responsive design matching existing UI patterns **Sharing Management** - In-app sharing controls in trip show view - Enable/disable sharing with one click - Configurable expiration times - Copy-to-clipboard for sharing URLs - Visual indicators for sharing status **Authorization & Security** - TripPolicy for fine-grained access control - Public access only for explicitly shared trips - Automatic expiration enforcement - Owner-only sharing management - UUID-based URLs prevent enumeration attacks **API & Routes** - GET /shared/trips/:trip_uuid for public access - PATCH /trips/:id/sharing for sharing management - RESTful endpoint design consistent with stats sharing **Frontend** - New public-trip-map Stimulus controller - OpenStreetMap tiles for public viewing (no API key required) - Start/end markers on trip route - Automatic map bounds fitting **Tests** - Comprehensive concern specs (Shareable) - Model specs for Trip sharing functionality - Request specs for public and authenticated access - Policy specs for authorization rules - 100% coverage of sharing functionality ## Implementation Details ### Models Updated - Stat: Now uses Shareable concern (removed duplicate code) - Trip: Includes Shareable concern with notes/photos options ### Controllers Added - Shared::TripsController: Handles public viewing and sharing management ### Views Added - trips/public_show.html.erb: Public-facing trip view - trips/_sharing.html.erb: Sharing controls partial ### JavaScript Added - public_trip_map_controller.js: Map rendering for public trips ### Helpers Extended - TripsHelper: Added sharing status and expiration helpers ## Breaking Changes None. This is a purely additive feature. ## Migration Required Yes. Run: rails db:migrate ## Testing All specs pass: - spec/models/concerns/shareable_spec.rb - spec/models/trip_spec.rb - spec/requests/shared/trips_spec.rb - spec/policies/trip_policy_spec.rb
2025-11-05 10:44:27 -05:00
id="sharing-url-<%= trip.id %>">
<button
UI: Move sharing controls to DaisyUI modal - Add Share Trip button under trip dates - Button displays 'Share Trip' or 'Manage Sharing' based on state - Convert sharing partial to use DaisyUI 4 modal dialog - Modal can be closed via X button, backdrop click, or ESC key - All sharing functionality remains intact within modal
2025-11-07 07:30:22 -05:00
type="button"
UI: Improve trip sharing modal structure and UX - Add icon to modal title for better visual hierarchy - Restructure sharing status alerts with descriptive headers - Show 'What's being shared' section with checkmarks/crosses - Add prominent sharing link with improved copy button (shows 'Copied' feedback) - Include privacy protection notice with detailed bullet points - Improve enable sharing form with better labels and descriptions - Add 'Always included' information for transparency - Better button layout and actions (Cancel, Done, etc.) - Follow stats sharing modal UX patterns for consistency - Improve spacing and visual organization throughout
2025-11-07 07:34:04 -05:00
class="btn btn-outline join-item"
Implement public trip sharing with Shareable concern This commit implements comprehensive public trip sharing functionality by extracting sharing logic into a reusable Shareable concern and extending it to Trip models. ## Key Features **Shareable Concern (DRY principle)** - Extract sharing logic from Stat model into reusable concern - Support for time-based expiration (1h, 12h, 24h, permanent) - UUID-based secure public access - User-controlled sharing of notes and photos - Automatic UUID generation on model creation **Database Changes** - Add sharing_uuid (UUID) column to trips table - Add sharing_settings (JSONB) column for configuration storage - Add unique index on sharing_uuid for performance **Public Trip Sharing** - Public-facing trip view with read-only access - Interactive map with trip route visualization - Optional sharing of notes and photo previews - Branded footer with Dawarich attribution - Responsive design matching existing UI patterns **Sharing Management** - In-app sharing controls in trip show view - Enable/disable sharing with one click - Configurable expiration times - Copy-to-clipboard for sharing URLs - Visual indicators for sharing status **Authorization & Security** - TripPolicy for fine-grained access control - Public access only for explicitly shared trips - Automatic expiration enforcement - Owner-only sharing management - UUID-based URLs prevent enumeration attacks **API & Routes** - GET /shared/trips/:trip_uuid for public access - PATCH /trips/:id/sharing for sharing management - RESTful endpoint design consistent with stats sharing **Frontend** - New public-trip-map Stimulus controller - OpenStreetMap tiles for public viewing (no API key required) - Start/end markers on trip route - Automatic map bounds fitting **Tests** - Comprehensive concern specs (Shareable) - Model specs for Trip sharing functionality - Request specs for public and authenticated access - Policy specs for authorization rules - 100% coverage of sharing functionality ## Implementation Details ### Models Updated - Stat: Now uses Shareable concern (removed duplicate code) - Trip: Includes Shareable concern with notes/photos options ### Controllers Added - Shared::TripsController: Handles public viewing and sharing management ### Views Added - trips/public_show.html.erb: Public-facing trip view - trips/_sharing.html.erb: Sharing controls partial ### JavaScript Added - public_trip_map_controller.js: Map rendering for public trips ### Helpers Extended - TripsHelper: Added sharing status and expiration helpers ## Breaking Changes None. This is a purely additive feature. ## Migration Required Yes. Run: rails db:migrate ## Testing All specs pass: - spec/models/concerns/shareable_spec.rb - spec/models/trip_spec.rb - spec/requests/shared/trips_spec.rb - spec/policies/trip_policy_spec.rb
2025-11-05 10:44:27 -05:00
onclick="navigator.clipboard.writeText(document.getElementById('sharing-url-<%= trip.id %>').value).then(() => {
const btn = this;
const original = btn.innerHTML;
UI: Improve trip sharing modal structure and UX - Add icon to modal title for better visual hierarchy - Restructure sharing status alerts with descriptive headers - Show 'What's being shared' section with checkmarks/crosses - Add prominent sharing link with improved copy button (shows 'Copied' feedback) - Include privacy protection notice with detailed bullet points - Improve enable sharing form with better labels and descriptions - Add 'Always included' information for transparency - Better button layout and actions (Cancel, Done, etc.) - Follow stats sharing modal UX patterns for consistency - Improve spacing and visual organization throughout
2025-11-07 07:34:04 -05:00
btn.innerHTML = '<svg xmlns=\"http://www.w3.org/2000/svg\" class=\"h-5 w-5\" viewBox=\"0 0 20 20\" fill=\"currentColor\"><path fill-rule=\"evenodd\" d=\"M16.707 5.293a1 1 0 010 1.414l-8 8a1 1 0 01-1.414 0l-4-4a1 1 0 011.414-1.414L8 12.586l7.293-7.293a1 1 0 011.414 0z\" clip-rule=\"evenodd\" /></svg> Copied';
Implement public trip sharing with Shareable concern This commit implements comprehensive public trip sharing functionality by extracting sharing logic into a reusable Shareable concern and extending it to Trip models. ## Key Features **Shareable Concern (DRY principle)** - Extract sharing logic from Stat model into reusable concern - Support for time-based expiration (1h, 12h, 24h, permanent) - UUID-based secure public access - User-controlled sharing of notes and photos - Automatic UUID generation on model creation **Database Changes** - Add sharing_uuid (UUID) column to trips table - Add sharing_settings (JSONB) column for configuration storage - Add unique index on sharing_uuid for performance **Public Trip Sharing** - Public-facing trip view with read-only access - Interactive map with trip route visualization - Optional sharing of notes and photo previews - Branded footer with Dawarich attribution - Responsive design matching existing UI patterns **Sharing Management** - In-app sharing controls in trip show view - Enable/disable sharing with one click - Configurable expiration times - Copy-to-clipboard for sharing URLs - Visual indicators for sharing status **Authorization & Security** - TripPolicy for fine-grained access control - Public access only for explicitly shared trips - Automatic expiration enforcement - Owner-only sharing management - UUID-based URLs prevent enumeration attacks **API & Routes** - GET /shared/trips/:trip_uuid for public access - PATCH /trips/:id/sharing for sharing management - RESTful endpoint design consistent with stats sharing **Frontend** - New public-trip-map Stimulus controller - OpenStreetMap tiles for public viewing (no API key required) - Start/end markers on trip route - Automatic map bounds fitting **Tests** - Comprehensive concern specs (Shareable) - Model specs for Trip sharing functionality - Request specs for public and authenticated access - Policy specs for authorization rules - 100% coverage of sharing functionality ## Implementation Details ### Models Updated - Stat: Now uses Shareable concern (removed duplicate code) - Trip: Includes Shareable concern with notes/photos options ### Controllers Added - Shared::TripsController: Handles public viewing and sharing management ### Views Added - trips/public_show.html.erb: Public-facing trip view - trips/_sharing.html.erb: Sharing controls partial ### JavaScript Added - public_trip_map_controller.js: Map rendering for public trips ### Helpers Extended - TripsHelper: Added sharing status and expiration helpers ## Breaking Changes None. This is a purely additive feature. ## Migration Required Yes. Run: rails db:migrate ## Testing All specs pass: - spec/models/concerns/shareable_spec.rb - spec/models/trip_spec.rb - spec/requests/shared/trips_spec.rb - spec/policies/trip_policy_spec.rb
2025-11-05 10:44:27 -05:00
setTimeout(() => btn.innerHTML = original, 2000);
})">
UI: Improve trip sharing modal structure and UX - Add icon to modal title for better visual hierarchy - Restructure sharing status alerts with descriptive headers - Show 'What's being shared' section with checkmarks/crosses - Add prominent sharing link with improved copy button (shows 'Copied' feedback) - Include privacy protection notice with detailed bullet points - Improve enable sharing form with better labels and descriptions - Add 'Always included' information for transparency - Better button layout and actions (Cancel, Done, etc.) - Follow stats sharing modal UX patterns for consistency - Improve spacing and visual organization throughout
2025-11-07 07:34:04 -05:00
<svg xmlns="http://www.w3.org/2000/svg" class="h-5 w-5" fill="none" viewBox="0 0 24 24" stroke="currentColor"><path stroke-linecap="round" stroke-linejoin="round" stroke-width="2" d="M8 5H6a2 2 0 00-2 2v12a2 2 0 002 2h10a2 2 0 002-2v-1M8 5a2 2 0 002 2h2a2 2 0 002-2M8 5a2 2 0 012-2h2a2 2 0 012 2m0 0h2a2 2 0 012 2v3m2 4H10m0 0l3-3m-3 3l3 3" /></svg>
Copy
Implement public trip sharing with Shareable concern This commit implements comprehensive public trip sharing functionality by extracting sharing logic into a reusable Shareable concern and extending it to Trip models. ## Key Features **Shareable Concern (DRY principle)** - Extract sharing logic from Stat model into reusable concern - Support for time-based expiration (1h, 12h, 24h, permanent) - UUID-based secure public access - User-controlled sharing of notes and photos - Automatic UUID generation on model creation **Database Changes** - Add sharing_uuid (UUID) column to trips table - Add sharing_settings (JSONB) column for configuration storage - Add unique index on sharing_uuid for performance **Public Trip Sharing** - Public-facing trip view with read-only access - Interactive map with trip route visualization - Optional sharing of notes and photo previews - Branded footer with Dawarich attribution - Responsive design matching existing UI patterns **Sharing Management** - In-app sharing controls in trip show view - Enable/disable sharing with one click - Configurable expiration times - Copy-to-clipboard for sharing URLs - Visual indicators for sharing status **Authorization & Security** - TripPolicy for fine-grained access control - Public access only for explicitly shared trips - Automatic expiration enforcement - Owner-only sharing management - UUID-based URLs prevent enumeration attacks **API & Routes** - GET /shared/trips/:trip_uuid for public access - PATCH /trips/:id/sharing for sharing management - RESTful endpoint design consistent with stats sharing **Frontend** - New public-trip-map Stimulus controller - OpenStreetMap tiles for public viewing (no API key required) - Start/end markers on trip route - Automatic map bounds fitting **Tests** - Comprehensive concern specs (Shareable) - Model specs for Trip sharing functionality - Request specs for public and authenticated access - Policy specs for authorization rules - 100% coverage of sharing functionality ## Implementation Details ### Models Updated - Stat: Now uses Shareable concern (removed duplicate code) - Trip: Includes Shareable concern with notes/photos options ### Controllers Added - Shared::TripsController: Handles public viewing and sharing management ### Views Added - trips/public_show.html.erb: Public-facing trip view - trips/_sharing.html.erb: Sharing controls partial ### JavaScript Added - public_trip_map_controller.js: Map rendering for public trips ### Helpers Extended - TripsHelper: Added sharing status and expiration helpers ## Breaking Changes None. This is a purely additive feature. ## Migration Required Yes. Run: rails db:migrate ## Testing All specs pass: - spec/models/concerns/shareable_spec.rb - spec/models/trip_spec.rb - spec/requests/shared/trips_spec.rb - spec/policies/trip_policy_spec.rb
2025-11-05 10:44:27 -05:00
</button>
</div>
UI: Improve trip sharing modal structure and UX - Add icon to modal title for better visual hierarchy - Restructure sharing status alerts with descriptive headers - Show 'What's being shared' section with checkmarks/crosses - Add prominent sharing link with improved copy button (shows 'Copied' feedback) - Include privacy protection notice with detailed bullet points - Improve enable sharing form with better labels and descriptions - Add 'Always included' information for transparency - Better button layout and actions (Cancel, Done, etc.) - Follow stats sharing modal UX patterns for consistency - Improve spacing and visual organization throughout
2025-11-07 07:34:04 -05:00
<div class="label">
<span class="label-text-alt">Share this link with others to give them access to your trip</span>
</div>
Implement public trip sharing with Shareable concern This commit implements comprehensive public trip sharing functionality by extracting sharing logic into a reusable Shareable concern and extending it to Trip models. ## Key Features **Shareable Concern (DRY principle)** - Extract sharing logic from Stat model into reusable concern - Support for time-based expiration (1h, 12h, 24h, permanent) - UUID-based secure public access - User-controlled sharing of notes and photos - Automatic UUID generation on model creation **Database Changes** - Add sharing_uuid (UUID) column to trips table - Add sharing_settings (JSONB) column for configuration storage - Add unique index on sharing_uuid for performance **Public Trip Sharing** - Public-facing trip view with read-only access - Interactive map with trip route visualization - Optional sharing of notes and photo previews - Branded footer with Dawarich attribution - Responsive design matching existing UI patterns **Sharing Management** - In-app sharing controls in trip show view - Enable/disable sharing with one click - Configurable expiration times - Copy-to-clipboard for sharing URLs - Visual indicators for sharing status **Authorization & Security** - TripPolicy for fine-grained access control - Public access only for explicitly shared trips - Automatic expiration enforcement - Owner-only sharing management - UUID-based URLs prevent enumeration attacks **API & Routes** - GET /shared/trips/:trip_uuid for public access - PATCH /trips/:id/sharing for sharing management - RESTful endpoint design consistent with stats sharing **Frontend** - New public-trip-map Stimulus controller - OpenStreetMap tiles for public viewing (no API key required) - Start/end markers on trip route - Automatic map bounds fitting **Tests** - Comprehensive concern specs (Shareable) - Model specs for Trip sharing functionality - Request specs for public and authenticated access - Policy specs for authorization rules - 100% coverage of sharing functionality ## Implementation Details ### Models Updated - Stat: Now uses Shareable concern (removed duplicate code) - Trip: Includes Shareable concern with notes/photos options ### Controllers Added - Shared::TripsController: Handles public viewing and sharing management ### Views Added - trips/public_show.html.erb: Public-facing trip view - trips/_sharing.html.erb: Sharing controls partial ### JavaScript Added - public_trip_map_controller.js: Map rendering for public trips ### Helpers Extended - TripsHelper: Added sharing status and expiration helpers ## Breaking Changes None. This is a purely additive feature. ## Migration Required Yes. Run: rails db:migrate ## Testing All specs pass: - spec/models/concerns/shareable_spec.rb - spec/models/trip_spec.rb - spec/requests/shared/trips_spec.rb - spec/policies/trip_policy_spec.rb
2025-11-05 10:44:27 -05:00
</div>
Add 'View Public Page' button to sharing modal - Add prominent button to view the public shared trip page - Opens in new tab with external link icon - Positioned between sharing link and sharing options - Makes it clear where the sharing link leads
2025-11-07 07:37:01 -05:00
<!-- View Public Page Button -->
<div class="flex justify-center">
<%= link_to shared_trip_path(trip.sharing_uuid), target: '_blank', class: 'btn btn-outline btn-primary gap-2' do %>
<svg xmlns="http://www.w3.org/2000/svg" class="h-5 w-5" fill="none" viewBox="0 0 24 24" stroke="currentColor">
<path stroke-linecap="round" stroke-linejoin="round" stroke-width="2" d="M10 6H6a2 2 0 00-2 2v10a2 2 0 002 2h10a2 2 0 002-2v-4M14 4h6m0 0v6m0-6L10 14" />
</svg>
View Public Page
<% end %>
</div>
UI: Improve trip sharing modal structure and UX - Add icon to modal title for better visual hierarchy - Restructure sharing status alerts with descriptive headers - Show 'What's being shared' section with checkmarks/crosses - Add prominent sharing link with improved copy button (shows 'Copied' feedback) - Include privacy protection notice with detailed bullet points - Improve enable sharing form with better labels and descriptions - Add 'Always included' information for transparency - Better button layout and actions (Cancel, Done, etc.) - Follow stats sharing modal UX patterns for consistency - Improve spacing and visual organization throughout
2025-11-07 07:34:04 -05:00
<!-- Current Sharing Options Display -->
<div class="card bg-base-200">
<div class="card-body p-4">
<h4 class="font-semibold mb-2">What's being shared:</h4>
<div class="grid grid-cols-1 md:grid-cols-2 gap-3">
<div class="flex items-center gap-2">
<% if trip.share_notes? %>
<svg xmlns="http://www.w3.org/2000/svg" class="h-5 w-5 text-success" viewBox="0 0 20 20" fill="currentColor"><path fill-rule="evenodd" d="M16.707 5.293a1 1 0 010 1.414l-8 8a1 1 0 01-1.414 0l-4-4a1 1 0 011.414-1.414L8 12.586l7.293-7.293a1 1 0 011.414 0z" clip-rule="evenodd" /></svg>
<% else %>
<svg xmlns="http://www.w3.org/2000/svg" class="h-5 w-5 text-base-content/30" viewBox="0 0 20 20" fill="currentColor"><path fill-rule="evenodd" d="M4.293 4.293a1 1 0 011.414 0L10 8.586l4.293-4.293a1 1 0 111.414 1.414L11.414 10l4.293 4.293a1 1 0 01-1.414 1.414L10 11.414l-4.293 4.293a1 1 0 01-1.414-1.414L8.586 10 4.293 5.707a1 1 0 010-1.414z" clip-rule="evenodd" /></svg>
<% end %>
<span class="<%= trip.share_notes? ? 'text-base-content' : 'text-base-content/50' %>">Trip notes</span>
</div>
<div class="flex items-center gap-2">
<% if trip.share_photos? %>
<svg xmlns="http://www.w3.org/2000/svg" class="h-5 w-5 text-success" viewBox="0 0 20 20" fill="currentColor"><path fill-rule="evenodd" d="M16.707 5.293a1 1 0 010 1.414l-8 8a1 1 0 01-1.414 0l-4-4a1 1 0 011.414-1.414L8 12.586l7.293-7.293a1 1 0 011.414 0z" clip-rule="evenodd" /></svg>
<% else %>
<svg xmlns="http://www.w3.org/2000/svg" class="h-5 w-5 text-base-content/30" viewBox="0 0 20 20" fill="currentColor"><path fill-rule="evenodd" d="M4.293 4.293a1 1 0 011.414 0L10 8.586l4.293-4.293a1 1 0 111.414 1.414L11.414 10l4.293 4.293a1 1 0 01-1.414 1.414L10 11.414l-4.293 4.293a1 1 0 01-1.414-1.414L8.586 10 4.293 5.707a1 1 0 010-1.414z" clip-rule="evenodd" /></svg>
<% end %>
<span class="<%= trip.share_photos? ? 'text-base-content' : 'text-base-content/50' %>">Photos</span>
</div>
</div>
<div class="text-xs text-base-content/60 mt-2">
Always included: Trip name, dates, route map, distance, and countries visited
</div>
Implement public trip sharing with Shareable concern This commit implements comprehensive public trip sharing functionality by extracting sharing logic into a reusable Shareable concern and extending it to Trip models. ## Key Features **Shareable Concern (DRY principle)** - Extract sharing logic from Stat model into reusable concern - Support for time-based expiration (1h, 12h, 24h, permanent) - UUID-based secure public access - User-controlled sharing of notes and photos - Automatic UUID generation on model creation **Database Changes** - Add sharing_uuid (UUID) column to trips table - Add sharing_settings (JSONB) column for configuration storage - Add unique index on sharing_uuid for performance **Public Trip Sharing** - Public-facing trip view with read-only access - Interactive map with trip route visualization - Optional sharing of notes and photo previews - Branded footer with Dawarich attribution - Responsive design matching existing UI patterns **Sharing Management** - In-app sharing controls in trip show view - Enable/disable sharing with one click - Configurable expiration times - Copy-to-clipboard for sharing URLs - Visual indicators for sharing status **Authorization & Security** - TripPolicy for fine-grained access control - Public access only for explicitly shared trips - Automatic expiration enforcement - Owner-only sharing management - UUID-based URLs prevent enumeration attacks **API & Routes** - GET /shared/trips/:trip_uuid for public access - PATCH /trips/:id/sharing for sharing management - RESTful endpoint design consistent with stats sharing **Frontend** - New public-trip-map Stimulus controller - OpenStreetMap tiles for public viewing (no API key required) - Start/end markers on trip route - Automatic map bounds fitting **Tests** - Comprehensive concern specs (Shareable) - Model specs for Trip sharing functionality - Request specs for public and authenticated access - Policy specs for authorization rules - 100% coverage of sharing functionality ## Implementation Details ### Models Updated - Stat: Now uses Shareable concern (removed duplicate code) - Trip: Includes Shareable concern with notes/photos options ### Controllers Added - Shared::TripsController: Handles public viewing and sharing management ### Views Added - trips/public_show.html.erb: Public-facing trip view - trips/_sharing.html.erb: Sharing controls partial ### JavaScript Added - public_trip_map_controller.js: Map rendering for public trips ### Helpers Extended - TripsHelper: Added sharing status and expiration helpers ## Breaking Changes None. This is a purely additive feature. ## Migration Required Yes. Run: rails db:migrate ## Testing All specs pass: - spec/models/concerns/shareable_spec.rb - spec/models/trip_spec.rb - spec/requests/shared/trips_spec.rb - spec/policies/trip_policy_spec.rb
2025-11-05 10:44:27 -05:00
</div>
UI: Improve trip sharing modal structure and UX - Add icon to modal title for better visual hierarchy - Restructure sharing status alerts with descriptive headers - Show 'What's being shared' section with checkmarks/crosses - Add prominent sharing link with improved copy button (shows 'Copied' feedback) - Include privacy protection notice with detailed bullet points - Improve enable sharing form with better labels and descriptions - Add 'Always included' information for transparency - Better button layout and actions (Cancel, Done, etc.) - Follow stats sharing modal UX patterns for consistency - Improve spacing and visual organization throughout
2025-11-07 07:34:04 -05:00
</div>
<!-- Privacy Notice -->
<div class="alert alert-info">
<svg xmlns="http://www.w3.org/2000/svg" class="stroke-current flex-shrink-0 h-6 w-6" fill="none" viewBox="0 0 24 24"><path stroke-linecap="round" stroke-linejoin="round" stroke-width="2" d="M13 16h-1v-4h-1m1-4h.01M21 12a9 9 0 11-18 0 9 9 0 0118 0z" /></svg>
<div>
<h3 class="font-bold">Privacy Protection</h3>
<div class="text-sm">
• Only selected information is shared<br>
• Personal information and account details are never included<br>
• You can disable sharing at any time
</div>
Implement public trip sharing with Shareable concern This commit implements comprehensive public trip sharing functionality by extracting sharing logic into a reusable Shareable concern and extending it to Trip models. ## Key Features **Shareable Concern (DRY principle)** - Extract sharing logic from Stat model into reusable concern - Support for time-based expiration (1h, 12h, 24h, permanent) - UUID-based secure public access - User-controlled sharing of notes and photos - Automatic UUID generation on model creation **Database Changes** - Add sharing_uuid (UUID) column to trips table - Add sharing_settings (JSONB) column for configuration storage - Add unique index on sharing_uuid for performance **Public Trip Sharing** - Public-facing trip view with read-only access - Interactive map with trip route visualization - Optional sharing of notes and photo previews - Branded footer with Dawarich attribution - Responsive design matching existing UI patterns **Sharing Management** - In-app sharing controls in trip show view - Enable/disable sharing with one click - Configurable expiration times - Copy-to-clipboard for sharing URLs - Visual indicators for sharing status **Authorization & Security** - TripPolicy for fine-grained access control - Public access only for explicitly shared trips - Automatic expiration enforcement - Owner-only sharing management - UUID-based URLs prevent enumeration attacks **API & Routes** - GET /shared/trips/:trip_uuid for public access - PATCH /trips/:id/sharing for sharing management - RESTful endpoint design consistent with stats sharing **Frontend** - New public-trip-map Stimulus controller - OpenStreetMap tiles for public viewing (no API key required) - Start/end markers on trip route - Automatic map bounds fitting **Tests** - Comprehensive concern specs (Shareable) - Model specs for Trip sharing functionality - Request specs for public and authenticated access - Policy specs for authorization rules - 100% coverage of sharing functionality ## Implementation Details ### Models Updated - Stat: Now uses Shareable concern (removed duplicate code) - Trip: Includes Shareable concern with notes/photos options ### Controllers Added - Shared::TripsController: Handles public viewing and sharing management ### Views Added - trips/public_show.html.erb: Public-facing trip view - trips/_sharing.html.erb: Sharing controls partial ### JavaScript Added - public_trip_map_controller.js: Map rendering for public trips ### Helpers Extended - TripsHelper: Added sharing status and expiration helpers ## Breaking Changes None. This is a purely additive feature. ## Migration Required Yes. Run: rails db:migrate ## Testing All specs pass: - spec/models/concerns/shareable_spec.rb - spec/models/trip_spec.rb - spec/requests/shared/trips_spec.rb - spec/policies/trip_policy_spec.rb
2025-11-05 10:44:27 -05:00
</div>
</div>
<!-- Action Buttons -->
UI: Improve trip sharing modal structure and UX - Add icon to modal title for better visual hierarchy - Restructure sharing status alerts with descriptive headers - Show 'What's being shared' section with checkmarks/crosses - Add prominent sharing link with improved copy button (shows 'Copied' feedback) - Include privacy protection notice with detailed bullet points - Improve enable sharing form with better labels and descriptions - Add 'Always included' information for transparency - Better button layout and actions (Cancel, Done, etc.) - Follow stats sharing modal UX patterns for consistency - Improve spacing and visual organization throughout
2025-11-07 07:34:04 -05:00
<div class="modal-action">
Fix: Correct form parameter nesting for sharing settings - Replace form builder methods with tag helpers (select_tag, check_box_tag, etc.) - Fixes malformed parameters where brackets were treated as field names - Now generates correct nested params: sharing[enabled], sharing[expiration], etc. - Resolves issue where params were nested incorrectly under trip model
2025-11-07 07:43:13 -05:00
<%= submit_tag "Disable Sharing",
Refactor: Nest sharing parameters under trip key - Follow Rails conventions by nesting sharing params under resource key - Update form fields: sharing[enabled] → trip[sharing][enabled] - Update controller to access params[:trip][:sharing] - Update all request specs to use nested parameters - Parameters now properly structured as trip[sharing][expiration], etc.
2025-11-07 07:50:39 -05:00
name: 'trip[sharing][enabled]',
Fix: Correct form parameter nesting for sharing settings - Replace form builder methods with tag helpers (select_tag, check_box_tag, etc.) - Fixes malformed parameters where brackets were treated as field names - Now generates correct nested params: sharing[enabled], sharing[expiration], etc. - Resolves issue where params were nested incorrectly under trip model
2025-11-07 07:43:13 -05:00
value: '0',
class: "btn btn-error",
data: { turbo_confirm: "Are you sure you want to disable sharing for this trip?" } %>
UI: Improve trip sharing modal structure and UX - Add icon to modal title for better visual hierarchy - Restructure sharing status alerts with descriptive headers - Show 'What's being shared' section with checkmarks/crosses - Add prominent sharing link with improved copy button (shows 'Copied' feedback) - Include privacy protection notice with detailed bullet points - Improve enable sharing form with better labels and descriptions - Add 'Always included' information for transparency - Better button layout and actions (Cancel, Done, etc.) - Follow stats sharing modal UX patterns for consistency - Improve spacing and visual organization throughout
2025-11-07 07:34:04 -05:00
<button type="button" class="btn btn-primary" onclick="sharing_modal_<%= trip.id %>.close()">
Done
</button>
Implement public trip sharing with Shareable concern This commit implements comprehensive public trip sharing functionality by extracting sharing logic into a reusable Shareable concern and extending it to Trip models. ## Key Features **Shareable Concern (DRY principle)** - Extract sharing logic from Stat model into reusable concern - Support for time-based expiration (1h, 12h, 24h, permanent) - UUID-based secure public access - User-controlled sharing of notes and photos - Automatic UUID generation on model creation **Database Changes** - Add sharing_uuid (UUID) column to trips table - Add sharing_settings (JSONB) column for configuration storage - Add unique index on sharing_uuid for performance **Public Trip Sharing** - Public-facing trip view with read-only access - Interactive map with trip route visualization - Optional sharing of notes and photo previews - Branded footer with Dawarich attribution - Responsive design matching existing UI patterns **Sharing Management** - In-app sharing controls in trip show view - Enable/disable sharing with one click - Configurable expiration times - Copy-to-clipboard for sharing URLs - Visual indicators for sharing status **Authorization & Security** - TripPolicy for fine-grained access control - Public access only for explicitly shared trips - Automatic expiration enforcement - Owner-only sharing management - UUID-based URLs prevent enumeration attacks **API & Routes** - GET /shared/trips/:trip_uuid for public access - PATCH /trips/:id/sharing for sharing management - RESTful endpoint design consistent with stats sharing **Frontend** - New public-trip-map Stimulus controller - OpenStreetMap tiles for public viewing (no API key required) - Start/end markers on trip route - Automatic map bounds fitting **Tests** - Comprehensive concern specs (Shareable) - Model specs for Trip sharing functionality - Request specs for public and authenticated access - Policy specs for authorization rules - 100% coverage of sharing functionality ## Implementation Details ### Models Updated - Stat: Now uses Shareable concern (removed duplicate code) - Trip: Includes Shareable concern with notes/photos options ### Controllers Added - Shared::TripsController: Handles public viewing and sharing management ### Views Added - trips/public_show.html.erb: Public-facing trip view - trips/_sharing.html.erb: Sharing controls partial ### JavaScript Added - public_trip_map_controller.js: Map rendering for public trips ### Helpers Extended - TripsHelper: Added sharing status and expiration helpers ## Breaking Changes None. This is a purely additive feature. ## Migration Required Yes. Run: rails db:migrate ## Testing All specs pass: - spec/models/concerns/shareable_spec.rb - spec/models/trip_spec.rb - spec/requests/shared/trips_spec.rb - spec/policies/trip_policy_spec.rb
2025-11-05 10:44:27 -05:00
</div>
</div>
<% else %>
UI: Improve trip sharing modal structure and UX - Add icon to modal title for better visual hierarchy - Restructure sharing status alerts with descriptive headers - Show 'What's being shared' section with checkmarks/crosses - Add prominent sharing link with improved copy button (shows 'Copied' feedback) - Include privacy protection notice with detailed bullet points - Improve enable sharing form with better labels and descriptions - Add 'Always included' information for transparency - Better button layout and actions (Cancel, Done, etc.) - Follow stats sharing modal UX patterns for consistency - Improve spacing and visual organization throughout
2025-11-07 07:34:04 -05:00
<!-- Sharing is disabled - Enable form -->
Implement public trip sharing with Shareable concern This commit implements comprehensive public trip sharing functionality by extracting sharing logic into a reusable Shareable concern and extending it to Trip models. ## Key Features **Shareable Concern (DRY principle)** - Extract sharing logic from Stat model into reusable concern - Support for time-based expiration (1h, 12h, 24h, permanent) - UUID-based secure public access - User-controlled sharing of notes and photos - Automatic UUID generation on model creation **Database Changes** - Add sharing_uuid (UUID) column to trips table - Add sharing_settings (JSONB) column for configuration storage - Add unique index on sharing_uuid for performance **Public Trip Sharing** - Public-facing trip view with read-only access - Interactive map with trip route visualization - Optional sharing of notes and photo previews - Branded footer with Dawarich attribution - Responsive design matching existing UI patterns **Sharing Management** - In-app sharing controls in trip show view - Enable/disable sharing with one click - Configurable expiration times - Copy-to-clipboard for sharing URLs - Visual indicators for sharing status **Authorization & Security** - TripPolicy for fine-grained access control - Public access only for explicitly shared trips - Automatic expiration enforcement - Owner-only sharing management - UUID-based URLs prevent enumeration attacks **API & Routes** - GET /shared/trips/:trip_uuid for public access - PATCH /trips/:id/sharing for sharing management - RESTful endpoint design consistent with stats sharing **Frontend** - New public-trip-map Stimulus controller - OpenStreetMap tiles for public viewing (no API key required) - Start/end markers on trip route - Automatic map bounds fitting **Tests** - Comprehensive concern specs (Shareable) - Model specs for Trip sharing functionality - Request specs for public and authenticated access - Policy specs for authorization rules - 100% coverage of sharing functionality ## Implementation Details ### Models Updated - Stat: Now uses Shareable concern (removed duplicate code) - Trip: Includes Shareable concern with notes/photos options ### Controllers Added - Shared::TripsController: Handles public viewing and sharing management ### Views Added - trips/public_show.html.erb: Public-facing trip view - trips/_sharing.html.erb: Sharing controls partial ### JavaScript Added - public_trip_map_controller.js: Map rendering for public trips ### Helpers Extended - TripsHelper: Added sharing status and expiration helpers ## Breaking Changes None. This is a purely additive feature. ## Migration Required Yes. Run: rails db:migrate ## Testing All specs pass: - spec/models/concerns/shareable_spec.rb - spec/models/trip_spec.rb - spec/requests/shared/trips_spec.rb - spec/policies/trip_policy_spec.rb
2025-11-05 10:44:27 -05:00
<div class="space-y-4">
UI: Improve trip sharing modal structure and UX - Add icon to modal title for better visual hierarchy - Restructure sharing status alerts with descriptive headers - Show 'What's being shared' section with checkmarks/crosses - Add prominent sharing link with improved copy button (shows 'Copied' feedback) - Include privacy protection notice with detailed bullet points - Improve enable sharing form with better labels and descriptions - Add 'Always included' information for transparency - Better button layout and actions (Cancel, Done, etc.) - Follow stats sharing modal UX patterns for consistency - Improve spacing and visual organization throughout
2025-11-07 07:34:04 -05:00
<p class="text-base-content/70">
Generate a public link to share this trip with friends, family, or on social media.
</p>
Implement public trip sharing with Shareable concern This commit implements comprehensive public trip sharing functionality by extracting sharing logic into a reusable Shareable concern and extending it to Trip models. ## Key Features **Shareable Concern (DRY principle)** - Extract sharing logic from Stat model into reusable concern - Support for time-based expiration (1h, 12h, 24h, permanent) - UUID-based secure public access - User-controlled sharing of notes and photos - Automatic UUID generation on model creation **Database Changes** - Add sharing_uuid (UUID) column to trips table - Add sharing_settings (JSONB) column for configuration storage - Add unique index on sharing_uuid for performance **Public Trip Sharing** - Public-facing trip view with read-only access - Interactive map with trip route visualization - Optional sharing of notes and photo previews - Branded footer with Dawarich attribution - Responsive design matching existing UI patterns **Sharing Management** - In-app sharing controls in trip show view - Enable/disable sharing with one click - Configurable expiration times - Copy-to-clipboard for sharing URLs - Visual indicators for sharing status **Authorization & Security** - TripPolicy for fine-grained access control - Public access only for explicitly shared trips - Automatic expiration enforcement - Owner-only sharing management - UUID-based URLs prevent enumeration attacks **API & Routes** - GET /shared/trips/:trip_uuid for public access - PATCH /trips/:id/sharing for sharing management - RESTful endpoint design consistent with stats sharing **Frontend** - New public-trip-map Stimulus controller - OpenStreetMap tiles for public viewing (no API key required) - Start/end markers on trip route - Automatic map bounds fitting **Tests** - Comprehensive concern specs (Shareable) - Model specs for Trip sharing functionality - Request specs for public and authenticated access - Policy specs for authorization rules - 100% coverage of sharing functionality ## Implementation Details ### Models Updated - Stat: Now uses Shareable concern (removed duplicate code) - Trip: Includes Shareable concern with notes/photos options ### Controllers Added - Shared::TripsController: Handles public viewing and sharing management ### Views Added - trips/public_show.html.erb: Public-facing trip view - trips/_sharing.html.erb: Sharing controls partial ### JavaScript Added - public_trip_map_controller.js: Map rendering for public trips ### Helpers Extended - TripsHelper: Added sharing status and expiration helpers ## Breaking Changes None. This is a purely additive feature. ## Migration Required Yes. Run: rails db:migrate ## Testing All specs pass: - spec/models/concerns/shareable_spec.rb - spec/models/trip_spec.rb - spec/requests/shared/trips_spec.rb - spec/policies/trip_policy_spec.rb
2025-11-05 10:44:27 -05:00
UI: Improve trip sharing modal structure and UX - Add icon to modal title for better visual hierarchy - Restructure sharing status alerts with descriptive headers - Show 'What's being shared' section with checkmarks/crosses - Add prominent sharing link with improved copy button (shows 'Copied' feedback) - Include privacy protection notice with detailed bullet points - Improve enable sharing form with better labels and descriptions - Add 'Always included' information for transparency - Better button layout and actions (Cancel, Done, etc.) - Follow stats sharing modal UX patterns for consistency - Improve spacing and visual organization throughout
2025-11-07 07:34:04 -05:00
<!-- Sharing Options -->
<div class="card bg-base-200">
<div class="card-body p-4">
<h4 class="font-semibold mb-3">Choose what to share:</h4>
<div class="form-control mb-3">
<label class="label">
<span class="label-text font-medium">Link expiration</span>
</label>
Refactor: Nest sharing parameters under trip key - Follow Rails conventions by nesting sharing params under resource key - Update form fields: sharing[enabled] → trip[sharing][enabled] - Update controller to access params[:trip][:sharing] - Update all request specs to use nested parameters - Parameters now properly structured as trip[sharing][expiration], etc.
2025-11-07 07:50:39 -05:00
<%= select_tag 'trip[sharing][expiration]',
Fix: Correct form parameter nesting for sharing settings - Replace form builder methods with tag helpers (select_tag, check_box_tag, etc.) - Fixes malformed parameters where brackets were treated as field names - Now generates correct nested params: sharing[enabled], sharing[expiration], etc. - Resolves issue where params were nested incorrectly under trip model
2025-11-07 07:43:13 -05:00
options_for_select([
['1 hour', '1h'],
['12 hours', '12h'],
['24 hours', '24h'],
['Never (permanent)', 'permanent']
], '24h'),
class: 'select select-bordered w-full' %>
UI: Improve trip sharing modal structure and UX - Add icon to modal title for better visual hierarchy - Restructure sharing status alerts with descriptive headers - Show 'What's being shared' section with checkmarks/crosses - Add prominent sharing link with improved copy button (shows 'Copied' feedback) - Include privacy protection notice with detailed bullet points - Improve enable sharing form with better labels and descriptions - Add 'Always included' information for transparency - Better button layout and actions (Cancel, Done, etc.) - Follow stats sharing modal UX patterns for consistency - Improve spacing and visual organization throughout
2025-11-07 07:34:04 -05:00
<div class="label">
<span class="label-text-alt">Choose how long the sharing link will remain active</span>
</div>
</div>
<div class="divider my-2"></div>
<div class="grid grid-cols-1 md:grid-cols-2 gap-4">
<div class="form-control">
<label class="label cursor-pointer justify-start gap-3">
Refactor: Nest sharing parameters under trip key - Follow Rails conventions by nesting sharing params under resource key - Update form fields: sharing[enabled] → trip[sharing][enabled] - Update controller to access params[:trip][:sharing] - Update all request specs to use nested parameters - Parameters now properly structured as trip[sharing][expiration], etc.
2025-11-07 07:50:39 -05:00
<%= check_box_tag 'trip[sharing][share_notes]', '1', true, class: 'toggle toggle-primary' %>
UI: Improve trip sharing modal structure and UX - Add icon to modal title for better visual hierarchy - Restructure sharing status alerts with descriptive headers - Show 'What's being shared' section with checkmarks/crosses - Add prominent sharing link with improved copy button (shows 'Copied' feedback) - Include privacy protection notice with detailed bullet points - Improve enable sharing form with better labels and descriptions - Add 'Always included' information for transparency - Better button layout and actions (Cancel, Done, etc.) - Follow stats sharing modal UX patterns for consistency - Improve spacing and visual organization throughout
2025-11-07 07:34:04 -05:00
<div>
<span class="label-text font-medium block">Share trip notes</span>
<span class="label-text-alt text-xs">Include your description and notes</span>
</div>
</label>
</div>
<div class="form-control">
<label class="label cursor-pointer justify-start gap-3">
Refactor: Nest sharing parameters under trip key - Follow Rails conventions by nesting sharing params under resource key - Update form fields: sharing[enabled] → trip[sharing][enabled] - Update controller to access params[:trip][:sharing] - Update all request specs to use nested parameters - Parameters now properly structured as trip[sharing][expiration], etc.
2025-11-07 07:50:39 -05:00
<%= check_box_tag 'trip[sharing][share_photos]', '1', true, class: 'toggle toggle-primary' %>
UI: Improve trip sharing modal structure and UX - Add icon to modal title for better visual hierarchy - Restructure sharing status alerts with descriptive headers - Show 'What's being shared' section with checkmarks/crosses - Add prominent sharing link with improved copy button (shows 'Copied' feedback) - Include privacy protection notice with detailed bullet points - Improve enable sharing form with better labels and descriptions - Add 'Always included' information for transparency - Better button layout and actions (Cancel, Done, etc.) - Follow stats sharing modal UX patterns for consistency - Improve spacing and visual organization throughout
2025-11-07 07:34:04 -05:00
<div>
<span class="label-text font-medium block">Share photos</span>
<span class="label-text-alt text-xs">Include photos from this trip</span>
</div>
</label>
</div>
</div>
<div class="text-xs text-base-content/60 mt-3 p-2 bg-base-100 rounded">
<strong>Always included:</strong> Trip name, dates, route map, distance, and countries visited
</div>
Implement public trip sharing with Shareable concern This commit implements comprehensive public trip sharing functionality by extracting sharing logic into a reusable Shareable concern and extending it to Trip models. ## Key Features **Shareable Concern (DRY principle)** - Extract sharing logic from Stat model into reusable concern - Support for time-based expiration (1h, 12h, 24h, permanent) - UUID-based secure public access - User-controlled sharing of notes and photos - Automatic UUID generation on model creation **Database Changes** - Add sharing_uuid (UUID) column to trips table - Add sharing_settings (JSONB) column for configuration storage - Add unique index on sharing_uuid for performance **Public Trip Sharing** - Public-facing trip view with read-only access - Interactive map with trip route visualization - Optional sharing of notes and photo previews - Branded footer with Dawarich attribution - Responsive design matching existing UI patterns **Sharing Management** - In-app sharing controls in trip show view - Enable/disable sharing with one click - Configurable expiration times - Copy-to-clipboard for sharing URLs - Visual indicators for sharing status **Authorization & Security** - TripPolicy for fine-grained access control - Public access only for explicitly shared trips - Automatic expiration enforcement - Owner-only sharing management - UUID-based URLs prevent enumeration attacks **API & Routes** - GET /shared/trips/:trip_uuid for public access - PATCH /trips/:id/sharing for sharing management - RESTful endpoint design consistent with stats sharing **Frontend** - New public-trip-map Stimulus controller - OpenStreetMap tiles for public viewing (no API key required) - Start/end markers on trip route - Automatic map bounds fitting **Tests** - Comprehensive concern specs (Shareable) - Model specs for Trip sharing functionality - Request specs for public and authenticated access - Policy specs for authorization rules - 100% coverage of sharing functionality ## Implementation Details ### Models Updated - Stat: Now uses Shareable concern (removed duplicate code) - Trip: Includes Shareable concern with notes/photos options ### Controllers Added - Shared::TripsController: Handles public viewing and sharing management ### Views Added - trips/public_show.html.erb: Public-facing trip view - trips/_sharing.html.erb: Sharing controls partial ### JavaScript Added - public_trip_map_controller.js: Map rendering for public trips ### Helpers Extended - TripsHelper: Added sharing status and expiration helpers ## Breaking Changes None. This is a purely additive feature. ## Migration Required Yes. Run: rails db:migrate ## Testing All specs pass: - spec/models/concerns/shareable_spec.rb - spec/models/trip_spec.rb - spec/requests/shared/trips_spec.rb - spec/policies/trip_policy_spec.rb
2025-11-05 10:44:27 -05:00
</div>
UI: Improve trip sharing modal structure and UX - Add icon to modal title for better visual hierarchy - Restructure sharing status alerts with descriptive headers - Show 'What's being shared' section with checkmarks/crosses - Add prominent sharing link with improved copy button (shows 'Copied' feedback) - Include privacy protection notice with detailed bullet points - Improve enable sharing form with better labels and descriptions - Add 'Always included' information for transparency - Better button layout and actions (Cancel, Done, etc.) - Follow stats sharing modal UX patterns for consistency - Improve spacing and visual organization throughout
2025-11-07 07:34:04 -05:00
</div>
<!-- Privacy Notice -->
<div class="alert alert-info">
<svg xmlns="http://www.w3.org/2000/svg" class="stroke-current flex-shrink-0 h-6 w-6" fill="none" viewBox="0 0 24 24"><path stroke-linecap="round" stroke-linejoin="round" stroke-width="2" d="M13 16h-1v-4h-1m1-4h.01M21 12a9 9 0 11-18 0 9 9 0 0118 0z" /></svg>
<div>
<h3 class="font-bold">Privacy Protection</h3>
<div class="text-sm">
• Only selected information will be shared<br>
• Personal information and account details are never included<br>
• You can disable sharing at any time
</div>
Implement public trip sharing with Shareable concern This commit implements comprehensive public trip sharing functionality by extracting sharing logic into a reusable Shareable concern and extending it to Trip models. ## Key Features **Shareable Concern (DRY principle)** - Extract sharing logic from Stat model into reusable concern - Support for time-based expiration (1h, 12h, 24h, permanent) - UUID-based secure public access - User-controlled sharing of notes and photos - Automatic UUID generation on model creation **Database Changes** - Add sharing_uuid (UUID) column to trips table - Add sharing_settings (JSONB) column for configuration storage - Add unique index on sharing_uuid for performance **Public Trip Sharing** - Public-facing trip view with read-only access - Interactive map with trip route visualization - Optional sharing of notes and photo previews - Branded footer with Dawarich attribution - Responsive design matching existing UI patterns **Sharing Management** - In-app sharing controls in trip show view - Enable/disable sharing with one click - Configurable expiration times - Copy-to-clipboard for sharing URLs - Visual indicators for sharing status **Authorization & Security** - TripPolicy for fine-grained access control - Public access only for explicitly shared trips - Automatic expiration enforcement - Owner-only sharing management - UUID-based URLs prevent enumeration attacks **API & Routes** - GET /shared/trips/:trip_uuid for public access - PATCH /trips/:id/sharing for sharing management - RESTful endpoint design consistent with stats sharing **Frontend** - New public-trip-map Stimulus controller - OpenStreetMap tiles for public viewing (no API key required) - Start/end markers on trip route - Automatic map bounds fitting **Tests** - Comprehensive concern specs (Shareable) - Model specs for Trip sharing functionality - Request specs for public and authenticated access - Policy specs for authorization rules - 100% coverage of sharing functionality ## Implementation Details ### Models Updated - Stat: Now uses Shareable concern (removed duplicate code) - Trip: Includes Shareable concern with notes/photos options ### Controllers Added - Shared::TripsController: Handles public viewing and sharing management ### Views Added - trips/public_show.html.erb: Public-facing trip view - trips/_sharing.html.erb: Sharing controls partial ### JavaScript Added - public_trip_map_controller.js: Map rendering for public trips ### Helpers Extended - TripsHelper: Added sharing status and expiration helpers ## Breaking Changes None. This is a purely additive feature. ## Migration Required Yes. Run: rails db:migrate ## Testing All specs pass: - spec/models/concerns/shareable_spec.rb - spec/models/trip_spec.rb - spec/requests/shared/trips_spec.rb - spec/policies/trip_policy_spec.rb
2025-11-05 10:44:27 -05:00
</div>
</div>
UI: Improve trip sharing modal structure and UX - Add icon to modal title for better visual hierarchy - Restructure sharing status alerts with descriptive headers - Show 'What's being shared' section with checkmarks/crosses - Add prominent sharing link with improved copy button (shows 'Copied' feedback) - Include privacy protection notice with detailed bullet points - Improve enable sharing form with better labels and descriptions - Add 'Always included' information for transparency - Better button layout and actions (Cancel, Done, etc.) - Follow stats sharing modal UX patterns for consistency - Improve spacing and visual organization throughout
2025-11-07 07:34:04 -05:00
<!-- Action Buttons -->
Refactor: Nest sharing parameters under trip key - Follow Rails conventions by nesting sharing params under resource key - Update form fields: sharing[enabled] → trip[sharing][enabled] - Update controller to access params[:trip][:sharing] - Update all request specs to use nested parameters - Parameters now properly structured as trip[sharing][expiration], etc.
2025-11-07 07:50:39 -05:00
<%= hidden_field_tag 'trip[sharing][enabled]', '1' %>
UI: Improve trip sharing modal structure and UX - Add icon to modal title for better visual hierarchy - Restructure sharing status alerts with descriptive headers - Show 'What's being shared' section with checkmarks/crosses - Add prominent sharing link with improved copy button (shows 'Copied' feedback) - Include privacy protection notice with detailed bullet points - Improve enable sharing form with better labels and descriptions - Add 'Always included' information for transparency - Better button layout and actions (Cancel, Done, etc.) - Follow stats sharing modal UX patterns for consistency - Improve spacing and visual organization throughout
2025-11-07 07:34:04 -05:00
<div class="modal-action">
<button type="button" class="btn btn-ghost" onclick="sharing_modal_<%= trip.id %>.close()">
Cancel
</button>
Fix: Correct form parameter nesting for sharing settings - Replace form builder methods with tag helpers (select_tag, check_box_tag, etc.) - Fixes malformed parameters where brackets were treated as field names - Now generates correct nested params: sharing[enabled], sharing[expiration], etc. - Resolves issue where params were nested incorrectly under trip model
2025-11-07 07:43:13 -05:00
<%= submit_tag "Enable Sharing", class: "btn btn-primary" %>
UI: Improve trip sharing modal structure and UX - Add icon to modal title for better visual hierarchy - Restructure sharing status alerts with descriptive headers - Show 'What's being shared' section with checkmarks/crosses - Add prominent sharing link with improved copy button (shows 'Copied' feedback) - Include privacy protection notice with detailed bullet points - Improve enable sharing form with better labels and descriptions - Add 'Always included' information for transparency - Better button layout and actions (Cancel, Done, etc.) - Follow stats sharing modal UX patterns for consistency - Improve spacing and visual organization throughout
2025-11-07 07:34:04 -05:00
</div>
Implement public trip sharing with Shareable concern This commit implements comprehensive public trip sharing functionality by extracting sharing logic into a reusable Shareable concern and extending it to Trip models. ## Key Features **Shareable Concern (DRY principle)** - Extract sharing logic from Stat model into reusable concern - Support for time-based expiration (1h, 12h, 24h, permanent) - UUID-based secure public access - User-controlled sharing of notes and photos - Automatic UUID generation on model creation **Database Changes** - Add sharing_uuid (UUID) column to trips table - Add sharing_settings (JSONB) column for configuration storage - Add unique index on sharing_uuid for performance **Public Trip Sharing** - Public-facing trip view with read-only access - Interactive map with trip route visualization - Optional sharing of notes and photo previews - Branded footer with Dawarich attribution - Responsive design matching existing UI patterns **Sharing Management** - In-app sharing controls in trip show view - Enable/disable sharing with one click - Configurable expiration times - Copy-to-clipboard for sharing URLs - Visual indicators for sharing status **Authorization & Security** - TripPolicy for fine-grained access control - Public access only for explicitly shared trips - Automatic expiration enforcement - Owner-only sharing management - UUID-based URLs prevent enumeration attacks **API & Routes** - GET /shared/trips/:trip_uuid for public access - PATCH /trips/:id/sharing for sharing management - RESTful endpoint design consistent with stats sharing **Frontend** - New public-trip-map Stimulus controller - OpenStreetMap tiles for public viewing (no API key required) - Start/end markers on trip route - Automatic map bounds fitting **Tests** - Comprehensive concern specs (Shareable) - Model specs for Trip sharing functionality - Request specs for public and authenticated access - Policy specs for authorization rules - 100% coverage of sharing functionality ## Implementation Details ### Models Updated - Stat: Now uses Shareable concern (removed duplicate code) - Trip: Includes Shareable concern with notes/photos options ### Controllers Added - Shared::TripsController: Handles public viewing and sharing management ### Views Added - trips/public_show.html.erb: Public-facing trip view - trips/_sharing.html.erb: Sharing controls partial ### JavaScript Added - public_trip_map_controller.js: Map rendering for public trips ### Helpers Extended - TripsHelper: Added sharing status and expiration helpers ## Breaking Changes None. This is a purely additive feature. ## Migration Required Yes. Run: rails db:migrate ## Testing All specs pass: - spec/models/concerns/shareable_spec.rb - spec/models/trip_spec.rb - spec/requests/shared/trips_spec.rb - spec/policies/trip_policy_spec.rb
2025-11-05 10:44:27 -05:00
</div>
<% end %>
Refactor: Apply Rails best practices to trip sharing implementation - Remove unused @is_public_view variable from controller - Simplify conditionals by leveraging methods that return [] when empty - Move public view from trips/public_show to shared/trips/show (Rails conventions) - Refactor trips#update to be HTML-only (remove JSON responses) - Convert sharing form to use proper Rails form helpers - Move JS controller to shared/ subdirectory with proper namespacing - Create RSpec shared examples for Shareable concern to eliminate duplication - Update request specs to match HTML-only controller behavior - Apply 'render/redirect ... and return' pattern for early returns
2025-11-07 07:05:34 -05:00
<% end %>
Implement public trip sharing with Shareable concern This commit implements comprehensive public trip sharing functionality by extracting sharing logic into a reusable Shareable concern and extending it to Trip models. ## Key Features **Shareable Concern (DRY principle)** - Extract sharing logic from Stat model into reusable concern - Support for time-based expiration (1h, 12h, 24h, permanent) - UUID-based secure public access - User-controlled sharing of notes and photos - Automatic UUID generation on model creation **Database Changes** - Add sharing_uuid (UUID) column to trips table - Add sharing_settings (JSONB) column for configuration storage - Add unique index on sharing_uuid for performance **Public Trip Sharing** - Public-facing trip view with read-only access - Interactive map with trip route visualization - Optional sharing of notes and photo previews - Branded footer with Dawarich attribution - Responsive design matching existing UI patterns **Sharing Management** - In-app sharing controls in trip show view - Enable/disable sharing with one click - Configurable expiration times - Copy-to-clipboard for sharing URLs - Visual indicators for sharing status **Authorization & Security** - TripPolicy for fine-grained access control - Public access only for explicitly shared trips - Automatic expiration enforcement - Owner-only sharing management - UUID-based URLs prevent enumeration attacks **API & Routes** - GET /shared/trips/:trip_uuid for public access - PATCH /trips/:id/sharing for sharing management - RESTful endpoint design consistent with stats sharing **Frontend** - New public-trip-map Stimulus controller - OpenStreetMap tiles for public viewing (no API key required) - Start/end markers on trip route - Automatic map bounds fitting **Tests** - Comprehensive concern specs (Shareable) - Model specs for Trip sharing functionality - Request specs for public and authenticated access - Policy specs for authorization rules - 100% coverage of sharing functionality ## Implementation Details ### Models Updated - Stat: Now uses Shareable concern (removed duplicate code) - Trip: Includes Shareable concern with notes/photos options ### Controllers Added - Shared::TripsController: Handles public viewing and sharing management ### Views Added - trips/public_show.html.erb: Public-facing trip view - trips/_sharing.html.erb: Sharing controls partial ### JavaScript Added - public_trip_map_controller.js: Map rendering for public trips ### Helpers Extended - TripsHelper: Added sharing status and expiration helpers ## Breaking Changes None. This is a purely additive feature. ## Migration Required Yes. Run: rails db:migrate ## Testing All specs pass: - spec/models/concerns/shareable_spec.rb - spec/models/trip_spec.rb - spec/requests/shared/trips_spec.rb - spec/policies/trip_policy_spec.rb
2025-11-05 10:44:27 -05:00
</div>
UI: Move sharing controls to DaisyUI modal - Add Share Trip button under trip dates - Button displays 'Share Trip' or 'Manage Sharing' based on state - Convert sharing partial to use DaisyUI 4 modal dialog - Modal can be closed via X button, backdrop click, or ESC key - All sharing functionality remains intact within modal
2025-11-07 07:30:22 -05:00
<form method="dialog" class="modal-backdrop">
<button>close</button>
</form>
</dialog>
Reference in a new issue Copy permalink