From 12a53aac20a488abfeec7b8bc4fd81e0be712c52 Mon Sep 17 00:00:00 2001 From: Eugene Burmakin Date: Wed, 2 Jul 2025 21:58:19 +0200 Subject: [PATCH] Don't check for new version in production. --- .app_version | 2 +- CHANGELOG.md | 6 ++++++ app/services/check_app_version.rb | 2 ++ spec/services/check_app_version_spec.rb | 6 ++++++ 4 files changed, 15 insertions(+), 1 deletion(-) diff --git a/.app_version b/.app_version index 25939d35..20f06870 100644 --- a/.app_version +++ b/.app_version @@ -1 +1 @@ -0.29.1 +0.29.2 diff --git a/CHANGELOG.md b/CHANGELOG.md index 8cca7794..3f4347b9 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -4,6 +4,12 @@ All notable changes to this project will be documented in this file. The format is based on [Keep a Changelog](http://keepachangelog.com/) and this project adheres to [Semantic Versioning](http://semver.org/). +# [0.29.2] - UNRELEASED + +## Changed + +- Don't check for new version in production. + # [0.29.1] - 2025-07-02 ## Fixed diff --git a/app/services/check_app_version.rb b/app/services/check_app_version.rb index bb2fd449..9eb3c133 100644 --- a/app/services/check_app_version.rb +++ b/app/services/check_app_version.rb @@ -8,6 +8,8 @@ class CheckAppVersion end def call + return false if Rails.env.production? + latest_version != APP_VERSION rescue StandardError false diff --git a/spec/services/check_app_version_spec.rb b/spec/services/check_app_version_spec.rb index 1e90b3af..5e2600c4 100644 --- a/spec/services/check_app_version_spec.rb +++ b/spec/services/check_app_version_spec.rb @@ -13,6 +13,12 @@ RSpec.describe CheckAppVersion do stub_const('APP_VERSION', '1.0.0') end + context 'when in production' do + before { allow(Rails).to receive(:env).and_return(ActiveSupport::StringInquirer.new('production')) } + + it { is_expected.to be false } + end + context 'when latest version is newer' do before { stub_const('APP_VERSION', '0.9.0') }