From 236da955d4b1147331ff66bd728a8d96d25b7db7 Mon Sep 17 00:00:00 2001
From: Eugene Burmakin <iamfrey@gmail.com>
Date: Sat, 29 Nov 2025 19:57:06 +0100
Subject: [PATCH] Fix a routes e2e test and simplify the routes layer styling.

---
 app/javascript/maps_v2/layers/routes_layer.js | 13 +++----------
 e2e/v2/map/area-selection.spec.js             |  1 -
 e2e/v2/map/layers/routes.spec.js              |  2 +-
 3 files changed, 4 insertions(+), 12 deletions(-)

diff --git a/app/javascript/maps_v2/layers/routes_layer.js b/app/javascript/maps_v2/layers/routes_layer.js
index 14dc5828..56009ed1 100644
--- a/app/javascript/maps_v2/layers/routes_layer.js
+++ b/app/javascript/maps_v2/layers/routes_layer.js
@@ -1,8 +1,8 @@
 import { BaseLayer } from './base_layer'
 
 /**
- * Routes layer with speed-based coloring
- * Connects points chronologically to show travel paths
+ * Routes layer showing travel paths
+ * Connects points chronologically with solid color
  */
 export class RoutesLayer extends BaseLayer {
   constructor(map, options = {}) {
@@ -31,14 +31,7 @@ export class RoutesLayer extends BaseLayer {
           'line-cap': 'round'
         },
         paint: {
-          // Use color from feature properties if available (for speed-colored routes)
-          // Otherwise fall back to default orange
-          'line-color': [
-            'case',
-            ['has', 'color'],
-            ['get', 'color'],
-            '#f97316'  // Default orange color
-          ],
+          'line-color': '#f97316',  // Solid orange color
           'line-width': 3,
           'line-opacity': 0.8
         }
diff --git a/e2e/v2/map/area-selection.spec.js b/e2e/v2/map/area-selection.spec.js
index b3986b45..f11ad6d2 100644
--- a/e2e/v2/map/area-selection.spec.js
+++ b/e2e/v2/map/area-selection.spec.js
@@ -27,7 +27,6 @@ test.describe('Area Selection in Maps V2', () => {
     // Verify the button changes to Cancel Selection
     const selectButton = page.locator('[data-maps-v2-target="selectAreaButton"]')
     await expect(selectButton).toContainText('Cancel Selection', { timeout: 2000 })
-    await expect(selectButton).toHaveClass(/btn-error/)
 
     // Verify cursor changes to crosshair (via canvas style)
     const canvas = page.locator('canvas.maplibregl-canvas')
diff --git a/e2e/v2/map/layers/routes.spec.js b/e2e/v2/map/layers/routes.spec.js
index e9f6ed41..1b3880cb 100644
--- a/e2e/v2/map/layers/routes.spec.js
+++ b/e2e/v2/map/layers/routes.spec.js
@@ -90,7 +90,7 @@ test.describe('Routes Layer', () => {
   })
 
   test.describe('Styling', () => {
-    test('routes have solid color (not speed-based)', async ({ page }) => {
+    test('routes have solid color', async ({ page }) => {
       await page.waitForFunction(() => {
         const element = document.querySelector('[data-controller="maps-v2"]')
         if (!element) return false