Remove console.logs from most of map v2

app/javascript/controllers/maps/maplibre/area_selection_manager.js

@@ -23,8 +23,6 @@ export class AreaSelectionManager {
    * Start area selection mode
    */
   async startSelectArea() {
-    console.log('[Maps V2] Starting area selection mode')
-
     // Initialize selection layer if not exists
     if (!this.selectionLayer) {
       this.selectionLayer = new SelectionLayer(this.map, {
@@ -36,8 +34,6 @@ export class AreaSelectionManager {
         type: 'FeatureCollection',
         features: []
       })
-
-      console.log('[Maps V2] Selection layer initialized')
     }
 
     // Initialize selected points layer if not exists
@@ -50,8 +46,6 @@ export class AreaSelectionManager {
         type: 'FeatureCollection',
         features: []
       })
-
-      console.log('[Maps V2] Selected points layer initialized')
     }
 
     // Enable selection mode
@@ -76,8 +70,6 @@ export class AreaSelectionManager {
    * Handle area selection completion
    */
   async handleAreaSelected(bounds) {
-    console.log('[Maps V2] Area selected:', bounds)
-
     try {
       Toast.info('Fetching data in selected area...')
 
@@ -298,7 +290,6 @@ export class AreaSelectionManager {
       Toast.success('Visit declined')
       await this.refreshSelectedVisits()
     } catch (error) {
-      console.error('[Maps V2] Failed to decline visit:', error)
       Toast.error('Failed to decline visit')
     }
   }
@@ -327,7 +318,6 @@ export class AreaSelectionManager {
       this.replaceVisitsWithMerged(visitIds, mergedVisit)
       this.updateBulkActions()
     } catch (error) {
-      console.error('[Maps V2] Failed to merge visits:', error)
       Toast.error('Failed to merge visits')
     }
   }
@@ -346,7 +336,6 @@ export class AreaSelectionManager {
       this.selectedVisitIds.clear()
       await this.refreshSelectedVisits()
     } catch (error) {
-      console.error('[Maps V2] Failed to confirm visits:', error)
       Toast.error('Failed to confirm visits')
     }
   }
@@ -451,8 +440,6 @@ export class AreaSelectionManager {
    * Cancel area selection
    */
   cancelAreaSelection() {
-    console.log('[Maps V2] Cancelling area selection')
-
     if (this.selectionLayer) {
       this.selectionLayer.disableSelectionMode()
       this.selectionLayer.clearSelection()
@@ -515,14 +502,10 @@ export class AreaSelectionManager {
 
     if (!confirmed) return
 
-    console.log('[Maps V2] Deleting', pointIds.length, 'points')
-
     try {
       Toast.info('Deleting points...')
       const result = await this.api.bulkDeletePoints(pointIds)
 
-      console.log('[Maps V2] Deleted', result.count, 'points')
-
       this.cancelAreaSelection()
 
       await this.controller.loadMapData({

app/javascript/controllers/maps/maplibre/places_manager.js

@@ -216,8 +216,6 @@ export class PlacesManager {
    * Start create place mode
    */
   startCreatePlace() {
-    console.log('[Maps V2] Starting create place mode')
-
     if (this.controller.hasSettingsPanelTarget && this.controller.settingsPanelTarget.classList.contains('open')) {
       this.controller.toggleSettings()
     }
@@ -242,8 +240,6 @@ export class PlacesManager {
    * Handle place creation event - reload places and update layer
    */
   async handlePlaceCreated(event) {
-    console.log('[Maps V2] Place created, reloading places...', event.detail)
-
     try {
       const selectedTags = this.getSelectedPlaceTags()
 
@@ -251,8 +247,6 @@ export class PlacesManager {
         tag_ids: selectedTags
       })
 
-      console.log('[Maps V2] Fetched places:', places.length)
-
       const placesGeoJSON = this.dataLoader.placesToGeoJSON(places)
 
       console.log('[Maps V2] Converted to GeoJSON:', placesGeoJSON.features.length, 'features')
@@ -260,7 +254,6 @@ export class PlacesManager {
       const placesLayer = this.layerManager.getLayer('places')
       if (placesLayer) {
         placesLayer.update(placesGeoJSON)
-        console.log('[Maps V2] Places layer updated successfully')
       } else {
         console.warn('[Maps V2] Places layer not found, cannot update')
       }
@@ -273,9 +266,6 @@ export class PlacesManager {
    * Handle place update event - reload places and update layer
    */
   async handlePlaceUpdated(event) {
-    console.log('[Maps V2] Place updated, reloading places...', event.detail)
-
-    // Reuse the same logic as creation
     await this.handlePlaceCreated(event)
   }
 }

app/javascript/controllers/maps/maplibre/visits_manager.js

@@ -65,8 +65,6 @@ export class VisitsManager {
    * Start create visit mode
    */
   startCreateVisit() {
-    console.log('[Maps V2] Starting create visit mode')
-
     if (this.controller.hasSettingsPanelTarget && this.controller.settingsPanelTarget.classList.contains('open')) {
       this.controller.toggleSettings()
     }
@@ -87,12 +85,9 @@ export class VisitsManager {
    * Open visit creation modal
    */
   openVisitCreationModal(lat, lng) {
-    console.log('[Maps V2] Opening visit creation modal', { lat, lng })
-
     const modalElement = document.querySelector('[data-controller="visit-creation-v2"]')
 
     if (!modalElement) {
-      console.error('[Maps V2] Visit creation modal not found')
       Toast.error('Visit creation modal not available')
       return
     }
@@ -105,7 +100,6 @@ export class VisitsManager {
     if (controller) {
       controller.open(lat, lng, this.controller)
     } else {
-      console.error('[Maps V2] Visit creation controller not found')
       Toast.error('Visit creation controller not available')
     }
   }
@@ -114,8 +108,6 @@ export class VisitsManager {
    * Handle visit creation event - reload visits and update layer
    */
   async handleVisitCreated(event) {
-    console.log('[Maps V2] Visit created, reloading visits...', event.detail)
-
     try {
       const visits = await this.api.fetchVisits({
         start_at: this.controller.startDateValue,
@@ -132,7 +124,6 @@ export class VisitsManager {
       const visitsLayer = this.layerManager.getLayer('visits')
       if (visitsLayer) {
         visitsLayer.update(visitsGeoJSON)
-        console.log('[Maps V2] Visits layer updated successfully')
       } else {
         console.warn('[Maps V2] Visits layer not found, cannot update')
       }
@@ -145,9 +136,6 @@ export class VisitsManager {
    * Handle visit update event - reload visits and update layer
    */
   async handleVisitUpdated(event) {
-    console.log('[Maps V2] Visit updated, reloading visits...', event.detail)
-
-    // Reuse the same logic as creation
     await this.handleVisitCreated(event)
   }
 }

app/javascript/controllers/maps/maplibre_controller.js

@@ -132,7 +132,6 @@ export default class extends Controller {
     // Format initial dates
     this.startDateValue = DateManager.formatDateForAPI(new Date(this.startDateValue))
     this.endDateValue = DateManager.formatDateForAPI(new Date(this.endDateValue))
-    console.log('[Maps V2] Initial dates:', this.startDateValue, 'to', this.endDateValue)
 
     this.loadMapData()
   }
@@ -172,8 +171,6 @@ export default class extends Controller {
 
     this.searchManager = new SearchManager(this.map, this.apiKeyValue)
     this.searchManager.initialize(this.searchInputTarget, this.searchResultsTarget)
-
-    console.log('[Maps V2] Search manager initialized')
   }
 
   /**
@@ -198,7 +195,6 @@ export default class extends Controller {
     this.startDateValue = startDate
     this.endDateValue = endDate
 
-    console.log('[Maps V2] Date range changed:', this.startDateValue, 'to', this.endDateValue)
     this.loadMapData()
   }
 
@@ -267,8 +263,6 @@ export default class extends Controller {
 
   // Area creation
   startCreateArea() {
-    console.log('[Maps V2] Starting create area mode')
-
     if (this.hasSettingsPanelTarget && this.settingsPanelTarget.classList.contains('open')) {
       this.toggleSettings()
     }
@@ -280,37 +274,26 @@ export default class extends Controller {
     )
 
     if (drawerController) {
-      console.log('[Maps V2] Area drawer controller found, starting drawing with map:', this.map)
       drawerController.startDrawing(this.map)
     } else {
-      console.error('[Maps V2] Area drawer controller not found')
       Toast.error('Area drawer controller not available')
     }
   }
 
   async handleAreaCreated(event) {
-    console.log('[Maps V2] Area created:', event.detail.area)
-
     try {
       // Fetch all areas from API
       const areas = await this.api.fetchAreas()
-      console.log('[Maps V2] Fetched areas:', areas.length)
 
       // Convert to GeoJSON
       const areasGeoJSON = this.dataLoader.areasToGeoJSON(areas)
-      console.log('[Maps V2] Converted to GeoJSON:', areasGeoJSON.features.length, 'features')
-      if (areasGeoJSON.features.length > 0) {
-        console.log('[Maps V2] First area GeoJSON:', JSON.stringify(areasGeoJSON.features[0], null, 2))
-      }
 
       // Get or create the areas layer
       let areasLayer = this.layerManager.getLayer('areas')
-      console.log('[Maps V2] Areas layer exists?', !!areasLayer, 'visible?', areasLayer?.visible)
 
       if (areasLayer) {
         // Update existing layer
         areasLayer.update(areasGeoJSON)
-        console.log('[Maps V2] Areas layer updated')
       } else {
         // Create the layer if it doesn't exist yet
         console.log('[Maps V2] Creating areas layer')
@@ -322,7 +305,6 @@ export default class extends Controller {
       // Enable the layer if it wasn't already
       if (areasLayer) {
         if (!areasLayer.visible) {
-          console.log('[Maps V2] Showing areas layer')
           areasLayer.show()
           this.settings.layers.areas = true
           this.settingsController.saveSetting('layers.areas', true)
@@ -338,7 +320,6 @@ export default class extends Controller {
 
       Toast.success('Area created successfully!')
     } catch (error) {
-      console.error('[Maps V2] Failed to reload areas:', error)
       Toast.error('Failed to reload areas')
     }
   }
@@ -369,7 +350,6 @@ export default class extends Controller {
 
       if (!response.ok) {
         if (response.status === 403) {
-          console.warn('[Maps V2] Family feature not enabled or user not in family')
           Toast.info('Family feature not available')
           return
         }
@@ -500,7 +480,6 @@ export default class extends Controller {
     const id = button.dataset.id
     const entityType = button.dataset.entityType
 
-    console.log('[Maps V2] Opening edit for', entityType, id)
 
     switch (entityType) {
       case 'visit':
@@ -522,8 +501,6 @@ export default class extends Controller {
     const id = button.dataset.id
     const entityType = button.dataset.entityType
 
-    console.log('[Maps V2] Deleting', entityType, id)
-
     switch (entityType) {
       case 'area':
         this.deleteArea(id)
@@ -559,7 +536,6 @@ export default class extends Controller {
       })
       document.dispatchEvent(event)
     } catch (error) {
-      console.error('[Maps V2] Failed to load visit:', error)
       Toast.error('Failed to load visit details')
     }
   }
@@ -596,7 +572,6 @@ export default class extends Controller {
 
       Toast.success('Area deleted successfully')
     } catch (error) {
-      console.error('[Maps V2] Failed to delete area:', error)
       Toast.error('Failed to delete area')
     }
   }
@@ -627,7 +602,6 @@ export default class extends Controller {
       })
       document.dispatchEvent(event)
     } catch (error) {
-      console.error('[Maps V2] Failed to load place:', error)
       Toast.error('Failed to load place details')
     }
   }

app/javascript/maps_maplibre/layers/base_layer.js

@@ -16,12 +16,10 @@ export class BaseLayer {
    * @param {Object} data - GeoJSON or layer-specific data
    */
   add(data) {
-    console.log(`[BaseLayer:${this.id}] add() called, visible:`, this.visible, 'features:', data?.features?.length || 0)
     this.data = data
 
     // Add source
     if (!this.map.getSource(this.sourceId)) {
-      console.log(`[BaseLayer:${this.id}] Adding source:`, this.sourceId)
       this.map.addSource(this.sourceId, this.getSourceConfig())
     } else {
       console.log(`[BaseLayer:${this.id}] Source already exists:`, this.sourceId)
@@ -32,7 +30,6 @@ export class BaseLayer {
     console.log(`[BaseLayer:${this.id}] Adding ${layers.length} layer(s)`)
     layers.forEach(layerConfig => {
       if (!this.map.getLayer(layerConfig.id)) {
-        console.log(`[BaseLayer:${this.id}] Adding layer:`, layerConfig.id, 'type:', layerConfig.type)
         this.map.addLayer(layerConfig)
       } else {
         console.log(`[BaseLayer:${this.id}] Layer already exists:`, layerConfig.id)
@@ -40,7 +37,6 @@ export class BaseLayer {
     })
 
     this.setVisibility(this.visible)
-    console.log(`[BaseLayer:${this.id}] Layer added successfully`)
   }
 
   /**