From 379a5d6f1c23cced648d8d23f463769729239d21 Mon Sep 17 00:00:00 2001
From: Eugene Burmakin <iamfrey@gmail.com>
Date: Sun, 11 Jan 2026 12:03:08 +0100
Subject: [PATCH] Remove unused point creation jobs

---
 app/jobs/overland/batch_creating_job.rb       |  9 -----
 app/jobs/owntracks/point_creating_job.rb      |  9 -----
 spec/jobs/overland/batch_creating_job_spec.rb | 32 ---------------
 .../jobs/owntracks/point_creating_job_spec.rb | 40 -------------------
 spec/requests/api/v1/owntracks/points_spec.rb |  2 +-
 5 files changed, 1 insertion(+), 91 deletions(-)
 delete mode 100644 app/jobs/overland/batch_creating_job.rb
 delete mode 100644 app/jobs/owntracks/point_creating_job.rb
 delete mode 100644 spec/jobs/overland/batch_creating_job_spec.rb
 delete mode 100644 spec/jobs/owntracks/point_creating_job_spec.rb

diff --git a/app/jobs/overland/batch_creating_job.rb b/app/jobs/overland/batch_creating_job.rb
deleted file mode 100644
index 5f355a36..00000000
--- a/app/jobs/overland/batch_creating_job.rb
+++ /dev/null
@@ -1,9 +0,0 @@
-# frozen_string_literal: true
-
-class Overland::BatchCreatingJob < ApplicationJob
-  queue_as :points
-
-  def perform(params, user_id)
-    Overland::PointsCreator.new(params, user_id).call
-  end
-end
diff --git a/app/jobs/owntracks/point_creating_job.rb b/app/jobs/owntracks/point_creating_job.rb
deleted file mode 100644
index 45aa669f..00000000
--- a/app/jobs/owntracks/point_creating_job.rb
+++ /dev/null
@@ -1,9 +0,0 @@
-# frozen_string_literal: true
-
-class Owntracks::PointCreatingJob < ApplicationJob
-  queue_as :points
-
-  def perform(point_params, user_id)
-    OwnTracks::PointCreator.new(point_params, user_id).call
-  end
-end
diff --git a/spec/jobs/overland/batch_creating_job_spec.rb b/spec/jobs/overland/batch_creating_job_spec.rb
deleted file mode 100644
index 75446df1..00000000
--- a/spec/jobs/overland/batch_creating_job_spec.rb
+++ /dev/null
@@ -1,32 +0,0 @@
-# frozen_string_literal: true
-
-require 'rails_helper'
-
-RSpec.describe Overland::BatchCreatingJob, type: :job do
-  describe '#perform' do
-    subject(:perform) { described_class.new.perform(json, user.id) }
-
-    let(:file_path) { 'spec/fixtures/files/overland/geodata.json' }
-    let(:file) { File.open(file_path) }
-    let(:json) { JSON.parse(file.read) }
-    let(:user) { create(:user) }
-
-    it 'creates a location' do
-      expect { perform }.to change { Point.count }.by(1)
-    end
-
-    it 'creates a point with the correct user_id' do
-      perform
-
-      expect(Point.last.user_id).to eq(user.id)
-    end
-
-    context 'when point already exists' do
-      it 'does not create a point' do
-        perform
-
-        expect { perform }.not_to(change { Point.count })
-      end
-    end
-  end
-end
diff --git a/spec/jobs/owntracks/point_creating_job_spec.rb b/spec/jobs/owntracks/point_creating_job_spec.rb
deleted file mode 100644
index ae8d49fb..00000000
--- a/spec/jobs/owntracks/point_creating_job_spec.rb
+++ /dev/null
@@ -1,40 +0,0 @@
-# frozen_string_literal: true
-
-require 'rails_helper'
-
-RSpec.describe Owntracks::PointCreatingJob, type: :job do
-  describe '#perform' do
-    subject(:perform) { described_class.new.perform(point_params, user.id) }
-
-    let(:point_params) do
-      { lat: 1.0, lon: 1.0, tid: 'test', tst: Time.now.to_i, topic: 'iPhone 12 pro' }
-    end
-    let(:user) { create(:user) }
-
-    it 'creates a point' do
-      expect { perform }.to change { Point.count }.by(1)
-    end
-
-    it 'creates a point with the correct user_id' do
-      perform
-
-      expect(Point.last.user_id).to eq(user.id)
-    end
-
-    context 'when point already exists' do
-      it 'does not create a point' do
-        perform
-
-        expect { perform }.not_to(change { Point.count })
-      end
-    end
-
-    context 'when point is invalid' do
-      let(:point_params) { { lat: 1.0, lon: 1.0, tid: 'test', tst: nil, topic: 'iPhone 12 pro' } }
-
-      it 'does not create a point' do
-        expect { perform }.not_to(change { Point.count })
-      end
-    end
-  end
-end
diff --git a/spec/requests/api/v1/owntracks/points_spec.rb b/spec/requests/api/v1/owntracks/points_spec.rb
index ccf17e92..104ddd93 100644
--- a/spec/requests/api/v1/owntracks/points_spec.rb
+++ b/spec/requests/api/v1/owntracks/points_spec.rb
@@ -2,7 +2,7 @@
 
 require 'rails_helper'
 
-RSpec.describe 'Api::V1::OwnTracks::Points', type: :request do
+RSpec.describe 'Api::V1::Owntracks::Points', type: :request do
   describe 'POST /api/v1/owntracks/points' do
     let(:file_path) { 'spec/fixtures/files/owntracks/2024-03.rec' }
     let(:json) { OwnTracks::RecParser.new(File.read(file_path)).call }