From 94f6dbe18e0a3cedeaf36f165826b97ba79029da Mon Sep 17 00:00:00 2001
From: Eugene Burmakin <iamfrey@gmail.com>
Date: Wed, 23 Jul 2025 20:27:55 +0200
Subject: [PATCH] Extract timestamp range calculation to separate methods

---
 app/services/tracks/generator.rb | 43 ++++++++++++++++++--------------
 1 file changed, 24 insertions(+), 19 deletions(-)

diff --git a/app/services/tracks/generator.rb b/app/services/tracks/generator.rb
index f4cbb7bf..be22d021 100644
--- a/app/services/tracks/generator.rb
+++ b/app/services/tracks/generator.rb
@@ -184,30 +184,35 @@ class Tracks::Generator
 
   def get_timestamp_range
     case mode
-    when :bulk
-      if start_at && end_at
-        [start_at.to_i, end_at.to_i]
-      else
-        first_point = user.tracked_points.order(:timestamp).first
-        last_point = user.tracked_points.order(:timestamp).last
-
-        [first_point&.timestamp || 0, last_point&.timestamp || Time.current.to_i]
-      end
-    when :daily
-      day = start_at&.to_date || Date.current
-
-      [day.beginning_of_day.to_i, day.end_of_day.to_i]
-    when :incremental
-      # For incremental, we need all untracked points up to end_at
-      first_point = user.tracked_points.where(track_id: nil).order(:timestamp).first
-      end_timestamp = end_at ? end_at.to_i : Time.current.to_i
-
-      [first_point&.timestamp || 0, end_timestamp]
+    when :bulk then bulk_timestamp_range
+    when :daily then daily_timestamp_range
+    when :incremental then incremental_timestamp_range
     else
       raise ArgumentError, "Unknown mode: #{mode}"
     end
   end
 
+  def bulk_timestamp_range
+    return [start_at.to_i, end_at.to_i] if start_at && end_at
+
+    first_point = user.tracked_points.order(:timestamp).first
+    last_point = user.tracked_points.order(:timestamp).last
+
+    [first_point&.timestamp || 0, last_point&.timestamp || Time.current.to_i]
+  end
+
+  def daily_timestamp_range
+    day = start_at&.to_date || Date.current
+    [day.beginning_of_day.to_i, day.end_of_day.to_i]
+  end
+
+  def incremental_timestamp_range
+    first_point = user.tracked_points.where(track_id: nil).order(:timestamp).first
+    end_timestamp = end_at ? end_at.to_i : Time.current.to_i
+
+    [first_point&.timestamp || 0, end_timestamp]
+  end
+
   def distance_threshold_meters
     @distance_threshold_meters ||= user.safe_settings.meters_between_routes.to_i
   end