kevinsivic/dawarich
1
0
Fork 0
mirror of https://github.com/Freika/dawarich.git synced 2026-01-11 09:41:40 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

Sanitize input in distanceable

Browse source
This commit is contained in:
Eugene Burmakin 2025-07-23 20:52:02 +02:00
parent 7920209187
commit 9fb251fa4a
1 changed files with 7 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
app/models/concerns/distanceable.rb
View file

@ -60,10 +60,9 @@ module Distanceable
point_pairs = points.each_cons(2).to_a point_pairs = points.each_cons(2).to_a
return [] if point_pairs.empty? return [] if point_pairs.empty?
# Create parameterized placeholders for VALUES clause # Create parameterized placeholders for VALUES clause using ? placeholders
values_placeholders = point_pairs.map.with_index do |_, index| values_placeholders = point_pairs.map do |_|
base_idx = index * 3 "(?, ST_GeomFromEWKT(?)::geography, ST_GeomFromEWKT(?)::geography)"
"($#{base_idx + 1}, ST_GeomFromEWKT($#{base_idx + 2})::geography, ST_GeomFromEWKT($#{base_idx + 3})::geography)"
end.join(', ') end.join(', ')
# Flatten parameters: [pair_id, lonlat1, lonlat2, pair_id, lonlat1, lonlat2, ...] # Flatten parameters: [pair_id, lonlat1, lonlat2, pair_id, lonlat1, lonlat2, ...]
@ -72,7 +71,7 @@ module Distanceable
end end
# Single query to calculate all distances using parameterized query # Single query to calculate all distances using parameterized query
results = connection.exec_params(<<-SQL.squish, params) sql_with_params = ActiveRecord::Base.sanitize_sql_array([<<-SQL.squish] + params)
WITH point_pairs AS ( WITH point_pairs AS (
SELECT SELECT
pair_id, pair_id,
@ -86,9 +85,11 @@ module Distanceable
FROM point_pairs FROM point_pairs
ORDER BY pair_id ORDER BY pair_id
SQL SQL
results = connection.select_all(sql_with_params)
# Return array of distances in meters # Return array of distances in meters
results.map { |row| row['distance_meters'].to_i } results.map { |row| row['distance_meters'].to_f }
end end
end end