From b364f33db12915210b4400562b6142e0545b5253 Mon Sep 17 00:00:00 2001 From: Eugene Burmakin Date: Wed, 11 Dec 2024 16:23:34 +0100 Subject: [PATCH] Remove event handler --- app/helpers/application_helper.rb | 2 +- app/javascript/controllers/maps_controller.js | 10 ++++++---- 2 files changed, 7 insertions(+), 5 deletions(-) diff --git a/app/helpers/application_helper.rb b/app/helpers/application_helper.rb index 7b577f93..c6258d08 100644 --- a/app/helpers/application_helper.rb +++ b/app/helpers/application_helper.rb @@ -116,7 +116,7 @@ module ApplicationHelper end def speed_text_color(speed) - return if speed.to_i >= 0 + return 'text-default' if speed.to_i >= 0 'text-red-500' end diff --git a/app/javascript/controllers/maps_controller.js b/app/javascript/controllers/maps_controller.js index 05f78221..d0bb046d 100644 --- a/app/javascript/controllers/maps_controller.js +++ b/app/javascript/controllers/maps_controller.js @@ -174,6 +174,9 @@ export default class extends Controller { } disconnect() { + if (this.handleDeleteClick) { + document.removeEventListener('click', this.handleDeleteClick); + } this.map.remove(); } @@ -331,11 +334,10 @@ export default class extends Controller { } } }; - } - // Add the listener only if it hasn't been added before - document.removeEventListener('click', this.handleDeleteClick); - document.addEventListener('click', this.handleDeleteClick); + // Add the listener only if it hasn't been added before + document.addEventListener('click', this.handleDeleteClick); + } // Add an event listener for base layer change in Leaflet this.map.on('baselayerchange', (event) => {