From 88909b3e9fdefbad417daf0d96ecf17f00995c2c Mon Sep 17 00:00:00 2001 From: Eugene Burmakin Date: Tue, 22 Jul 2025 19:17:28 +0200 Subject: [PATCH 1/6] Optimize stats page performance --- Gemfile | 1 + Gemfile.lock | 5 ++++ app/controllers/stats_controller.rb | 28 +++++++++++++++++++---- app/jobs/trips/calculate_all_job.rb | 2 +- app/jobs/trips/calculate_countries_job.rb | 2 +- app/jobs/trips/calculate_distance_job.rb | 2 +- app/jobs/trips/calculate_path_job.rb | 2 +- app/models/country.rb | 4 +++- app/views/stats/_year.html.erb | 2 +- app/views/stats/index.html.erb | 2 +- config/environments/development.rb | 9 ++++++++ config/environments/production.rb | 2 +- config/environments/test.rb | 6 +++++ config/sidekiq.yml | 1 + 14 files changed, 56 insertions(+), 12 deletions(-) diff --git a/Gemfile b/Gemfile index 614a2e95..0e11a1fa 100644 --- a/Gemfile +++ b/Gemfile @@ -77,4 +77,5 @@ group :development do gem 'database_consistency', require: false gem 'foreman' gem 'rubocop-rails', require: false + gem 'bullet' end diff --git a/Gemfile.lock b/Gemfile.lock index 640e815e..7d65bab2 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -113,6 +113,9 @@ GEM brakeman (7.0.2) racc builder (3.3.0) + bullet (8.0.8) + activesupport (>= 3.0.0) + uniform_notifier (~> 1.11) bundler-audit (0.9.2) bundler (>= 1.2.0, < 3) thor (~> 1.0) @@ -486,6 +489,7 @@ GEM unicode-display_width (3.1.4) unicode-emoji (~> 4.0, >= 4.0.4) unicode-emoji (4.0.4) + uniform_notifier (1.17.0) uri (1.0.3) useragent (0.16.11) warden (1.2.9) @@ -519,6 +523,7 @@ DEPENDENCIES aws-sdk-s3 (~> 1.177.0) bootsnap brakeman + bullet bundler-audit capybara chartkick diff --git a/app/controllers/stats_controller.rb b/app/controllers/stats_controller.rb index a456452f..08074462 100644 --- a/app/controllers/stats_controller.rb +++ b/app/controllers/stats_controller.rb @@ -5,10 +5,30 @@ class StatsController < ApplicationController before_action :authenticate_active_user!, only: %i[update update_all] def index - @stats = current_user.stats.group_by(&:year).transform_values { |stats| stats.sort_by(&:updated_at).reverse }.sort.reverse - @points_total = current_user.tracked_points.count - @points_reverse_geocoded = current_user.total_reverse_geocoded_points - @points_reverse_geocoded_without_data = current_user.total_reverse_geocoded_points_without_data + @stats = current_user.stats.group_by(&:year).transform_values do |stats| + stats.sort_by(&:updated_at).reverse + end.sort.reverse + + # Single aggregated query to replace 3 separate COUNT queries + result = current_user.tracked_points.connection.execute(<<~SQL.squish) + SELECT#{' '} + COUNT(*) as total, + COUNT(reverse_geocoded_at) as geocoded, + COUNT(CASE WHEN geodata = '{}' THEN 1 END) as without_data + FROM points#{' '} + WHERE user_id = #{current_user.id} + SQL + + row = result.first + @points_total = row['total'].to_i + @points_reverse_geocoded = row['geocoded'].to_i + @points_reverse_geocoded_without_data = row['without_data'].to_i + + # Precompute year distance data to avoid N+1 queries in view + @year_distances = {} + @stats.each do |year, _stats| + @year_distances[year] = Stat.year_distance(year, current_user) + end end def show diff --git a/app/jobs/trips/calculate_all_job.rb b/app/jobs/trips/calculate_all_job.rb index 0500881c..3710df3e 100644 --- a/app/jobs/trips/calculate_all_job.rb +++ b/app/jobs/trips/calculate_all_job.rb @@ -1,7 +1,7 @@ # frozen_string_literal: true class Trips::CalculateAllJob < ApplicationJob - queue_as :default + queue_as :trips def perform(trip_id, distance_unit = 'km') Trips::CalculatePathJob.perform_later(trip_id) diff --git a/app/jobs/trips/calculate_countries_job.rb b/app/jobs/trips/calculate_countries_job.rb index e63365d3..ed5ee884 100644 --- a/app/jobs/trips/calculate_countries_job.rb +++ b/app/jobs/trips/calculate_countries_job.rb @@ -1,7 +1,7 @@ # frozen_string_literal: true class Trips::CalculateCountriesJob < ApplicationJob - queue_as :default + queue_as :trips def perform(trip_id, distance_unit) trip = Trip.find(trip_id) diff --git a/app/jobs/trips/calculate_distance_job.rb b/app/jobs/trips/calculate_distance_job.rb index 8a28e06f..15ff83c4 100644 --- a/app/jobs/trips/calculate_distance_job.rb +++ b/app/jobs/trips/calculate_distance_job.rb @@ -1,7 +1,7 @@ # frozen_string_literal: true class Trips::CalculateDistanceJob < ApplicationJob - queue_as :default + queue_as :trips def perform(trip_id, distance_unit) trip = Trip.find(trip_id) diff --git a/app/jobs/trips/calculate_path_job.rb b/app/jobs/trips/calculate_path_job.rb index 711cfef8..f1323c5f 100644 --- a/app/jobs/trips/calculate_path_job.rb +++ b/app/jobs/trips/calculate_path_job.rb @@ -1,7 +1,7 @@ # frozen_string_literal: true class Trips::CalculatePathJob < ApplicationJob - queue_as :default + queue_as :trips def perform(trip_id) trip = Trip.find(trip_id) diff --git a/app/models/country.rb b/app/models/country.rb index 9ef64687..e40a0c6d 100644 --- a/app/models/country.rb +++ b/app/models/country.rb @@ -12,6 +12,8 @@ class Country < ApplicationRecord end def self.names_to_iso_a2 - pluck(:name, :iso_a2).to_h + Rails.cache.fetch('countries_names_to_iso_a2', expires_in: 1.day) do + pluck(:name, :iso_a2).to_h + end end end diff --git a/app/views/stats/_year.html.erb b/app/views/stats/_year.html.erb index 886e2c96..3d8989b8 100644 --- a/app/views/stats/_year.html.erb +++ b/app/views/stats/_year.html.erb @@ -4,7 +4,7 @@
<%= column_chart( - Stat.year_distance(year, current_user), + @year_distances[year], height: '200px', suffix: " #{current_user.safe_settings.distance_unit}", xtitle: 'Days', diff --git a/app/views/stats/index.html.erb b/app/views/stats/index.html.erb index 96050095..2f14fa36 100644 --- a/app/views/stats/index.html.erb +++ b/app/views/stats/index.html.erb @@ -82,7 +82,7 @@
<% end %> <%= column_chart( - Stat.year_distance(year, current_user).map { |month_name, distance_meters| + @year_distances[year].map { |month_name, distance_meters| [month_name, Stat.convert_distance(distance_meters, current_user.safe_settings.distance_unit).round(2)] }, height: '200px', diff --git a/config/environments/development.rb b/config/environments/development.rb index c940de0e..36cb4be1 100644 --- a/config/environments/development.rb +++ b/config/environments/development.rb @@ -3,6 +3,15 @@ require 'active_support/core_ext/integer/time' Rails.application.configure do + config.after_initialize do + Bullet.enable = true + Bullet.alert = true + Bullet.bullet_logger = true + Bullet.console = true + Bullet.rails_logger = true + Bullet.add_footer = true + end + # Settings specified here will take precedence over those in config/application.rb. # In the development environment your application's code is reloaded any time diff --git a/config/environments/production.rb b/config/environments/production.rb index 1e4b392a..53eedb18 100644 --- a/config/environments/production.rb +++ b/config/environments/production.rb @@ -29,7 +29,7 @@ Rails.application.configure do # config.assets.css_compressor = :sass # Do not fallback to assets pipeline if a precompiled asset is missed. - config.assets.compile = true + config.assets.compile = false config.assets.content_type = { geojson: 'application/geo+json' diff --git a/config/environments/test.rb b/config/environments/test.rb index e138d076..b4884952 100644 --- a/config/environments/test.rb +++ b/config/environments/test.rb @@ -8,6 +8,12 @@ require 'active_support/core_ext/integer/time' # and recreated between test runs. Don't rely on the data there! Rails.application.configure do + config.after_initialize do + Bullet.enable = true + Bullet.bullet_logger = true + Bullet.raise = true # raise an error if n+1 query occurs + end + # Settings specified here will take precedence over those in config/application.rb. # While tests run files are not watched, reloading is not necessary. diff --git a/config/sidekiq.yml b/config/sidekiq.yml index 87109364..c1966a7f 100644 --- a/config/sidekiq.yml +++ b/config/sidekiq.yml @@ -6,6 +6,7 @@ - imports - exports - stats + - trips - tracks - reverse_geocoding - visit_suggesting From da38c128196e38d8d65f09118145b8fffb44ce96 Mon Sep 17 00:00:00 2001 From: Eugene Burmakin Date: Tue, 22 Jul 2025 19:43:27 +0200 Subject: [PATCH 2/6] Extract stats query --- Gemfile | 1 - Gemfile.lock | 26 +++--- app/controllers/stats_controller.rb | 53 +++++++----- app/queries/stats_query.rb | 30 +++++++ config/environments/development.rb | 9 -- config/environments/test.rb | 6 -- spec/queries/stats_query_spec.rb | 130 ++++++++++++++++++++++++++++ 7 files changed, 202 insertions(+), 53 deletions(-) create mode 100644 app/queries/stats_query.rb create mode 100644 spec/queries/stats_query_spec.rb diff --git a/Gemfile b/Gemfile index 0e11a1fa..614a2e95 100644 --- a/Gemfile +++ b/Gemfile @@ -77,5 +77,4 @@ group :development do gem 'database_consistency', require: false gem 'foreman' gem 'rubocop-rails', require: false - gem 'bullet' end diff --git a/Gemfile.lock b/Gemfile.lock index 7d65bab2..f647ff71 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -163,7 +163,7 @@ GEM dotenv (= 3.1.8) railties (>= 6.1) drb (2.2.3) - erb (5.0.1) + erb (5.0.2) erubi (1.13.1) et-orbi (1.2.11) tzinfo @@ -197,7 +197,7 @@ GEM actionpack (>= 6.0.0) activesupport (>= 6.0.0) railties (>= 6.0.0) - io-console (0.8.0) + io-console (0.8.1) irb (1.15.2) pp (>= 0.6.0) rdoc (>= 4.0.0) @@ -246,7 +246,7 @@ GEM multi_json (1.15.0) multi_xml (0.7.1) bigdecimal (~> 3.1) - net-imap (0.5.8) + net-imap (0.5.9) date net-protocol net-pop (0.1.2) @@ -256,18 +256,18 @@ GEM net-smtp (0.5.1) net-protocol nio4r (2.7.4) - nokogiri (1.18.8) + nokogiri (1.18.9) mini_portile2 (~> 2.8.2) racc (~> 1.4) - nokogiri (1.18.8-aarch64-linux-gnu) + nokogiri (1.18.9-aarch64-linux-gnu) racc (~> 1.4) - nokogiri (1.18.8-arm-linux-gnu) + nokogiri (1.18.9-arm-linux-gnu) racc (~> 1.4) - nokogiri (1.18.8-arm64-darwin) + nokogiri (1.18.9-arm64-darwin) racc (~> 1.4) - nokogiri (1.18.8-x86_64-darwin) + nokogiri (1.18.9-x86_64-darwin) racc (~> 1.4) - nokogiri (1.18.8-x86_64-linux-gnu) + nokogiri (1.18.9-x86_64-linux-gnu) racc (~> 1.4) oj (3.16.11) bigdecimal (>= 3.0) @@ -345,7 +345,7 @@ GEM zeitwerk (~> 2.6) rainbow (3.1.1) rake (13.3.0) - rdoc (6.14.1) + rdoc (6.14.2) erb psych (>= 4.0.0) redis (5.4.0) @@ -353,7 +353,7 @@ GEM redis-client (0.24.0) connection_pool regexp_parser (2.10.0) - reline (0.6.1) + reline (0.6.2) io-console (~> 0.5) request_store (1.7.0) rack (>= 1.4) @@ -478,7 +478,7 @@ GEM tailwindcss-ruby (3.4.17-arm64-darwin) tailwindcss-ruby (3.4.17-x86_64-darwin) tailwindcss-ruby (3.4.17-x86_64-linux) - thor (1.3.2) + thor (1.4.0) timeout (0.4.3) turbo-rails (2.0.16) actionpack (>= 7.1.0) @@ -500,7 +500,7 @@ GEM hashdiff (>= 0.4.0, < 2.0.0) webrick (1.9.1) websocket (1.2.11) - websocket-driver (0.7.7) + websocket-driver (0.8.0) base64 websocket-extensions (>= 0.1.0) websocket-extensions (0.1.5) diff --git a/app/controllers/stats_controller.rb b/app/controllers/stats_controller.rb index 08074462..0300deae 100644 --- a/app/controllers/stats_controller.rb +++ b/app/controllers/stats_controller.rb @@ -5,30 +5,9 @@ class StatsController < ApplicationController before_action :authenticate_active_user!, only: %i[update update_all] def index - @stats = current_user.stats.group_by(&:year).transform_values do |stats| - stats.sort_by(&:updated_at).reverse - end.sort.reverse - - # Single aggregated query to replace 3 separate COUNT queries - result = current_user.tracked_points.connection.execute(<<~SQL.squish) - SELECT#{' '} - COUNT(*) as total, - COUNT(reverse_geocoded_at) as geocoded, - COUNT(CASE WHEN geodata = '{}' THEN 1 END) as without_data - FROM points#{' '} - WHERE user_id = #{current_user.id} - SQL - - row = result.first - @points_total = row['total'].to_i - @points_reverse_geocoded = row['geocoded'].to_i - @points_reverse_geocoded_without_data = row['without_data'].to_i - - # Precompute year distance data to avoid N+1 queries in view - @year_distances = {} - @stats.each do |year, _stats| - @year_distances[year] = Stat.year_distance(year, current_user) - end + @stats = build_stats + assign_points_statistics + @year_distances = precompute_year_distances end def show @@ -63,4 +42,30 @@ class StatsController < ApplicationController redirect_to stats_path, notice: 'Stats are being updated', status: :see_other end + + private + + def assign_points_statistics + points_stats = ::StatsQuery.new(current_user).points_stats + + @points_total = points_stats[:total] + @points_reverse_geocoded = points_stats[:geocoded] + @points_reverse_geocoded_without_data = points_stats[:without_data] + end + + def precompute_year_distances + year_distances = {} + + @stats.each do |year, _stats| + year_distances[year] = Stat.year_distance(year, current_user) + end + + year_distances + end + + def build_stats + current_user.stats.group_by(&:year).transform_values do |stats| + stats.sort_by(&:updated_at).reverse + end.sort.reverse + end end diff --git a/app/queries/stats_query.rb b/app/queries/stats_query.rb new file mode 100644 index 00000000..e3ef3503 --- /dev/null +++ b/app/queries/stats_query.rb @@ -0,0 +1,30 @@ +# frozen_string_literal: true + +class StatsQuery + def initialize(user) + @user = user + end + + def points_stats + result = user.tracked_points.connection.execute(<<~SQL.squish) + SELECT#{' '} + COUNT(*) as total, + COUNT(reverse_geocoded_at) as geocoded, + COUNT(CASE WHEN geodata = '{}' THEN 1 END) as without_data + FROM points#{' '} + WHERE user_id = #{user.id} + SQL + + row = result.first + + { + total: row['total'].to_i, + geocoded: row['geocoded'].to_i, + without_data: row['without_data'].to_i + } + end + + private + + attr_reader :user +end diff --git a/config/environments/development.rb b/config/environments/development.rb index 36cb4be1..c940de0e 100644 --- a/config/environments/development.rb +++ b/config/environments/development.rb @@ -3,15 +3,6 @@ require 'active_support/core_ext/integer/time' Rails.application.configure do - config.after_initialize do - Bullet.enable = true - Bullet.alert = true - Bullet.bullet_logger = true - Bullet.console = true - Bullet.rails_logger = true - Bullet.add_footer = true - end - # Settings specified here will take precedence over those in config/application.rb. # In the development environment your application's code is reloaded any time diff --git a/config/environments/test.rb b/config/environments/test.rb index b4884952..e138d076 100644 --- a/config/environments/test.rb +++ b/config/environments/test.rb @@ -8,12 +8,6 @@ require 'active_support/core_ext/integer/time' # and recreated between test runs. Don't rely on the data there! Rails.application.configure do - config.after_initialize do - Bullet.enable = true - Bullet.bullet_logger = true - Bullet.raise = true # raise an error if n+1 query occurs - end - # Settings specified here will take precedence over those in config/application.rb. # While tests run files are not watched, reloading is not necessary. diff --git a/spec/queries/stats_query_spec.rb b/spec/queries/stats_query_spec.rb new file mode 100644 index 00000000..d4d8517f --- /dev/null +++ b/spec/queries/stats_query_spec.rb @@ -0,0 +1,130 @@ +# frozen_string_literal: true + +require 'rails_helper' + +RSpec.describe StatsQuery do + describe '#points_stats' do + subject(:points_stats) { described_class.new(user).points_stats } + + let(:user) { create(:user) } + let!(:import) { create(:import, user: user) } + + context 'when user has no points' do + it 'returns zero counts for all statistics' do + expect(points_stats).to eq({ + total: 0, + geocoded: 0, + without_data: 0 + }) + end + end + + context 'when user has points' do + let!(:geocoded_point_with_data) do + create(:point, + user: user, + import: import, + reverse_geocoded_at: Time.current, + geodata: { 'address' => '123 Main St' }) + end + + let!(:geocoded_point_without_data) do + create(:point, + user: user, + import: import, + reverse_geocoded_at: Time.current, + geodata: {}) + end + + let!(:non_geocoded_point) do + create(:point, + user: user, + import: import, + reverse_geocoded_at: nil, + geodata: { 'some' => 'data' }) + end + + it 'returns correct counts for all statistics' do + expect(points_stats).to eq({ + total: 3, + geocoded: 2, + without_data: 1 + }) + end + + context 'when another user has points' do + let(:other_user) { create(:user) } + let!(:other_import) { create(:import, user: other_user) } + let!(:other_point) do + create(:point, + user: other_user, + import: other_import, + reverse_geocoded_at: Time.current, + geodata: { 'address' => 'Other Address' }) + end + + it 'only counts points for the specified user' do + expect(points_stats).to eq({ + total: 3, + geocoded: 2, + without_data: 1 + }) + end + end + end + + context 'when all points are geocoded with data' do + before do + create_list(:point, 5, + user: user, + import: import, + reverse_geocoded_at: Time.current, + geodata: { 'address' => 'Some Address' }) + end + + it 'returns correct statistics' do + expect(points_stats).to eq({ + total: 5, + geocoded: 5, + without_data: 0 + }) + end + end + + context 'when all points are without geodata' do + before do + create_list(:point, 3, + user: user, + import: import, + reverse_geocoded_at: Time.current, + geodata: {}) + end + + it 'returns correct statistics' do + expect(points_stats).to eq({ + total: 3, + geocoded: 3, + without_data: 3 + }) + end + end + + context 'when all points are not geocoded' do + before do + create_list(:point, 4, + user: user, + import: import, + reverse_geocoded_at: nil, + geodata: { 'some' => 'data' }) + end + + it 'returns correct statistics' do + expect(points_stats).to eq({ + total: 4, + geocoded: 0, + without_data: 0 + }) + end + end + end +end \ No newline at end of file From 58ffca74f61b7af8d0541ec1ed52dd6bc96ffbcd Mon Sep 17 00:00:00 2001 From: Eugene Burmakin Date: Tue, 22 Jul 2025 19:44:50 +0200 Subject: [PATCH 3/6] Remove bullet --- Gemfile.lock | 5 ----- 1 file changed, 5 deletions(-) diff --git a/Gemfile.lock b/Gemfile.lock index f647ff71..3beeac65 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -113,9 +113,6 @@ GEM brakeman (7.0.2) racc builder (3.3.0) - bullet (8.0.8) - activesupport (>= 3.0.0) - uniform_notifier (~> 1.11) bundler-audit (0.9.2) bundler (>= 1.2.0, < 3) thor (~> 1.0) @@ -489,7 +486,6 @@ GEM unicode-display_width (3.1.4) unicode-emoji (~> 4.0, >= 4.0.4) unicode-emoji (4.0.4) - uniform_notifier (1.17.0) uri (1.0.3) useragent (0.16.11) warden (1.2.9) @@ -523,7 +519,6 @@ DEPENDENCIES aws-sdk-s3 (~> 1.177.0) bootsnap brakeman - bullet bundler-audit capybara chartkick From 6e5dd4bed6040f9747655c4f2b57b78eb1b7ec42 Mon Sep 17 00:00:00 2001 From: Eugene Burmakin Date: Tue, 22 Jul 2025 19:52:24 +0200 Subject: [PATCH 4/6] Update stats query --- app/queries/stats_query.rb | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/app/queries/stats_query.rb b/app/queries/stats_query.rb index e3ef3503..ad7ef90d 100644 --- a/app/queries/stats_query.rb +++ b/app/queries/stats_query.rb @@ -6,12 +6,12 @@ class StatsQuery end def points_stats - result = user.tracked_points.connection.execute(<<~SQL.squish) - SELECT#{' '} - COUNT(*) as total, + result = Point.connection.execute(<<~SQL.squish) + SELECT + COUNT(id) as total, COUNT(reverse_geocoded_at) as geocoded, - COUNT(CASE WHEN geodata = '{}' THEN 1 END) as without_data - FROM points#{' '} + COUNT(CASE WHEN geodata = '{}'::jsonb THEN 1 END) as without_data + FROM points WHERE user_id = #{user.id} SQL From cbdef5fa43286858d3cf3d55a18719cc81c962dc Mon Sep 17 00:00:00 2001 From: Eugene Burmakin Date: Tue, 22 Jul 2025 19:56:12 +0200 Subject: [PATCH 5/6] Parameterize stats query --- app/queries/stats_query.rb | 27 +++++++++++++++------------ 1 file changed, 15 insertions(+), 12 deletions(-) diff --git a/app/queries/stats_query.rb b/app/queries/stats_query.rb index ad7ef90d..0192a8c8 100644 --- a/app/queries/stats_query.rb +++ b/app/queries/stats_query.rb @@ -6,21 +6,24 @@ class StatsQuery end def points_stats - result = Point.connection.execute(<<~SQL.squish) - SELECT - COUNT(id) as total, - COUNT(reverse_geocoded_at) as geocoded, - COUNT(CASE WHEN geodata = '{}'::jsonb THEN 1 END) as without_data - FROM points - WHERE user_id = #{user.id} - SQL + sql = ActiveRecord::Base.sanitize_sql_array([ + <<~SQL.squish, + SELECT + COUNT(id) as total, + COUNT(reverse_geocoded_at) as geocoded, + COUNT(CASE WHEN geodata = '{}'::jsonb THEN 1 END) as without_data + FROM points + WHERE user_id = ? + SQL + user.id + ]) - row = result.first + result = Point.connection.select_one(sql) { - total: row['total'].to_i, - geocoded: row['geocoded'].to_i, - without_data: row['without_data'].to_i + total: result['total'].to_i, + geocoded: result['geocoded'].to_i, + without_data: result['without_data'].to_i } end From c14054fdc3fed4b09849b7bcc1e24a8259fb3c6a Mon Sep 17 00:00:00 2001 From: Eugene Burmakin Date: Tue, 22 Jul 2025 20:15:52 +0200 Subject: [PATCH 6/6] Disable track generation failure notification for self-hosted users --- app/jobs/tracks/create_job.rb | 2 ++ spec/jobs/tracks/create_job_spec.rb | 46 +++++++++++++++++++++++++++++ 2 files changed, 48 insertions(+) diff --git a/app/jobs/tracks/create_job.rb b/app/jobs/tracks/create_job.rb index 919e5f82..a65805c4 100644 --- a/app/jobs/tracks/create_job.rb +++ b/app/jobs/tracks/create_job.rb @@ -27,6 +27,8 @@ class Tracks::CreateJob < ApplicationJob end def create_error_notification(user, error) + return unless DawarichSettings.self_hosted? + Notifications::Create.new( user: user, kind: :error, diff --git a/spec/jobs/tracks/create_job_spec.rb b/spec/jobs/tracks/create_job_spec.rb index bc2648d9..bddf430a 100644 --- a/spec/jobs/tracks/create_job_spec.rb +++ b/spec/jobs/tracks/create_job_spec.rb @@ -151,4 +151,50 @@ RSpec.describe Tracks::CreateJob, type: :job do expect(described_class.new.queue_name).to eq('tracks') end end + + context 'when self-hosted' do + let(:generator_instance) { instance_double(Tracks::Generator) } + let(:notification_service) { instance_double(Notifications::Create) } + let(:error_message) { 'Something went wrong' } + + before do + allow(DawarichSettings).to receive(:self_hosted?).and_return(true) + allow(Tracks::Generator).to receive(:new).and_return(generator_instance) + allow(generator_instance).to receive(:call).and_raise(StandardError, error_message) + allow(Notifications::Create).to receive(:new).and_return(notification_service) + allow(notification_service).to receive(:call) + end + + it 'creates a failure notification when self-hosted' do + described_class.new.perform(user.id) + + expect(Notifications::Create).to have_received(:new).with( + user: user, + kind: :error, + title: 'Track Generation Failed', + content: "Failed to generate tracks from your location data: #{error_message}" + ) + expect(notification_service).to have_received(:call) + end + end + + context 'when not self-hosted' do + let(:generator_instance) { instance_double(Tracks::Generator) } + let(:notification_service) { instance_double(Notifications::Create) } + let(:error_message) { 'Something went wrong' } + + before do + allow(DawarichSettings).to receive(:self_hosted?).and_return(false) + allow(Tracks::Generator).to receive(:new).and_return(generator_instance) + allow(generator_instance).to receive(:call).and_raise(StandardError, error_message) + allow(Notifications::Create).to receive(:new).and_return(notification_service) + allow(notification_service).to receive(:call) + end + + it 'does not create a failure notification' do + described_class.new.perform(user.id) + + expect(notification_service).not_to have_received(:call) + end + end end