Fix tests

app/services/points/create.rb

@@ -5,10 +5,9 @@ class Points::Create
 
   def initialize(user, params)
     @user = user
-    @params = params
+    @params = params.to_h
   end
 
-  # rubocop:disable Metrics/MethodLength
   def call
     data = Points::Params.new(params, user.id).call
 
@@ -19,7 +18,7 @@ class Points::Create
       result = Point.upsert_all(
         location_batch,
         unique_by: %i[lonlat timestamp user_id],
-        returning: %i[id lonlat timestamp]
+        returning: Arel.sql('id, timestamp, ST_X(lonlat::geometry) AS longitude, ST_Y(lonlat::geometry) AS latitude')
       )
       # rubocop:enable Rails/SkipsModelValidations
 
@@ -28,5 +27,4 @@ class Points::Create
 
     created_points
   end
-  # rubocop:enable Metrics/MethodLength
 end

spec/requests/api/v1/points_spec.rb

@@ -9,6 +9,16 @@ RSpec.describe 'Api::V1::Points', type: :request do
       create(:point, user:, timestamp: 1.day.ago + i.minutes)
     end
   end
+  let(:point_params) do
+    {
+      locations: [
+        {
+          geometry: { type: 'Point', coordinates: [1.0, 1.0] },
+          properties: { timestamp: '2025-01-17T21:03:01Z' }
+        }
+      ]
+    }
+  end
 
   describe 'GET /index' do
     context 'when regular version of points is requested' do
@@ -122,9 +132,16 @@ RSpec.describe 'Api::V1::Points', type: :request do
 
   describe 'POST /create' do
     it 'returns a successful response' do
-      post "/api/v1/points?api_key=#{user.api_key}", params: { point: { latitude: 1.0, longitude: 1.0 } }
+      post "/api/v1/points?api_key=#{user.api_key}", params: point_params
 
-      expect(response).to have_http_status(:success)
+      expect(response).to have_http_status(:ok)
+
+      json_response = JSON.parse(response.body)['data']
+
+      expect(json_response.size).to be_positive
+      expect(json_response.first['latitude']).to eq(1.0)
+      expect(json_response.first['longitude']).to eq(1.0)
+      expect(json_response.first['timestamp']).to be_an_instance_of(Integer)
     end
 
     context 'when user is inactive' do
@@ -133,7 +150,7 @@ RSpec.describe 'Api::V1::Points', type: :request do
       end
 
       it 'returns an unauthorized response' do
-        post "/api/v1/points?api_key=#{user.api_key}", params: { point: { latitude: 1.0, longitude: 1.0 } }
+        post "/api/v1/points?api_key=#{user.api_key}", params: point_params
 
         expect(response).to have_http_status(:unauthorized)
       end

spec/services/points/create_spec.rb

@@ -50,7 +50,7 @@ RSpec.describe Points::Create do
         .with(
           processed_data,
           unique_by: %i[lonlat timestamp user_id],
-          returning: %i[id lonlat timestamp]
+          returning: Arel.sql('id, timestamp, ST_X(lonlat::geometry) AS longitude, ST_Y(lonlat::geometry) AS latitude')
         )
         .and_return(upsert_result)
 
@@ -205,7 +205,7 @@ RSpec.describe Points::Create do
           .with(
             all_processed_data,
             unique_by: %i[lonlat timestamp user_id],
-            returning: %i[id lonlat timestamp]
+            returning: Arel.sql('id, timestamp, ST_X(lonlat::geometry) AS longitude, ST_Y(lonlat::geometry) AS latitude')
           )
           .and_return(expected_results)
       end

spec/swagger/api/v1/points_controller_spec.rb

@@ -98,6 +98,11 @@ describe 'Points API', type: :request do
       tags 'Points'
       consumes 'application/json'
       parameter name: :locations, in: :body, schema: {
+        type: :object,
+        properties: {
+          locations: {
+            type: :array,
+            items: {
               type: :object,
               properties: {
                 type: { type: :string },
@@ -168,10 +173,13 @@ describe 'Points API', type: :request do
                       description: 'the device id of the point set by the device'
                     }
                   }
+                }
               },
               required: %w[geometry properties]
             }
           }
+        }
+      }
 
       parameter name: :api_key, in: :query, type: :string, required: true, description: 'API Key'
 
@@ -179,8 +187,7 @@ describe 'Points API', type: :request do
         let(:file_path) { 'spec/fixtures/files/points/geojson_example.json' }
         let(:file) { File.open(file_path) }
         let(:json) { JSON.parse(file.read) }
-        let(:params) { json }
-        let(:locations) { params['locations'] }
+        let(:locations) { json }
         let(:api_key) { create(:user).api_key }
 
         run_test!
@@ -190,8 +197,7 @@ describe 'Points API', type: :request do
         let(:file_path) { 'spec/fixtures/files/points/geojson_example.json' }
         let(:file) { File.open(file_path) }
         let(:json) { JSON.parse(file.read) }
-        let(:params) { json }
-        let(:locations) { params['locations'] }
+        let(:locations) { json }
         let(:api_key) { 'invalid_api_key' }
 
         run_test!

swagger/v1/swagger.yaml

@@ -845,6 +845,11 @@ paths:
         content:
           application/json:
             schema:
+              type: object
+              properties:
+                locations:
+                  type: array
+                  items:
                     type: object
                     properties:
                       type:
@@ -863,7 +868,8 @@ paths:
                               example:
                               - -122.40530871
                               - 37.74430413
-                        description: the coordinates of the point, longitude and latitude
+                              description: the coordinates of the point, longitude
+                                and latitude
                       properties:
                         type: object
                         properties:
@@ -890,7 +896,8 @@ paths:
                           speed_accuracy:
                             type: number
                             example: 0
-                      description: the speed accuracy of the point in meters per second
+                            description: the speed accuracy of the point in meters
+                              per second
                           course_accuracy:
                             type: number
                             example: 0