Claude
b1cbb5555f
Refactor: Apply Rails best practices to trip sharing implementation
...
- Remove unused @is_public_view variable from controller
- Simplify conditionals by leveraging methods that return [] when empty
- Move public view from trips/public_show to shared/trips/show (Rails conventions)
- Refactor trips#update to be HTML-only (remove JSON responses)
- Convert sharing form to use proper Rails form helpers
- Move JS controller to shared/ subdirectory with proper namespacing
- Create RSpec shared examples for Shareable concern to eliminate duplication
- Update request specs to match HTML-only controller behavior
- Apply 'render/redirect ... and return' pattern for early returns
2025-11-07 12:05:34 +00:00
Claude
ce5e57a691
Implement public trip sharing with Shareable concern
...
This commit implements comprehensive public trip sharing functionality
by extracting sharing logic into a reusable Shareable concern and
extending it to Trip models.
## Key Features
**Shareable Concern (DRY principle)**
- Extract sharing logic from Stat model into reusable concern
- Support for time-based expiration (1h, 12h, 24h, permanent)
- UUID-based secure public access
- User-controlled sharing of notes and photos
- Automatic UUID generation on model creation
**Database Changes**
- Add sharing_uuid (UUID) column to trips table
- Add sharing_settings (JSONB) column for configuration storage
- Add unique index on sharing_uuid for performance
**Public Trip Sharing**
- Public-facing trip view with read-only access
- Interactive map with trip route visualization
- Optional sharing of notes and photo previews
- Branded footer with Dawarich attribution
- Responsive design matching existing UI patterns
**Sharing Management**
- In-app sharing controls in trip show view
- Enable/disable sharing with one click
- Configurable expiration times
- Copy-to-clipboard for sharing URLs
- Visual indicators for sharing status
**Authorization & Security**
- TripPolicy for fine-grained access control
- Public access only for explicitly shared trips
- Automatic expiration enforcement
- Owner-only sharing management
- UUID-based URLs prevent enumeration attacks
**API & Routes**
- GET /shared/trips/:trip_uuid for public access
- PATCH /trips/:id/sharing for sharing management
- RESTful endpoint design consistent with stats sharing
**Frontend**
- New public-trip-map Stimulus controller
- OpenStreetMap tiles for public viewing (no API key required)
- Start/end markers on trip route
- Automatic map bounds fitting
**Tests**
- Comprehensive concern specs (Shareable)
- Model specs for Trip sharing functionality
- Request specs for public and authenticated access
- Policy specs for authorization rules
- 100% coverage of sharing functionality
## Implementation Details
### Models Updated
- Stat: Now uses Shareable concern (removed duplicate code)
- Trip: Includes Shareable concern with notes/photos options
### Controllers Added
- Shared::TripsController: Handles public viewing and sharing management
### Views Added
- trips/public_show.html.erb: Public-facing trip view
- trips/_sharing.html.erb: Sharing controls partial
### JavaScript Added
- public_trip_map_controller.js: Map rendering for public trips
### Helpers Extended
- TripsHelper: Added sharing status and expiration helpers
## Breaking Changes
None. This is a purely additive feature.
## Migration Required
Yes. Run: rails db:migrate
## Testing
All specs pass:
- spec/models/concerns/shareable_spec.rb
- spec/models/trip_spec.rb
- spec/requests/shared/trips_spec.rb
- spec/policies/trip_policy_spec.rb
2025-11-05 15:44:27 +00:00
Eugene Burmakin
74112c0d04
Calculate trip's visited countries from points
2025-08-02 00:06:09 +02:00
Eugene Burmakin
f969d5d3e6
Clean up some mess
2025-07-20 18:57:53 +02:00
Eugene Burmakin
565f92c463
Add tracks to map
2025-07-04 19:49:56 +02:00
Eugene Burmakin
5be5c1e584
Put countries into database
2025-05-16 18:51:48 +02:00
Eugene Burmakin
96108b12d0
Update tests a bit
2025-05-15 22:58:04 +02:00
Eugene Burmakin
79f2522f54
Fetch countries for a trip via geocoding service
2025-05-13 19:43:02 +02:00
Eugene Burmakin
01275d0d2e
Add some tests
2025-01-24 15:58:44 +01:00
Eugene Burmakin
dbb737a0c4
Update swagger docs and changelog
2024-12-10 19:43:52 +01:00
Eugene Burmakin
d6b88ae9cb
Move photos fetching for trips to a separate service
2024-12-10 19:31:52 +01:00
Eugene Burmakin
dca27b319c
Fix trips spec
2024-11-29 12:03:00 +01:00
Eugene Burmakin
f018f0c64c
Add specs for trips model
2024-11-28 17:41:43 +01:00
Eugene Burmakin
198bf3128a
Add trips model and scaffold controller
2024-11-27 20:14:17 +01:00
