Commit graph

8 commits

Author SHA1 Message Date
ZeroKnight
4f87fb7220 fix(docker): app and sidekiq containers ignore signals
Typically, when attempting to stop a container via `docker stop` or
`podman stop`, the container engine will send a stop signal (SIGTERM by
default) to the container's main process. There are two common ways this
can go wrong:

1. The main process is run as PID 1 and doesn't register a signal
   handler for the stop signal and is consequently ignored
2. The main process is a shell script running a foreground process with
   no `trap`s and is consequently ignored by the *shell*

In either case, because the graceful stop signal is ignored, the
container engine will then send a `SIGKILL` to the container process
after a default timeout of 10 seconds. This is why some containers can
be observed to "hang" when being stopped when they have no other reason
to do so. Unlike `SIGTERM` or `SIGINT`, `SIGKILL` is an immediate,
ungraceful stop that doesn't give the process time to clean up.

There is a fair bit of nuance in how `sh` and `bash` handle signals in
different circumstances. The behavior relevant to the second case above
and Dawarich's entrypoints in particular is that the shell ignores
signals like `SIGTERM` and `SIGINT` when waiting on a foreground job; in
this case, that would be: `bundle exec ${@}`. The reason that `SIGINT`
is not ignored after pressing `Ctrl+C` while running the docker compose
stack is because in that case the shell is **interactive** and the shell
*does* respond to `SIGINT` then (c.f. the aforementioned nuance).

Thankfully, the fix is simple: `exec` the main process, which causes the
server process to *replace* the shell process and directly receive any
signals sent. Additionally, the stop signal for the app process should
be set to `SIGINT`, as that is the expected signal for graceful
shutdown. Sidekiq is fine with either `SIGTERM` or `SIGINT`, which is
convenient.
2025-12-06 16:03:14 -08:00
Eugene Burmakin
b76602d9c8 Return sidekiq and redis to Dawarich 2025-06-09 13:39:25 +02:00
Eugene Burmakin
6d39f4306f Remove Redis and Sidekiq from Dawarich 2025-06-02 20:53:35 +02:00
Eugene Burmakin
dae1733320 Remove telemetry 2025-04-11 19:13:46 +02:00
Evgenii Burmakin
93dbde7e79
Revert "fix: set dbname in psql entrypoint commands" 2025-02-12 22:18:22 +01:00
bo0tzz
078b278c9f
fix copy paste mistake 2025-02-06 21:50:47 +01:00
bo0tzz
f32dd6c9d7
fix: set dbname in psql entrypoint commands 2025-02-06 21:50:47 +01:00
Eugene Burmakin
3312ea794f Add separate entrypoints for web and sidekiq 2025-01-09 14:44:16 +01:00