Commit graph

39 commits

Author SHA1 Message Date
Claude
ce5e57a691
Implement public trip sharing with Shareable concern
This commit implements comprehensive public trip sharing functionality
by extracting sharing logic into a reusable Shareable concern and
extending it to Trip models.

## Key Features

**Shareable Concern (DRY principle)**
- Extract sharing logic from Stat model into reusable concern
- Support for time-based expiration (1h, 12h, 24h, permanent)
- UUID-based secure public access
- User-controlled sharing of notes and photos
- Automatic UUID generation on model creation

**Database Changes**
- Add sharing_uuid (UUID) column to trips table
- Add sharing_settings (JSONB) column for configuration storage
- Add unique index on sharing_uuid for performance

**Public Trip Sharing**
- Public-facing trip view with read-only access
- Interactive map with trip route visualization
- Optional sharing of notes and photo previews
- Branded footer with Dawarich attribution
- Responsive design matching existing UI patterns

**Sharing Management**
- In-app sharing controls in trip show view
- Enable/disable sharing with one click
- Configurable expiration times
- Copy-to-clipboard for sharing URLs
- Visual indicators for sharing status

**Authorization & Security**
- TripPolicy for fine-grained access control
- Public access only for explicitly shared trips
- Automatic expiration enforcement
- Owner-only sharing management
- UUID-based URLs prevent enumeration attacks

**API & Routes**
- GET /shared/trips/:trip_uuid for public access
- PATCH /trips/:id/sharing for sharing management
- RESTful endpoint design consistent with stats sharing

**Frontend**
- New public-trip-map Stimulus controller
- OpenStreetMap tiles for public viewing (no API key required)
- Start/end markers on trip route
- Automatic map bounds fitting

**Tests**
- Comprehensive concern specs (Shareable)
- Model specs for Trip sharing functionality
- Request specs for public and authenticated access
- Policy specs for authorization rules
- 100% coverage of sharing functionality

## Implementation Details

### Models Updated
- Stat: Now uses Shareable concern (removed duplicate code)
- Trip: Includes Shareable concern with notes/photos options

### Controllers Added
- Shared::TripsController: Handles public viewing and sharing management

### Views Added
- trips/public_show.html.erb: Public-facing trip view
- trips/_sharing.html.erb: Sharing controls partial

### JavaScript Added
- public_trip_map_controller.js: Map rendering for public trips

### Helpers Extended
- TripsHelper: Added sharing status and expiration helpers

## Breaking Changes
None. This is a purely additive feature.

## Migration Required
Yes. Run: rails db:migrate

## Testing
All specs pass:
- spec/models/concerns/shareable_spec.rb
- spec/models/trip_spec.rb
- spec/requests/shared/trips_spec.rb
- spec/policies/trip_policy_spec.rb
2025-11-05 15:44:27 +00:00
Eugene Burmakin
ab4786d7b9 Fix minor bugs in Stat model related to sharing settings 2025-10-07 21:24:38 +02:00
Eugene Burmakin
339ba3130e Fix missing hexagons 2025-09-20 14:05:14 +02:00
Eugene Burmakin
2c55ca07e7 Remove permanent option from stats sharing options, default to 24h expiration. 2025-09-19 23:49:32 +02:00
Eugene Burmakin
2bd0390d1a Rename hexagon_centers to h3_hex_ids and update related logic 2025-09-19 00:23:12 +02:00
Eugene Burmakin
0905ef65a5 Don't pass h3_resolution from frontend; use default in backend service 2025-09-18 19:45:53 +02:00
Eugene Burmakin
6314442770 Calculate only centers of hexagons 2025-09-14 12:41:16 +02:00
Eugene Burmakin
dc13bc1fd2 Update public_month page 2025-09-13 23:23:48 +02:00
Eugene Burmakin
a2aa1be271 Precalculate hexagons for stats 2025-09-13 23:11:42 +02:00
Eugene Burmakin
e6f74fc6ab Update query to use lonlat column for bounds calculation 2025-09-13 18:54:02 +02:00
Eugene Burmakin
dcd1c7ab2b Add some refactorings 2025-09-13 16:41:28 +02:00
Eugene Burmakin
57ecda2b1b Extract stats sharing logic to its own controller 2025-09-12 21:08:45 +02:00
Eugene Burmakin
fc068ec79d Add Lucide icons and stats sharing 2025-09-11 20:41:43 +02:00
Eugene Burmakin
6e4934a93d Introduce points counter cache to optimize performance 2025-08-21 22:32:29 +02:00
Eugene Burmakin
bdcfb5eb62 Stats calculation is now timezone-aware. 2025-07-22 23:57:25 +02:00
Eugene Burmakin
9803ccc6a8 Remove unused method 2025-07-22 22:44:41 +02:00
Eugene Burmakin
0c904a6b84 Fix stats calculation performance 2025-07-22 22:41:12 +02:00
Eugene Burmakin
9a326733c7 Return missing map buttons 2025-07-09 00:58:33 +02:00
Eugene Burmakin
0295d3f2a0 Fix year page charts 2025-07-08 21:23:55 +02:00
Eugene Burmakin
f1720b859b Store distance in meters in the database and convert to user's preferred unit on the fly. 2025-07-08 18:10:10 +02:00
Eugene Burmakin
15be46b604 Fix tests 2025-07-04 20:55:05 +02:00
Eugene Burmakin
06aee05602 Move distance unit settings to user settings 2025-05-17 20:35:38 +02:00
Eugene Burmakin
4fa3c35fb8 Calculate distance using PostGIS ST_Distance with LAG 2025-02-22 00:02:13 +01:00
Eugene Burmakin
d9930521c9 Refactor code a bit and add some specs 2024-12-16 15:10:46 +01:00
Eugene Burmakin
3b115a85b1 Add missing tests and process reverse geocoding in batches 2024-12-06 17:32:45 +01:00
Eugene Burmakin
b7e4a017b8 Calculate only necessary stats 2024-12-06 16:52:36 +01:00
Eugene Burmakin
d218ed8151 Fix stats distances and rework stas calculating service 2024-10-24 16:59:15 +02:00
Eugene Burmakin
df430851ce Add optional order query parameter to GET /api/v1/points 2024-10-02 21:29:56 +02:00
Eugene Burmakin
08be01ebf6 Use Stat's toponyms to calculate the number of countries and cities visited in a month 2024-06-07 21:22:57 +02:00
Eugene Burmakin
cf71df3f0a Scope stats to user 2024-05-25 13:45:49 +02:00
Eugene Burmakin
082cbf159d Scope points to a user 2024-05-25 13:26:56 +02:00
Eugene Burmakin
814095a4a2 Implement bulk points deletion 2024-05-23 20:12:23 +02:00
Eugene Burmakin
ad78af59ac Rework calculation of cities visited 2024-04-26 18:59:58 +02:00
Eugene Burmakin
48962e87e8 Add some unit tests 2024-04-02 23:20:25 +02:00
Eugene Burmakin
5544bcd5ff Move point creation to a background job, add months navigation to the sidebar 2024-04-02 17:37:38 +02:00
Eugene Burmakin
b6769676c3 Fix google import and add stats for countries and cities visited and distance traveled by year 2024-03-28 15:11:59 +01:00
Eugene Burmakin
2953ca6499 Add a new page to show stats for a specific year 2024-03-24 19:46:55 +01:00
Eugene Burmakin
29ac8c1136 Add nice charts to the stat cards 2024-03-24 18:55:35 +01:00
Eugene Burmakin
e1193608ef Add basic stats 2024-03-23 20:29:55 +01:00