Claude
|
ce5e57a691
|
Implement public trip sharing with Shareable concern
This commit implements comprehensive public trip sharing functionality
by extracting sharing logic into a reusable Shareable concern and
extending it to Trip models.
## Key Features
**Shareable Concern (DRY principle)**
- Extract sharing logic from Stat model into reusable concern
- Support for time-based expiration (1h, 12h, 24h, permanent)
- UUID-based secure public access
- User-controlled sharing of notes and photos
- Automatic UUID generation on model creation
**Database Changes**
- Add sharing_uuid (UUID) column to trips table
- Add sharing_settings (JSONB) column for configuration storage
- Add unique index on sharing_uuid for performance
**Public Trip Sharing**
- Public-facing trip view with read-only access
- Interactive map with trip route visualization
- Optional sharing of notes and photo previews
- Branded footer with Dawarich attribution
- Responsive design matching existing UI patterns
**Sharing Management**
- In-app sharing controls in trip show view
- Enable/disable sharing with one click
- Configurable expiration times
- Copy-to-clipboard for sharing URLs
- Visual indicators for sharing status
**Authorization & Security**
- TripPolicy for fine-grained access control
- Public access only for explicitly shared trips
- Automatic expiration enforcement
- Owner-only sharing management
- UUID-based URLs prevent enumeration attacks
**API & Routes**
- GET /shared/trips/:trip_uuid for public access
- PATCH /trips/:id/sharing for sharing management
- RESTful endpoint design consistent with stats sharing
**Frontend**
- New public-trip-map Stimulus controller
- OpenStreetMap tiles for public viewing (no API key required)
- Start/end markers on trip route
- Automatic map bounds fitting
**Tests**
- Comprehensive concern specs (Shareable)
- Model specs for Trip sharing functionality
- Request specs for public and authenticated access
- Policy specs for authorization rules
- 100% coverage of sharing functionality
## Implementation Details
### Models Updated
- Stat: Now uses Shareable concern (removed duplicate code)
- Trip: Includes Shareable concern with notes/photos options
### Controllers Added
- Shared::TripsController: Handles public viewing and sharing management
### Views Added
- trips/public_show.html.erb: Public-facing trip view
- trips/_sharing.html.erb: Sharing controls partial
### JavaScript Added
- public_trip_map_controller.js: Map rendering for public trips
### Helpers Extended
- TripsHelper: Added sharing status and expiration helpers
## Breaking Changes
None. This is a purely additive feature.
## Migration Required
Yes. Run: rails db:migrate
## Testing
All specs pass:
- spec/models/concerns/shareable_spec.rb
- spec/models/trip_spec.rb
- spec/requests/shared/trips_spec.rb
- spec/policies/trip_policy_spec.rb
|
2025-11-05 15:44:27 +00:00 |
|
Eugene Burmakin
|
e7884b1f4f
|
Properly provide default distance unit in user settings
|
2025-10-20 19:42:24 +02:00 |
|
Eugene Burmakin
|
194f8c3c45
|
Show visited countries in a modal window on the Trip page
|
2025-10-07 21:49:58 +02:00 |
|
Eugene Burmakin
|
74112c0d04
|
Calculate trip's visited countries from points
|
2025-08-02 00:06:09 +02:00 |
|
Eugene Burmakin
|
3264725d2a
|
Fix trips page.
|
2025-07-26 21:05:28 +02:00 |
|
Eugene Burmakin
|
9c7084a10b
|
Fix request to a user in partial
|
2025-07-26 12:37:46 +02:00 |
|
Eugene Burmakin
|
f1720b859b
|
Store distance in meters in the database and convert to user's preferred unit on the fly.
|
2025-07-08 18:10:10 +02:00 |
|
Eugene Burmakin
|
c09558a6bd
|
Fixed text size of countries being calculated.
|
2025-06-09 13:04:04 +02:00 |
|
Eugene Burmakin
|
f5cefdbd03
|
Add system tests for map interaction
|
2025-05-26 20:33:48 +02:00 |
|
Eugene Burmakin
|
7c0d1f9841
|
Fix distance unit in view
|
2025-05-19 19:26:08 +02:00 |
|
Eugene Burmakin
|
6defd4d8d0
|
Update distance unit in trip page
|
2025-05-19 19:10:07 +02:00 |
|
Eugene Burmakin
|
34c82e82a5
|
Update trips page and dockerfiles
|
2025-05-19 19:00:34 +02:00 |
|
Eugene Burmakin
|
e511eb7548
|
Update changelog
|
2025-05-17 21:50:34 +02:00 |
|
Eugene Burmakin
|
06aee05602
|
Move distance unit settings to user settings
|
2025-05-17 20:35:38 +02:00 |
|
Eugene Burmakin
|
abd4325891
|
Address N+1 queries in Place::FetchData and skip locationless points
|
2025-05-17 19:14:28 +02:00 |
|
Eugene Burmakin
|
c69d4f45f1
|
Update views and specs
|
2025-05-16 19:53:42 +02:00 |
|
Eugene Burmakin
|
48e73b4f1d
|
Use protomaps in trips
|
2025-05-15 22:25:47 +02:00 |
|
Eugene Burmakin
|
088d8b14c2
|
Calculate trip data in the background
|
2025-05-15 21:33:01 +02:00 |
|
Eugene Burmakin
|
6e9c981329
|
Fix photos fetching with trip dates
|
2025-01-24 15:35:35 +01:00 |
|
Eugene Burmakin
|
9c102c1de8
|
Fix rendering polyline on trip editing page
|
2025-01-24 15:22:46 +01:00 |
|
Eugene Burmakin
|
401ac8ca31
|
Use path instead of coordinates on trips#index
|
2025-01-24 15:19:05 +01:00 |
|
Eugene Burmakin
|
380dd9235d
|
Calculate path and distance before saving trip
|
2025-01-24 15:03:57 +01:00 |
|
Eugene Burmakin
|
1e7efbc9af
|
Render trips using precalculated paths instead of list of coordinates
|
2025-01-24 14:54:10 +01:00 |
|
Eugene Burmakin
|
7db7fb17d5
|
Add path to trips
|
2025-01-24 12:01:54 +01:00 |
|
Eugene Burmakin
|
d6b88ae9cb
|
Move photos fetching for trips to a separate service
|
2024-12-10 19:31:52 +01:00 |
|
Eugene Burmakin
|
b336172b31
|
Show photoprism photos on a trip page
|
2024-12-10 18:49:37 +01:00 |
|
Nils Poltmann
|
402ebaaa10
|
Reset z-index on leaflet map
|
2024-12-01 20:34:39 +01:00 |
|
Nils
|
12ac078205
|
Reset z-index on leaflet map
|
2024-12-01 13:57:17 +01:00 |
|
Eugene Burmakin
|
fda09248da
|
Add tests for trips controller and change map seach form
|
2024-11-28 17:13:04 +01:00 |
|
Eugene Burmakin
|
5c09e5b0f9
|
Move trip to partial
|
2024-11-28 16:11:04 +01:00 |
|
Eugene Burmakin
|
71cd9d507b
|
Make each card a link and add hover effect
|
2024-11-28 15:58:30 +01:00 |
|
Eugene Burmakin
|
f2869347bc
|
Fix margins on some pages
|
2024-11-28 15:54:36 +01:00 |
|
Eugene Burmakin
|
782aeb89af
|
Add distance calculation and trip cards to trips index
|
2024-11-28 15:29:17 +01:00 |
|
Eugene Burmakin
|
be0bc35955
|
Fix showing photos on the trip edit page
|
2024-11-28 13:50:21 +01:00 |
|
Eugene Burmakin
|
e8842a9476
|
Implement rendering the route when the dates if the trip are changed
|
2024-11-28 13:20:03 +01:00 |
|
Eugene Burmakin
|
2cfc485f12
|
Add Trix editor to trips
|
2024-11-28 12:00:54 +01:00 |
|
Eugene Burmakin
|
b712332277
|
Update link to Immich search on the trip page
|
2024-11-28 10:51:11 +01:00 |
|
Eugene Burmakin
|
c689051472
|
Show some photos from the trip
|
2024-11-28 10:40:08 +01:00 |
|
Eugene Burmakin
|
9522f81abf
|
Move fetchAndDisplayPhotos to maps/helpers.js
|
2024-11-27 21:37:21 +01:00 |
|
Eugene Burmakin
|
198bf3128a
|
Add trips model and scaffold controller
|
2024-11-27 20:14:17 +01:00 |
|