Merge f1bd7ec083 into 8d2ade1bdc

.app_version

@@ -1 +1 @@
-0.37.1
+0.37.0

CHANGELOG.md

@@ -4,13 +4,6 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](http://keepachangelog.com/)
 and this project adheres to [Semantic Versioning](http://semver.org/).
 
-# [0.37.1] - 2025-12-30
-
-## Fixed
-
-- The db migration preventing the app from starting.
-- Raw data archive verifier now allows having points deleted from the db after archiving.
-
 # [0.37.0] - 2025-12-30
 
 ## Added

app/services/points/raw_data/verifier.rb

@@ -110,24 +110,18 @@ module Points
           return { success: false, error: 'Point IDs checksum mismatch' }
         end
 
-        # 8. Check which points still exist in database (informational only)
+        # 8. Verify all points still exist in database
         existing_count = Point.where(id: point_ids).count
         if existing_count != point_ids.count
-          Rails.logger.info(
-            "Archive #{archive.id}: #{point_ids.count - existing_count} points no longer in database " \
-            "(#{existing_count}/#{point_ids.count} remaining). This is OK if user deleted their data."
-          )
+          return {
+            success: false,
+            error: "Missing points in database: expected #{point_ids.count}, found #{existing_count}"
+          }
         end
 
-        # 9. Verify archived raw_data matches current database raw_data (only for existing points)
-        if existing_count.positive?
-          verification_result = verify_raw_data_matches(archived_data)
-          return verification_result unless verification_result[:success]
-        else
-          Rails.logger.info(
-            "Archive #{archive.id}: Skipping raw_data verification - no points remain in database"
-          )
-        end
+        # 9. Verify archived raw_data matches current database raw_data
+        verification_result = verify_raw_data_matches(archived_data)
+        return verification_result unless verification_result[:success]
 
         { success: true }
       end
@@ -155,18 +149,11 @@ module Points
           point_ids_to_check = archived_data.keys.sample(100)
         end
 
-        # Filter to only check points that still exist in the database
-        existing_point_ids = Point.where(id: point_ids_to_check).pluck(:id)
-        
-        if existing_point_ids.empty?
-          # No points remain to verify, but that's OK
-          Rails.logger.info("No points remaining to verify raw_data matches")
-          return { success: true }
-        end
-
         mismatches = []
+        found_points = 0
 
-        Point.where(id: existing_point_ids).find_each do |point|
+        Point.where(id: point_ids_to_check).find_each do |point|
+          found_points += 1
           archived_raw_data = archived_data[point.id]
           current_raw_data = point.raw_data
 
@@ -180,6 +167,14 @@ module Points
           end
         end
 
+        # Check if we found all the points we were looking for
+        if found_points != point_ids_to_check.size
+          return {
+            success: false,
+            error: "Missing points during data verification: expected #{point_ids_to_check.size}, found #{found_points}"
+          }
+        end
+
         if mismatches.any?
           return {
             success: false,

db/migrate/20250513164521_add_visited_countries_to_trips.rb

@@ -2,8 +2,10 @@
 
 class AddVisitedCountriesToTrips < ActiveRecord::Migration[8.0]
   def change
-    execute <<-SQL
+    # safety_assured do
+      execute <<-SQL
         ALTER TABLE trips ADD COLUMN visited_countries JSONB DEFAULT '{}'::jsonb NOT NULL;
-    SQL
+      SQL
+    # end
   end
 end

db/migrate/20250918215512_add_h3_hex_ids_to_stats.rb

@@ -5,8 +5,10 @@ class AddH3HexIdsToStats < ActiveRecord::Migration[8.0]
 
   def change
     add_column :stats, :h3_hex_ids, :jsonb, default: {}, if_not_exists: true
-    add_index :stats, :h3_hex_ids, using: :gin,
-              where: "(h3_hex_ids IS NOT NULL AND h3_hex_ids != '{}'::jsonb)",
-              algorithm: :concurrently, if_not_exists: true
+    # safety_assured do
+      add_index :stats, :h3_hex_ids, using: :gin,
+                where: "(h3_hex_ids IS NOT NULL AND h3_hex_ids != '{}'::jsonb)",
+                algorithm: :concurrently, if_not_exists: true
+    # end
   end
 end

db/migrate/20251227223614_change_digests_distance_to_bigint.rb

@@ -4,10 +4,10 @@ class ChangeDigestsDistanceToBigint < ActiveRecord::Migration[8.0]
   disable_ddl_transaction!
 
   def up
-    change_column :digests, :distance, :bigint, null: false, default: 0
+    safety_assured { change_column :digests, :distance, :bigint, null: false, default: 0 }
   end
 
   def down
-    change_column :digests, :distance, :integer, null: false, default: 0
+    safety_assured { change_column :digests, :distance, :integer, null: false, default: 0 }
   end
 end