dawarich/app/controllers/trips_controller.rb
Claude 09b16ebd7f
Refactor: Use proper boolean casting for sharing parameters
- Replace string comparisons ('1', '0') with ActiveModel::Type::Boolean
- More robust handling of truthy/falsy values
- Follows Rails conventions for type coercion
- HTML forms still send string values, but controller properly converts them
2025-11-07 12:52:30 +00:00

93 lines
2.6 KiB
Ruby

# frozen_string_literal: true
class TripsController < ApplicationController
before_action :authenticate_user!
before_action :authenticate_active_user!, only: %i[new create]
before_action :set_trip, only: %i[show edit update destroy]
before_action :set_coordinates, only: %i[show edit]
def index
@trips = current_user.trips.order(started_at: :desc).page(params[:page]).per(6)
end
def show
@photo_previews = Rails.cache.fetch("trip_photos_#{@trip.id}", expires_in: 1.day) do
@trip.photo_previews
end
@photo_sources = @trip.photo_sources
return unless @trip.path.blank? || @trip.distance.blank? || @trip.visited_countries.blank?
Trips::CalculateAllJob.perform_later(@trip.id, current_user.safe_settings.distance_unit)
end
def new
@trip = Trip.new
@coordinates = []
end
def edit; end
def create
@trip = current_user.trips.build(trip_params)
if @trip.save
redirect_to @trip, notice: 'Trip was successfully created. Data is being calculated in the background.'
else
render :new, status: :unprocessable_content
end
end
def update
# Handle sharing settings update
if params[:trip] && params[:trip][:sharing]
handle_sharing_update
redirect_to @trip, notice: 'Trip was successfully updated.', status: :see_other and return
end
# Handle regular trip update
if @trip.update(trip_params)
redirect_to @trip, notice: 'Trip was successfully updated.', status: :see_other
else
render :edit, status: :unprocessable_content
end
end
def destroy
@trip.destroy!
redirect_to trips_url, notice: 'Trip was successfully destroyed.', status: :see_other
end
private
def set_trip
@trip = current_user.trips.find(params[:id])
end
def set_coordinates
@coordinates = @trip.points.pluck(
:latitude, :longitude, :battery, :altitude, :timestamp, :velocity, :id,
:country
).map { [_1.to_f, _2.to_f, _3.to_s, _4.to_s, _5.to_s, _6.to_s, _7.to_s, _8.to_s] }
end
def handle_sharing_update
sharing_params = params[:trip][:sharing]
if ActiveModel::Type::Boolean.new.cast(sharing_params[:enabled])
sharing_options = {
expiration: sharing_params[:expiration] || '24h',
share_notes: ActiveModel::Type::Boolean.new.cast(sharing_params[:share_notes]),
share_photos: ActiveModel::Type::Boolean.new.cast(sharing_params[:share_photos])
}
@trip.enable_sharing!(**sharing_options)
else
@trip.disable_sharing!
end
end
def trip_params
params.require(:trip).permit(:name, :started_at, :ended_at, :notes)
end
end