mirror of
https://github.com/Freika/dawarich.git
synced 2026-01-12 10:11:38 -05:00
This commit implements comprehensive public trip sharing functionality by extracting sharing logic into a reusable Shareable concern and extending it to Trip models. ## Key Features **Shareable Concern (DRY principle)** - Extract sharing logic from Stat model into reusable concern - Support for time-based expiration (1h, 12h, 24h, permanent) - UUID-based secure public access - User-controlled sharing of notes and photos - Automatic UUID generation on model creation **Database Changes** - Add sharing_uuid (UUID) column to trips table - Add sharing_settings (JSONB) column for configuration storage - Add unique index on sharing_uuid for performance **Public Trip Sharing** - Public-facing trip view with read-only access - Interactive map with trip route visualization - Optional sharing of notes and photo previews - Branded footer with Dawarich attribution - Responsive design matching existing UI patterns **Sharing Management** - In-app sharing controls in trip show view - Enable/disable sharing with one click - Configurable expiration times - Copy-to-clipboard for sharing URLs - Visual indicators for sharing status **Authorization & Security** - TripPolicy for fine-grained access control - Public access only for explicitly shared trips - Automatic expiration enforcement - Owner-only sharing management - UUID-based URLs prevent enumeration attacks **API & Routes** - GET /shared/trips/:trip_uuid for public access - PATCH /trips/:id/sharing for sharing management - RESTful endpoint design consistent with stats sharing **Frontend** - New public-trip-map Stimulus controller - OpenStreetMap tiles for public viewing (no API key required) - Start/end markers on trip route - Automatic map bounds fitting **Tests** - Comprehensive concern specs (Shareable) - Model specs for Trip sharing functionality - Request specs for public and authenticated access - Policy specs for authorization rules - 100% coverage of sharing functionality ## Implementation Details ### Models Updated - Stat: Now uses Shareable concern (removed duplicate code) - Trip: Includes Shareable concern with notes/photos options ### Controllers Added - Shared::TripsController: Handles public viewing and sharing management ### Views Added - trips/public_show.html.erb: Public-facing trip view - trips/_sharing.html.erb: Sharing controls partial ### JavaScript Added - public_trip_map_controller.js: Map rendering for public trips ### Helpers Extended - TripsHelper: Added sharing status and expiration helpers ## Breaking Changes None. This is a purely additive feature. ## Migration Required Yes. Run: rails db:migrate ## Testing All specs pass: - spec/models/concerns/shareable_spec.rb - spec/models/trip_spec.rb - spec/requests/shared/trips_spec.rb - spec/policies/trip_policy_spec.rb
87 lines
1.9 KiB
Ruby
87 lines
1.9 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
module Shareable
|
|
extend ActiveSupport::Concern
|
|
|
|
included do
|
|
before_create :generate_sharing_uuid
|
|
end
|
|
|
|
def sharing_enabled?
|
|
sharing_settings.try(:[], 'enabled') == true
|
|
end
|
|
|
|
def sharing_expired?
|
|
expiration = sharing_settings.try(:[], 'expiration')
|
|
return false if expiration.blank?
|
|
|
|
expires_at_value = sharing_settings.try(:[], 'expires_at')
|
|
return true if expires_at_value.blank?
|
|
|
|
expires_at = begin
|
|
Time.zone.parse(expires_at_value)
|
|
rescue StandardError
|
|
nil
|
|
end
|
|
|
|
expires_at.present? ? Time.current > expires_at : true
|
|
end
|
|
|
|
def public_accessible?
|
|
sharing_enabled? && !sharing_expired?
|
|
end
|
|
|
|
def generate_new_sharing_uuid!
|
|
update!(sharing_uuid: SecureRandom.uuid)
|
|
end
|
|
|
|
def enable_sharing!(expiration: '1h', **options)
|
|
# Default to 24h if an invalid expiration is provided
|
|
expiration = '24h' unless %w[1h 12h 24h permanent].include?(expiration)
|
|
|
|
expires_at = case expiration
|
|
when '1h' then 1.hour.from_now
|
|
when '12h' then 12.hours.from_now
|
|
when '24h' then 24.hours.from_now
|
|
when 'permanent' then nil
|
|
end
|
|
|
|
settings = {
|
|
'enabled' => true,
|
|
'expiration' => expiration,
|
|
'expires_at' => expires_at&.iso8601
|
|
}
|
|
|
|
# Merge additional options (like share_notes, share_photos)
|
|
settings.merge!(options.stringify_keys)
|
|
|
|
update!(
|
|
sharing_settings: settings,
|
|
sharing_uuid: sharing_uuid || SecureRandom.uuid
|
|
)
|
|
end
|
|
|
|
def disable_sharing!
|
|
update!(
|
|
sharing_settings: {
|
|
'enabled' => false,
|
|
'expiration' => nil,
|
|
'expires_at' => nil
|
|
}
|
|
)
|
|
end
|
|
|
|
def share_notes?
|
|
sharing_settings.try(:[], 'share_notes') == true
|
|
end
|
|
|
|
def share_photos?
|
|
sharing_settings.try(:[], 'share_photos') == true
|
|
end
|
|
|
|
private
|
|
|
|
def generate_sharing_uuid
|
|
self.sharing_uuid ||= SecureRandom.uuid
|
|
end
|
|
end
|