mirror of
https://github.com/Freika/dawarich.git
synced 2026-01-12 02:01:39 -05:00
9fba3ce4ca
Simplifies architecture by using the existing trips#update route for sharing settings management instead of a separate route. ## Changes **Routes** - Removed: PATCH /trips/:id/sharing → shared/trips#update - Now uses: PATCH /trips/:id (existing route) with sharing params **Controllers** - Shared::TripsController: Simplified to only handle public view (show) - TripsController: Added update_sharing private method to handle sharing params when present **Views** - Updated JavaScript in _sharing.html.erb to use trip_path with nested sharing params **Tests** - Updated request specs to use trip_path instead of sharing_trip_path - All params now nested under sharing key ## Benefits - Cleaner namespace separation (Shared:: only for public access) - Follows Rails conventions (one update route handles everything) - Simpler routing structure - Reduced code duplication ## Backwards Compatibility This is a breaking change for the sharing API endpoint, but since this feature was just implemented and hasn't been released yet, no migration path is needed. |
||
|---|---|---|
| .. | ||
| api/v1 | ||
| family | ||
| settings | ||
| shared | ||
| users | ||
| authentication_spec.rb | ||
| exports_spec.rb | ||
| families_spec.rb | ||
| family_workflows_spec.rb | ||
| home_spec.rb | ||
| imports_spec.rb | ||
| map_spec.rb | ||
| notifications_spec.rb | ||
| places_spec.rb | ||
| points_spec.rb | ||
| settings_spec.rb | ||
| sidekiq_spec.rb | ||
| stats_spec.rb | ||
| trips_spec.rb | ||
| users_spec.rb | ||
| visits_spec.rb | ||