dawarich/spec/requests
Claude b1cbb5555f
Refactor: Apply Rails best practices to trip sharing implementation
- Remove unused @is_public_view variable from controller
- Simplify conditionals by leveraging methods that return [] when empty
- Move public view from trips/public_show to shared/trips/show (Rails conventions)
- Refactor trips#update to be HTML-only (remove JSON responses)
- Convert sharing form to use proper Rails form helpers
- Move JS controller to shared/ subdirectory with proper namespacing
- Create RSpec shared examples for Shareable concern to eliminate duplication
- Update request specs to match HTML-only controller behavior
- Apply 'render/redirect ... and return' pattern for early returns
2025-11-07 12:05:34 +00:00
..
api/v1 Fix failed specs 2025-09-23 00:18:04 +02:00
family Refactor family invitations and memberships into separate models and controllers 2025-10-07 18:38:06 +02:00
settings Fix failing specs 2025-09-13 17:46:45 +02:00
shared Refactor: Apply Rails best practices to trip sharing implementation 2025-11-07 12:05:34 +00:00
users Move UTM parameter tracking logic into a concern 2025-10-30 19:59:31 +01:00
authentication_spec.rb Make sure family invitations are handled after sign-in 2025-10-22 21:36:51 +02:00
exports_spec.rb Extract stats sharing logic to its own controller 2025-09-12 21:08:45 +02:00
families_spec.rb Refactor family invitations and memberships into separate models and controllers 2025-10-07 18:38:06 +02:00
family_workflows_spec.rb Refactor family invitations and memberships into separate models and controllers 2025-10-07 18:38:06 +02:00
home_spec.rb Enable home spec back 2025-05-18 11:45:45 +02:00
imports_spec.rb Fix tests 2025-09-13 12:28:43 +02:00
map_spec.rb Introduce uniqueness index and validation for points 2025-01-20 17:59:13 +01:00
notifications_spec.rb Add spec for marking all notifications as read 2024-07-04 23:01:24 +02:00
places_spec.rb Add places page 2024-08-25 20:19:02 +02:00
points_spec.rb Add spec for no points selected. 2025-07-26 14:46:53 +02:00
settings_spec.rb Fixes for visits suggestions. 2025-07-02 23:50:32 +02:00
sidekiq_spec.rb Return sidekiq and redis to Dawarich 2025-06-09 13:39:25 +02:00
stats_spec.rb Extract hexagon query to separate class 2025-09-12 21:38:25 +02:00
trips_spec.rb Extract stats sharing logic to its own controller 2025-09-12 21:08:45 +02:00
users_spec.rb Fix tests 2025-10-04 20:31:36 +02:00
visits_spec.rb Fix specs 2024-12-11 14:42:26 +01:00