dawarich/e2e/v2/map/layers/points.spec.js
Evgenii Burmakin c8242ce902
0.36.3 (#2013)
* fix: move foreman to global gems to fix startup crash (#1971)

* Update exporting code to stream points data to file in batches to red… (#1980)

* Update exporting code to stream points data to file in batches to reduce memory usage

* Update changelog

* Update changelog

* Feature/maplibre frontend (#1953)

* Add a plan to use MapLibre GL JS for the frontend map rendering, replacing Leaflet

* Implement phase 1

* Phases 1-3 + part of 4

* Fix e2e tests

* Phase 6

* Implement fog of war

* Phase 7

* Next step: fix specs, phase 7 done

* Use our own map tiles

* Extract v2 map logic to separate manager classes

* Update settings panel on v2 map

* Update v2 e2e tests structure

* Reimplement location search in maps v2

* Update speed routes

* Implement visits and places creation in v2

* Fix last failing test

* Implement visits merging

* Fix a routes e2e test and simplify the routes layer styling.

* Extract js to modules from maps_v2_controller.js

* Implement area creation

* Fix spec problem

* Fix some e2e tests

* Implement live mode in v2 map

* Update icons and panel

* Extract some styles

* Remove unused file

* Start adding dark theme to popups on MapLibre maps

* Make popups respect dark theme

* Move v2 maps to maplibre namespace

* Update v2 references to maplibre

* Put place, area and visit info into side panel

* Update API to use safe settings config method

* Fix specs

* Fix method name to config in SafeSettings and update usages accordingly

* Add missing public files

* Add handling for real time points

* Fix remembering enabled/disabled layers of the v2 map

* Fix lots of e2e tests

* Add settings to select map version

* Use maps/v2 as main path for MapLibre maps

* Update routing

* Update live mode

* Update maplibre controller

* Update changelog

* Remove some console.log statements

* Pull only necessary data for map v2 points

* Feature/raw data archive (#2009)

* 0.36.2 (#2007)

* fix: move foreman to global gems to fix startup crash (#1971)

* Update exporting code to stream points data to file in batches to red… (#1980)

* Update exporting code to stream points data to file in batches to reduce memory usage

* Update changelog

* Update changelog

* Feature/maplibre frontend (#1953)

* Add a plan to use MapLibre GL JS for the frontend map rendering, replacing Leaflet

* Implement phase 1

* Phases 1-3 + part of 4

* Fix e2e tests

* Phase 6

* Implement fog of war

* Phase 7

* Next step: fix specs, phase 7 done

* Use our own map tiles

* Extract v2 map logic to separate manager classes

* Update settings panel on v2 map

* Update v2 e2e tests structure

* Reimplement location search in maps v2

* Update speed routes

* Implement visits and places creation in v2

* Fix last failing test

* Implement visits merging

* Fix a routes e2e test and simplify the routes layer styling.

* Extract js to modules from maps_v2_controller.js

* Implement area creation

* Fix spec problem

* Fix some e2e tests

* Implement live mode in v2 map

* Update icons and panel

* Extract some styles

* Remove unused file

* Start adding dark theme to popups on MapLibre maps

* Make popups respect dark theme

* Move v2 maps to maplibre namespace

* Update v2 references to maplibre

* Put place, area and visit info into side panel

* Update API to use safe settings config method

* Fix specs

* Fix method name to config in SafeSettings and update usages accordingly

* Add missing public files

* Add handling for real time points

* Fix remembering enabled/disabled layers of the v2 map

* Fix lots of e2e tests

* Add settings to select map version

* Use maps/v2 as main path for MapLibre maps

* Update routing

* Update live mode

* Update maplibre controller

* Update changelog

* Remove some console.log statements

---------

Co-authored-by: Robin Tuszik <mail@robin.gg>

* Remove esbuild scripts from package.json

* Remove sideEffects field from package.json

* Raw data archivation

* Add tests

* Fix tests

* Fix tests

* Update ExceptionReporter

* Add schedule to run raw data archival job monthly

* Change file structure for raw data archival feature

* Update changelog and version for raw data archival feature

---------

Co-authored-by: Robin Tuszik <mail@robin.gg>

* Set raw_data to an empty hash instead of nil when archiving

* Fix storage configuration and file extraction

* Consider MIN_MINUTES_SPENT_IN_CITY during stats calculation (#2018)

* Consider MIN_MINUTES_SPENT_IN_CITY during stats calculation

* Remove raw data from visited cities api endpoint

* Use user timezone to show dates on maps (#2020)

* Fix/pre epoch time (#2019)

* Use user timezone to show dates on maps

* Limit timestamps to valid range to prevent database errors when users enter pre-epoch dates.

* Limit timestamps to valid range to prevent database errors when users enter pre-epoch dates.

* Fix tests failing due to new index on stats table

* Fix failing specs

* Update redis client configuration to support unix socket connection

* Update changelog

* Fix kml kmz import issues (#2023)

* Fix kml kmz import issues

* Refactor KML importer to improve readability and maintainability

* Implement moving points in map v2 and fix route rendering logic to ma… (#2027)

* Implement moving points in map v2 and fix route rendering logic to match map v1.

* Fix route spec

* fix(maplibre): update date format to ISO 8601 (#2029)

* Add verification step to raw data archival process (#2028)

* Add verification step to raw data archival process

* Add actual verification of raw data archives after creation, and only clear raw_data for verified archives.

* Fix failing specs

* Eliminate zip-bomb risk

* Fix potential memory leak in js

* Return .keep files

* Use Toast instead of alert for notifications

* Add help section to navbar dropdown

* Update changelog

* Remove raw_data_archival_job

* Ensure file is being closed properly after reading in Archivable concern

---------

Co-authored-by: Robin Tuszik <mail@robin.gg>
2025-12-14 12:05:59 +01:00

492 lines
18 KiB
JavaScript

import { test, expect } from '@playwright/test'
import { closeOnboardingModal } from '../../../helpers/navigation.js'
import {
navigateToMapsV2WithDate,
waitForLoadingComplete,
hasLayer,
getPointsSourceData,
getRoutesSourceData
} from '../../helpers/setup.js'
test.describe('Points Layer', () => {
test.beforeEach(async ({ page }) => {
await page.goto('/map/v2?start_at=2025-10-15T00:00&end_at=2025-10-15T23:59')
await closeOnboardingModal(page)
await waitForLoadingComplete(page)
await page.waitForTimeout(1500)
})
test.describe('Display', () => {
test('displays points layer', async ({ page }) => {
// Wait for points layer to be added
await page.waitForFunction(() => {
const element = document.querySelector('[data-controller*="maps--maplibre"]')
const app = window.Stimulus || window.Application
const controller = app?.getControllerForElementAndIdentifier(element, 'maps--maplibre')
return controller?.map?.getLayer('points') !== undefined
}, { timeout: 10000 }).catch(() => false)
const hasPoints = await hasLayer(page, 'points')
expect(hasPoints).toBe(true)
})
test('loads and displays point data', async ({ page }) => {
await page.waitForFunction(() => {
const element = document.querySelector('[data-controller*="maps--maplibre"]')
const app = window.Stimulus || window.Application
const controller = app?.getControllerForElementAndIdentifier(element, 'maps--maplibre')
return controller?.map?.getSource('points-source') !== undefined
}, { timeout: 15000 }).catch(() => false)
const sourceData = await getPointsSourceData(page)
expect(sourceData.hasSource).toBe(true)
expect(sourceData.featureCount).toBeGreaterThan(0)
})
})
test.describe('Data Source', () => {
test('points source contains valid GeoJSON features', async ({ page }) => {
// Wait for source to be added
await page.waitForFunction(() => {
const element = document.querySelector('[data-controller*="maps--maplibre"]')
const app = window.Stimulus || window.Application
const controller = app?.getControllerForElementAndIdentifier(element, 'maps--maplibre')
return controller?.map?.getSource('points-source') !== undefined
}, { timeout: 10000 }).catch(() => false)
const sourceData = await getPointsSourceData(page)
expect(sourceData.hasSource).toBe(true)
expect(sourceData.features).toBeDefined()
expect(Array.isArray(sourceData.features)).toBe(true)
if (sourceData.features.length > 0) {
const firstFeature = sourceData.features[0]
expect(firstFeature.type).toBe('Feature')
expect(firstFeature.geometry).toBeDefined()
expect(firstFeature.geometry.type).toBe('Point')
expect(firstFeature.geometry.coordinates).toHaveLength(2)
}
})
})
test.describe('Dragging', () => {
test('allows dragging points to new positions', async ({ page }) => {
// Wait for points to load
await page.waitForFunction(() => {
const element = document.querySelector('[data-controller*="maps--maplibre"]')
const app = window.Stimulus || window.Application
const controller = app?.getControllerForElementAndIdentifier(element, 'maps--maplibre')
const source = controller?.map?.getSource('points-source')
return source?._data?.features?.length > 0
}, { timeout: 15000 })
// Get initial point data
const initialData = await getPointsSourceData(page)
expect(initialData.features.length).toBeGreaterThan(0)
// Get the map canvas bounds
const canvas = page.locator('.maplibregl-canvas')
const canvasBounds = await canvas.boundingBox()
expect(canvasBounds).not.toBeNull()
// Ensure points layer is visible before testing dragging
const layerState = await page.evaluate(() => {
const element = document.querySelector('[data-controller*="maps--maplibre"]')
const app = window.Stimulus || window.Application
const controller = app.getControllerForElementAndIdentifier(element, 'maps--maplibre')
const pointsLayer = controller?.layerManager?.layers?.pointsLayer
if (!pointsLayer) {
return { exists: false, visibleBefore: false, visibleAfter: false, draggingEnabled: false }
}
const visibilityBefore = controller.map.getLayoutProperty('points', 'visibility')
const isVisibleBefore = visibilityBefore === 'visible' || visibilityBefore === undefined
// If not visible, make it visible
if (!isVisibleBefore) {
pointsLayer.show()
}
// Check again after calling show
const visibilityAfter = controller.map.getLayoutProperty('points', 'visibility')
const isVisibleAfter = visibilityAfter === 'visible' || visibilityAfter === undefined
return {
exists: true,
visibleBefore: isVisibleBefore,
visibleAfter: isVisibleAfter,
draggingEnabled: pointsLayer.draggingEnabled || false
}
})
// Wait longer for layer to render after visibility change
await page.waitForTimeout(2000)
// Find a rendered point feature on the map and get its pixel coordinates
const renderedPoint = await page.evaluate(() => {
const element = document.querySelector('[data-controller*="maps--maplibre"]')
const app = window.Stimulus || window.Application
const controller = app.getControllerForElementAndIdentifier(element, 'maps--maplibre')
// Get all rendered point features
const features = controller.map.queryRenderedFeatures(undefined, { layers: ['points'] })
if (features.length === 0) {
return { found: false, totalFeatures: 0 }
}
// Pick the first rendered point
const feature = features[0]
const coords = feature.geometry.coordinates
const point = controller.map.project(coords)
// Get the canvas position on the page
const canvas = controller.map.getCanvas()
const rect = canvas.getBoundingClientRect()
return {
found: true,
totalFeatures: features.length,
pointId: feature.properties.id,
coords: coords,
x: point.x,
y: point.y,
pageX: rect.left + point.x,
pageY: rect.top + point.y
}
})
expect(renderedPoint.found).toBe(true)
expect(renderedPoint.totalFeatures).toBeGreaterThan(0)
const pointId = renderedPoint.pointId
const initialCoords = renderedPoint.coords
const pointPixel = {
x: renderedPoint.x,
y: renderedPoint.y,
pageX: renderedPoint.pageX,
pageY: renderedPoint.pageY
}
// Drag the point by 100 pixels to the right and 100 down (larger movement for visibility)
const dragOffset = { x: 100, y: 100 }
const startX = pointPixel.pageX
const startY = pointPixel.pageY
const endX = startX + dragOffset.x
const endY = startY + dragOffset.y
// Check cursor style on hover
await page.mouse.move(startX, startY)
await page.waitForTimeout(200)
const cursorStyle = await page.evaluate(() => {
const canvas = document.querySelector('.maplibregl-canvas-container')
return window.getComputedStyle(canvas).cursor
})
// Perform the drag operation with slower movement
await page.mouse.down()
await page.waitForTimeout(100)
await page.mouse.move(endX, endY, { steps: 20 })
await page.waitForTimeout(100)
await page.mouse.up()
// Wait for API call to complete
await page.waitForTimeout(3000)
// Get updated point data
const updatedData = await getPointsSourceData(page)
const updatedPoint = updatedData.features.find(f => f.properties.id === pointId)
expect(updatedPoint).toBeDefined()
const updatedCoords = updatedPoint.geometry.coordinates
// Verify the point has moved (parse coordinates as numbers)
const updatedLng = parseFloat(updatedCoords[0])
const updatedLat = parseFloat(updatedCoords[1])
const initialLng = parseFloat(initialCoords[0])
const initialLat = parseFloat(initialCoords[1])
expect(updatedLng).not.toBeCloseTo(initialLng, 5)
expect(updatedLat).not.toBeCloseTo(initialLat, 5)
})
test('updates connected route segments when point is dragged', async ({ page }) => {
// Wait for both points and routes to load
await page.waitForFunction(() => {
const element = document.querySelector('[data-controller*="maps--maplibre"]')
const app = window.Stimulus || window.Application
const controller = app?.getControllerForElementAndIdentifier(element, 'maps--maplibre')
const pointsSource = controller?.map?.getSource('points-source')
const routesSource = controller?.map?.getSource('routes-source')
return pointsSource?._data?.features?.length > 0 &&
routesSource?._data?.features?.length > 0
}, { timeout: 15000 })
// Ensure points layer is visible
await page.evaluate(() => {
const element = document.querySelector('[data-controller*="maps--maplibre"]')
const app = window.Stimulus || window.Application
const controller = app.getControllerForElementAndIdentifier(element, 'maps--maplibre')
const pointsLayer = controller?.layerManager?.layers?.pointsLayer
if (pointsLayer) {
const visibility = controller.map.getLayoutProperty('points', 'visibility')
if (visibility === 'none') {
pointsLayer.show()
}
}
})
await page.waitForTimeout(2000)
// Get initial data
const initialRoutesData = await getRoutesSourceData(page)
expect(initialRoutesData.features.length).toBeGreaterThan(0)
// Find a rendered point feature on the map
const renderedPoint = await page.evaluate(() => {
const element = document.querySelector('[data-controller*="maps--maplibre"]')
const app = window.Stimulus || window.Application
const controller = app.getControllerForElementAndIdentifier(element, 'maps--maplibre')
// Get all rendered point features
const features = controller.map.queryRenderedFeatures(undefined, { layers: ['points'] })
if (features.length === 0) {
return { found: false }
}
// Pick the first rendered point
const feature = features[0]
const coords = feature.geometry.coordinates
const point = controller.map.project(coords)
// Get the canvas position on the page
const canvas = controller.map.getCanvas()
const rect = canvas.getBoundingClientRect()
return {
found: true,
pointId: feature.properties.id,
coords: coords,
x: point.x,
y: point.y,
pageX: rect.left + point.x,
pageY: rect.top + point.y
}
})
expect(renderedPoint.found).toBe(true)
const pointId = renderedPoint.pointId
const initialCoords = renderedPoint.coords
const pointPixel = {
x: renderedPoint.x,
y: renderedPoint.y,
pageX: renderedPoint.pageX,
pageY: renderedPoint.pageY
}
// Find routes that contain this point
const connectedRoutes = initialRoutesData.features.filter(route => {
return route.geometry.coordinates.some(coord =>
Math.abs(coord[0] - initialCoords[0]) < 0.0001 &&
Math.abs(coord[1] - initialCoords[1]) < 0.0001
)
})
const dragOffset = { x: 100, y: 100 }
const startX = pointPixel.pageX
const startY = pointPixel.pageY
const endX = startX + dragOffset.x
const endY = startY + dragOffset.y
// Perform drag with slower movement
await page.mouse.move(startX, startY)
await page.waitForTimeout(100)
await page.mouse.down()
await page.waitForTimeout(100)
await page.mouse.move(endX, endY, { steps: 20 })
await page.waitForTimeout(100)
await page.mouse.up()
// Wait for updates
await page.waitForTimeout(3000)
// Get updated data
const updatedPointsData = await getPointsSourceData(page)
const updatedRoutesData = await getRoutesSourceData(page)
const updatedPoint = updatedPointsData.features.find(f => f.properties.id === pointId)
const updatedCoords = updatedPoint.geometry.coordinates
// Verify routes have been updated
const updatedConnectedRoutes = updatedRoutesData.features.filter(route => {
return route.geometry.coordinates.some(coord =>
Math.abs(coord[0] - updatedCoords[0]) < 0.0001 &&
Math.abs(coord[1] - updatedCoords[1]) < 0.0001
)
})
// Routes that were originally connected should now be at the new position
if (connectedRoutes.length > 0) {
expect(updatedConnectedRoutes.length).toBeGreaterThan(0)
}
// The point moved, so verify the coordinates actually changed
const lngChanged = Math.abs(parseFloat(updatedCoords[0]) - initialCoords[0]) > 0.0001
const latChanged = Math.abs(parseFloat(updatedCoords[1]) - initialCoords[1]) > 0.0001
expect(lngChanged || latChanged).toBe(true)
// Since the route segments update is best-effort (depends on coordinate matching),
// we'll just verify that routes exist and the point moved
})
test('persists point position after page reload', async ({ page }) => {
// Wait for points to load
await page.waitForFunction(() => {
const element = document.querySelector('[data-controller*="maps--maplibre"]')
const app = window.Stimulus || window.Application
const controller = app?.getControllerForElementAndIdentifier(element, 'maps--maplibre')
const source = controller?.map?.getSource('points-source')
return source?._data?.features?.length > 0
}, { timeout: 15000 })
// Ensure points layer is visible
await page.evaluate(() => {
const element = document.querySelector('[data-controller*="maps--maplibre"]')
const app = window.Stimulus || window.Application
const controller = app.getControllerForElementAndIdentifier(element, 'maps--maplibre')
const pointsLayer = controller?.layerManager?.layers?.pointsLayer
if (pointsLayer) {
const visibility = controller.map.getLayoutProperty('points', 'visibility')
if (visibility === 'none') {
pointsLayer.show()
}
}
})
await page.waitForTimeout(2000)
// Find a rendered point feature on the map
const renderedPoint = await page.evaluate(() => {
const element = document.querySelector('[data-controller*="maps--maplibre"]')
const app = window.Stimulus || window.Application
const controller = app.getControllerForElementAndIdentifier(element, 'maps--maplibre')
// Get all rendered point features
const features = controller.map.queryRenderedFeatures(undefined, { layers: ['points'] })
if (features.length === 0) {
return { found: false }
}
// Pick the first rendered point
const feature = features[0]
const coords = feature.geometry.coordinates
const point = controller.map.project(coords)
// Get the canvas position on the page
const canvas = controller.map.getCanvas()
const rect = canvas.getBoundingClientRect()
return {
found: true,
pointId: feature.properties.id,
coords: coords,
x: point.x,
y: point.y,
pageX: rect.left + point.x,
pageY: rect.top + point.y
}
})
expect(renderedPoint.found).toBe(true)
const pointId = renderedPoint.pointId
const initialCoords = renderedPoint.coords
const pointPixel = {
x: renderedPoint.x,
y: renderedPoint.y,
pageX: renderedPoint.pageX,
pageY: renderedPoint.pageY
}
const dragOffset = { x: 100, y: 100 }
const startX = pointPixel.pageX
const startY = pointPixel.pageY
const endX = startX + dragOffset.x
const endY = startY + dragOffset.y
// Perform drag with slower movement
await page.mouse.move(startX, startY)
await page.waitForTimeout(100)
await page.mouse.down()
await page.waitForTimeout(100)
await page.mouse.move(endX, endY, { steps: 20 })
await page.waitForTimeout(100)
await page.mouse.up()
// Wait for API call
await page.waitForTimeout(3000)
// Get the new position
const afterDragData = await getPointsSourceData(page)
const afterDragPoint = afterDragData.features.find(f => f.properties.id === pointId)
const afterDragCoords = afterDragPoint.geometry.coordinates
// Reload the page
await page.reload()
await closeOnboardingModal(page)
await waitForLoadingComplete(page)
await page.waitForTimeout(1500)
// Wait for points to reload
await page.waitForFunction(() => {
const element = document.querySelector('[data-controller*="maps--maplibre"]')
const app = window.Stimulus || window.Application
const controller = app?.getControllerForElementAndIdentifier(element, 'maps--maplibre')
const source = controller?.map?.getSource('points-source')
return source?._data?.features?.length > 0
}, { timeout: 15000 })
// Get point after reload
const afterReloadData = await getPointsSourceData(page)
const afterReloadPoint = afterReloadData.features.find(f => f.properties.id === pointId)
const afterReloadCoords = afterReloadPoint.geometry.coordinates
// Verify the position persisted (parse coordinates as numbers)
const reloadLng = parseFloat(afterReloadCoords[0])
const reloadLat = parseFloat(afterReloadCoords[1])
const dragLng = parseFloat(afterDragCoords[0])
const dragLat = parseFloat(afterDragCoords[1])
const initialLng = parseFloat(initialCoords[0])
const initialLat = parseFloat(initialCoords[1])
// Position after reload should match position after drag (high precision)
expect(reloadLng).toBeCloseTo(dragLng, 5)
expect(reloadLat).toBeCloseTo(dragLat, 5)
// And it should be different from the initial position (lower precision - just verify it moved)
const lngDiff = Math.abs(reloadLng - initialLng)
const latDiff = Math.abs(reloadLat - initialLat)
const moved = lngDiff > 0.00001 || latDiff > 0.00001
expect(moved).toBe(true)
})
})
})