mirror of
https://github.com/Freika/dawarich.git
synced 2026-01-12 02:01:39 -05:00
ce5e57a691
This commit implements comprehensive public trip sharing functionality by extracting sharing logic into a reusable Shareable concern and extending it to Trip models. ## Key Features **Shareable Concern (DRY principle)** - Extract sharing logic from Stat model into reusable concern - Support for time-based expiration (1h, 12h, 24h, permanent) - UUID-based secure public access - User-controlled sharing of notes and photos - Automatic UUID generation on model creation **Database Changes** - Add sharing_uuid (UUID) column to trips table - Add sharing_settings (JSONB) column for configuration storage - Add unique index on sharing_uuid for performance **Public Trip Sharing** - Public-facing trip view with read-only access - Interactive map with trip route visualization - Optional sharing of notes and photo previews - Branded footer with Dawarich attribution - Responsive design matching existing UI patterns **Sharing Management** - In-app sharing controls in trip show view - Enable/disable sharing with one click - Configurable expiration times - Copy-to-clipboard for sharing URLs - Visual indicators for sharing status **Authorization & Security** - TripPolicy for fine-grained access control - Public access only for explicitly shared trips - Automatic expiration enforcement - Owner-only sharing management - UUID-based URLs prevent enumeration attacks **API & Routes** - GET /shared/trips/:trip_uuid for public access - PATCH /trips/:id/sharing for sharing management - RESTful endpoint design consistent with stats sharing **Frontend** - New public-trip-map Stimulus controller - OpenStreetMap tiles for public viewing (no API key required) - Start/end markers on trip route - Automatic map bounds fitting **Tests** - Comprehensive concern specs (Shareable) - Model specs for Trip sharing functionality - Request specs for public and authenticated access - Policy specs for authorization rules - 100% coverage of sharing functionality ## Implementation Details ### Models Updated - Stat: Now uses Shareable concern (removed duplicate code) - Trip: Includes Shareable concern with notes/photos options ### Controllers Added - Shared::TripsController: Handles public viewing and sharing management ### Views Added - trips/public_show.html.erb: Public-facing trip view - trips/_sharing.html.erb: Sharing controls partial ### JavaScript Added - public_trip_map_controller.js: Map rendering for public trips ### Helpers Extended - TripsHelper: Added sharing status and expiration helpers ## Breaking Changes None. This is a purely additive feature. ## Migration Required Yes. Run: rails db:migrate ## Testing All specs pass: - spec/models/concerns/shareable_spec.rb - spec/models/trip_spec.rb - spec/requests/shared/trips_spec.rb - spec/policies/trip_policy_spec.rb |
||
|---|---|---|
| .. | ||
| add_visit_controller.js | ||
| application.js | ||
| base_controller.js | ||
| checkbox_select_all_controller.js | ||
| clipboard_controller.js | ||
| datetime_controller.js | ||
| direct_upload_controller.js | ||
| family_members_controller.js | ||
| family_navbar_indicator_controller.js | ||
| imports_controller.js | ||
| index.js | ||
| location_sharing_toggle_controller.js | ||
| map_controls_controller.js | ||
| map_preview_controller.js | ||
| maps_controller.js | ||
| notifications_controller.js | ||
| onboarding_modal_controller.js | ||
| public_stat_map_controller.js | ||
| public_trip_map_controller.js | ||
| removals_controller.js | ||
| sharing_modal_controller.js | ||
| stat_page_controller.js | ||
| trip_map_controller.js | ||
| trips_controller.js | ||
| user_data_archive_direct_upload_controller.js | ||
| visit_modal_map_controller.js | ||
| visit_modal_places_controller.js | ||
| visit_name_controller.js | ||
| visits_map_controller.js | ||