dawarich/spec
Claude b1cbb5555f
Refactor: Apply Rails best practices to trip sharing implementation
- Remove unused @is_public_view variable from controller
- Simplify conditionals by leveraging methods that return [] when empty
- Move public view from trips/public_show to shared/trips/show (Rails conventions)
- Refactor trips#update to be HTML-only (remove JSON responses)
- Convert sharing form to use proper Rails form helpers
- Move JS controller to shared/ subdirectory with proper namespacing
- Create RSpec shared examples for Shareable concern to eliminate duplication
- Update request specs to match HTML-only controller behavior
- Apply 'render/redirect ... and return' pattern for early returns
2025-11-07 12:05:34 +00:00
..
channels Add incremental track generation 2025-07-07 21:48:07 +02:00
factories Refactor family invitations and memberships into separate models and controllers 2025-10-07 18:38:06 +02:00
fixtures Fix import detection 2025-08-23 16:07:15 +02:00
jobs Update stuff, fix stuff 2025-09-29 22:27:07 +02:00
lib Update json_stream_handler_spec.rb path and remove tmp.json 2025-10-05 21:01:34 +02:00
mailers Update onborading popup 2025-09-18 18:29:46 +02:00
models Refactor: Apply Rails best practices to trip sharing implementation 2025-11-07 12:05:34 +00:00
policies Implement public trip sharing with Shareable concern 2025-11-05 15:44:27 +00:00
queries Reimplement hexagons with H3 2025-09-17 01:55:42 +02:00
requests Refactor: Apply Rails best practices to trip sharing implementation 2025-11-07 12:05:34 +00:00
serializers Update stuff, fix stuff 2025-09-29 22:27:07 +02:00
services Remember enabled map layers for users 2025-10-20 20:11:28 +02:00
support Refactor: Apply Rails best practices to trip sharing implementation 2025-11-07 12:05:34 +00:00
swagger/api/v1 Add swagger spec for visits api 2025-08-21 20:53:23 +02:00
system Update onborading popup 2025-09-18 18:29:46 +02:00
tasks Fix failed specs 2025-01-21 19:32:12 +01:00
rails_helper.rb Clean up some mess 2025-07-20 18:57:53 +02:00
spec_helper.rb Add spec for CheckAppVersion service 2024-04-25 22:40:51 +02:00
swagger_helper.rb Add swagger along with api/v1/points swagger doc 2024-05-18 13:35:48 +02:00