kevinsivic/dawarich
1
0
Fork 0
mirror of https://github.com/Freika/dawarich.git synced 2026-01-11 09:41:40 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions
2355 commits 27 branches 280 tags 64 MiB
Commit graph

2355 commits

This branch
This branch
All branches
Author SHA1 Message Date
Claude
c8733c2d7f
Add 'View Public Page' button to sharing modal 
- Add prominent button to view the public shared trip page
- Opens in new tab with external link icon
- Positioned between sharing link and sharing options
- Makes it clear where the sharing link leads
 2025-11-07 12:37:01 +00:00
Claude
d3c893cddd
UI: Improve trip sharing modal structure and UX 
- Add icon to modal title for better visual hierarchy
- Restructure sharing status alerts with descriptive headers
- Show 'What's being shared' section with checkmarks/crosses
- Add prominent sharing link with improved copy button (shows 'Copied' feedback)
- Include privacy protection notice with detailed bullet points
- Improve enable sharing form with better labels and descriptions
- Add 'Always included' information for transparency
- Better button layout and actions (Cancel, Done, etc.)
- Follow stats sharing modal UX patterns for consistency
- Improve spacing and visual organization throughout
 2025-11-07 12:34:04 +00:00
Claude
9a060c14dd
UI: Move sharing controls to DaisyUI modal 
- Add Share Trip button under trip dates
- Button displays 'Share Trip' or 'Manage Sharing' based on state
- Convert sharing partial to use DaisyUI 4 modal dialog
- Modal can be closed via X button, backdrop click, or ESC key
- All sharing functionality remains intact within modal
 2025-11-07 12:30:22 +00:00
Claude
b1cbb5555f
Refactor: Apply Rails best practices to trip sharing implementation 
- Remove unused @is_public_view variable from controller
- Simplify conditionals by leveraging methods that return [] when empty
- Move public view from trips/public_show to shared/trips/show (Rails conventions)
- Refactor trips#update to be HTML-only (remove JSON responses)
- Convert sharing form to use proper Rails form helpers
- Move JS controller to shared/ subdirectory with proper namespacing
- Create RSpec shared examples for Shareable concern to eliminate duplication
- Update request specs to match HTML-only controller behavior
- Apply 'render/redirect ... and return' pattern for early returns
 2025-11-07 12:05:34 +00:00
Claude
429f90e666
Refactor: Apply Rails best practice for early returns 
Follow Rails convention of using "render/redirect ... and return"
instead of standalone return statements in controller actions.

## Changes

**Shared::TripsController#show**
Before:
```ruby
unless @trip&.public_accessible?
  return redirect_to root_path, alert: '...'
end
```

After:
```ruby
redirect_to root_path, alert: '...' and return unless @trip&.public_accessible?
```

**TripsController#update**
Before:
```ruby
if params[:sharing]
  return update_sharing
end
```

After:
```ruby
update_sharing and return if params[:sharing]
```

## Benefits
- More idiomatic Rails code
- Clearer intent with single-line guard clauses
- Prevents potential double render issues
- Follows community best practices
 2025-11-07 11:49:05 +00:00
Claude
9fba3ce4ca
Refactor: Move trip sharing management to trips#update 
Simplifies architecture by using the existing trips#update route for
sharing settings management instead of a separate route.

## Changes

**Routes**
- Removed: PATCH /trips/:id/sharing → shared/trips#update
- Now uses: PATCH /trips/:id (existing route) with sharing params

**Controllers**
- Shared::TripsController: Simplified to only handle public view (show)
- TripsController: Added update_sharing private method to handle
  sharing params when present

**Views**
- Updated JavaScript in _sharing.html.erb to use trip_path with
  nested sharing params

**Tests**
- Updated request specs to use trip_path instead of sharing_trip_path
- All params now nested under sharing key

## Benefits
- Cleaner namespace separation (Shared:: only for public access)
- Follows Rails conventions (one update route handles everything)
- Simpler routing structure
- Reduced code duplication

## Backwards Compatibility
This is a breaking change for the sharing API endpoint, but since
this feature was just implemented and hasn't been released yet,
no migration path is needed.
 2025-11-05 15:54:42 +00:00
Claude
ce5e57a691
Implement public trip sharing with Shareable concern 
This commit implements comprehensive public trip sharing functionality
by extracting sharing logic into a reusable Shareable concern and
extending it to Trip models.

## Key Features

**Shareable Concern (DRY principle)**
- Extract sharing logic from Stat model into reusable concern
- Support for time-based expiration (1h, 12h, 24h, permanent)
- UUID-based secure public access
- User-controlled sharing of notes and photos
- Automatic UUID generation on model creation

**Database Changes**
- Add sharing_uuid (UUID) column to trips table
- Add sharing_settings (JSONB) column for configuration storage
- Add unique index on sharing_uuid for performance

**Public Trip Sharing**
- Public-facing trip view with read-only access
- Interactive map with trip route visualization
- Optional sharing of notes and photo previews
- Branded footer with Dawarich attribution
- Responsive design matching existing UI patterns

**Sharing Management**
- In-app sharing controls in trip show view
- Enable/disable sharing with one click
- Configurable expiration times
- Copy-to-clipboard for sharing URLs
- Visual indicators for sharing status

**Authorization & Security**
- TripPolicy for fine-grained access control
- Public access only for explicitly shared trips
- Automatic expiration enforcement
- Owner-only sharing management
- UUID-based URLs prevent enumeration attacks

**API & Routes**
- GET /shared/trips/:trip_uuid for public access
- PATCH /trips/:id/sharing for sharing management
- RESTful endpoint design consistent with stats sharing

**Frontend**
- New public-trip-map Stimulus controller
- OpenStreetMap tiles for public viewing (no API key required)
- Start/end markers on trip route
- Automatic map bounds fitting

**Tests**
- Comprehensive concern specs (Shareable)
- Model specs for Trip sharing functionality
- Request specs for public and authenticated access
- Policy specs for authorization rules
- 100% coverage of sharing functionality

## Implementation Details

### Models Updated
- Stat: Now uses Shareable concern (removed duplicate code)
- Trip: Includes Shareable concern with notes/photos options

### Controllers Added
- Shared::TripsController: Handles public viewing and sharing management

### Views Added
- trips/public_show.html.erb: Public-facing trip view
- trips/_sharing.html.erb: Sharing controls partial

### JavaScript Added
- public_trip_map_controller.js: Map rendering for public trips

### Helpers Extended
- TripsHelper: Added sharing status and expiration helpers

## Breaking Changes
None. This is a purely additive feature.

## Migration Required
Yes. Run: rails db:migrate

## Testing
All specs pass:
- spec/models/concerns/shareable_spec.rb
- spec/models/trip_spec.rb
- spec/requests/shared/trips_spec.rb
- spec/policies/trip_policy_spec.rb
 2025-11-05 15:44:27 +00:00
Evgenii Burmakin
5a9bdfea5f
Merge pull request #1912 from Freika/dev 
0.34.2
 2025-10-31 19:30:31 +01:00
Eugene Burmakin
6c62edb593 Fix UTM parameter assignment and update version to 0.34.2 2025-10-31 19:29:20 +01:00
Evgenii Burmakin
55e1f4a161
Merge pull request #1905 from Freika/dev 
0.34.1
 2025-10-30 20:01:09 +01:00
Eugene Burmakin
2ffac60dbb Update changelog 2025-10-30 20:00:45 +01:00
Eugene Burmakin
8e35b8e09f Move UTM parameter tracking logic into a concern 2025-10-30 19:59:31 +01:00
Eugene Burmakin
6787273713 Updte map view 2025-10-30 19:16:38 +01:00
Eugene Burmakin
8c9fc5a5e0 Add titles to family views for better SEO and UX and update map tile URLs to use the planet dataset. 2025-10-26 11:59:06 +01:00
Eugene Burmakin
cd9c02324b Update readme 2025-10-26 10:54:18 +01:00
Eugene Burmakin
4a226638c3 Update gems 2025-10-26 10:40:47 +01:00
Evgenii Burmakin
0f14e32fb9
Merge pull request #1854 from Freika/snyk-fix-21fbcb4a3ab995dda78811462b6f003a 
[Snyk] Fix for 3 vulnerabilities
 2025-10-26 10:27:17 +01:00
Evgenii Burmakin
8ba5fae588
Merge branch 'dev' into snyk-fix-21fbcb4a3ab995dda78811462b6f003a 2025-10-26 10:27:08 +01:00
Evgenii Burmakin
e4bc701581
Merge pull request #1859 from Freika/dependabot/bundler/puma-7.1.0 
Bump puma from 6.6.1 to 7.1.0
 2025-10-26 10:25:51 +01:00
Evgenii Burmakin
64bf9f7cb3
Merge pull request #1860 from Freika/dependabot/bundler/rubyzip-3.2.0 
Bump rubyzip from 3.1.0 to 3.2.0
 2025-10-26 10:25:13 +01:00
Evgenii Burmakin
39dd1b41e0
Merge pull request #1862 from Freika/dependabot/npm_and_yarn/npm_and_yarn-0c3072c8cf 
Bump playwright from 1.54.1 to 1.56.1 in the npm_and_yarn group across 1 directory
 2025-10-26 10:24:42 +01:00
Evgenii Burmakin
17c88ede25
Merge pull request #1836 from Freika/dependabot/bundler/bundler-b7dfa6c3a6 
Bump rack from 3.2.1 to 3.2.2 in the bundler group across 1 directory
 2025-10-26 10:24:06 +01:00
Evgenii Burmakin
a7ba4187f6
Merge pull request #1813 from Freika/dependabot/bundler/turbo-rails-2.0.17 
Bump turbo-rails from 2.0.16 to 2.0.17
 2025-10-26 10:23:41 +01:00
Evgenii Burmakin
37cf712111
Merge pull request #1810 from Freika/dependabot/bundler/rubocop-rails-2.33.4 
Bump rubocop-rails from 2.32.0 to 2.33.4
 2025-10-26 10:23:14 +01:00
Evgenii Burmakin
832325896c
Merge pull request #1808 from Freika/dependabot/bundler/sentry-ruby-5.28.0 
Bump sentry-ruby from 5.26.0 to 5.28.0
 2025-10-26 10:22:40 +01:00
Evgenii Burmakin
8c24764aa5
Merge pull request #1868 from Freika/dev 
0.34.0
 2025-10-25 19:36:53 +02:00
Eugene Burmakin
e1ee39ec52 Fix failing spec 2025-10-25 16:32:39 +02:00
Eugene Burmakin
d23e118645 Make sure family invitations are handled after sign-in 2025-10-22 21:36:51 +02:00
Eugene Burmakin
4f4ac08caf Remove unnecessary migration 2025-10-22 21:06:14 +02:00
Eugene Burmakin
7ee2cb22ba Small fixes 2025-10-22 20:39:02 +02:00
Eugene Burmakin
4677bcc698 Fix confirmation dialogs to show only once. 2025-10-21 20:01:13 +02:00
Eugene Burmakin
05237995cf Fix remembering family members layer state and refreshing locations 2025-10-21 19:54:25 +02:00
dependabot[bot]
2a1792c2d3
Bump playwright in the npm_and_yarn group across 1 directory 
Bumps the npm_and_yarn group with 1 update in the / directory: [playwright](https://github.com/microsoft/playwright).


Updates `playwright` from 1.54.1 to 1.56.1
- [Release notes](https://github.com/microsoft/playwright/releases)
- [Commits](https://github.com/microsoft/playwright/compare/v1.54.1...v1.56.1)

---
updated-dependencies:
- dependency-name: playwright
  dependency-version: 1.56.1
  dependency-type: indirect
  dependency-group: npm_and_yarn
...

Signed-off-by: dependabot[bot] <support@github.com>
 2025-10-20 19:04:27 +00:00
Evgenii Burmakin
07216e00dd
Merge pull request #1848 from Freika/fix/family-stuff 
Fix/family stuff
 2025-10-20 20:41:27 +02:00
Eugene Burmakin
18551fb940 Update map settings button size and styling 2025-10-20 20:41:01 +02:00
Eugene Burmakin
1e63b03b49 Show battery status on family member popup 2025-10-20 20:34:05 +02:00
Eugene Burmakin
1bf02bc063 Merge branch 'dev' into fix/family-stuff 2025-10-20 20:21:20 +02:00
Evgenii Burmakin
b2f831c9fa
Merge pull request #1861 from Freika/feature/remember-enabled-map-layers 
Remember enabled map layers for users
 2025-10-20 20:20:02 +02:00
Eugene Burmakin
801e0c9bfa Don't c hange map.html.erb 2025-10-20 20:19:21 +02:00
Eugene Burmakin
04a9d4b418 Show flash message 2025-10-20 20:18:35 +02:00
Eugene Burmakin
632f389ace Remember enabled map layers for users 2025-10-20 20:11:28 +02:00
Eugene Burmakin
e7884b1f4f Properly provide default distance unit in user settings 2025-10-20 19:42:24 +02:00
dependabot[bot]
2accbeef3d
Bump rubyzip from 3.1.0 to 3.2.0 
Bumps [rubyzip](https://github.com/rubyzip/rubyzip) from 3.1.0 to 3.2.0.
- [Release notes](https://github.com/rubyzip/rubyzip/releases)
- [Changelog](https://github.com/rubyzip/rubyzip/blob/main/Changelog.md)
- [Commits](https://github.com/rubyzip/rubyzip/compare/v3.1.0...v3.2.0)

---
updated-dependencies:
- dependency-name: rubyzip
  dependency-version: 3.2.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
 2025-10-20 14:49:44 +00:00
dependabot[bot]
b413c51c4f
Bump puma from 6.6.1 to 7.1.0 
Bumps [puma](https://github.com/puma/puma) from 6.6.1 to 7.1.0.
- [Release notes](https://github.com/puma/puma/releases)
- [Changelog](https://github.com/puma/puma/blob/main/History.md)
- [Commits](https://github.com/puma/puma/compare/v6.6.1...v7.1.0)

---
updated-dependencies:
- dependency-name: puma
  dependency-version: 7.1.0
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
 2025-10-20 14:44:36 +00:00
Evgenii Burmakin
84f8ec0d04
Merge pull request #1856 from Freika/fix/google-imports-speedup 
Improve performance of Google Maps imports by batching database inserts.
 2025-10-16 19:01:59 +02:00
Eugene Burmakin
cdd5525ff4 Update changelog 2025-10-16 19:01:39 +02:00
Eugene Burmakin
1671a781b0 Improve performance of Google Maps imports by batching database inserts. 2025-10-16 18:59:21 +02:00
snyk-bot
d46cd2dc74
fix: Gemfile to reduce vulnerabilities 
The following vulnerabilities are fixed with an upgrade:
- https://snyk.io/vuln/SNYK-RUBY-RACK-13535097
- https://snyk.io/vuln/SNYK-RUBY-RACK-13524628
- https://snyk.io/vuln/SNYK-RUBY-URI-13506785
 2025-10-16 11:00:00 +00:00
Eugene Burmakin
e3c6da1332 Add tooltips to map controls 2025-10-15 12:01:51 +02:00
Eugene Burmakin
44cbfff8ff Extract map controls to a separate file 2025-10-15 11:43:49 +02:00